Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public swagger #6381

Closed
wants to merge 10 commits into from
Closed

Update public swagger #6381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f756788
Modify the public swagger by reference to private swagger
Mar 14, 2019
3015288
Merge remote-tracking branch 'upstream/master'
Apr 23, 2019
2727b7c
Merge remote-tracking branch 'upstream/master'
Apr 25, 2019
047db66
Merge remote-tracking branch 'upstream/master'
May 15, 2019
1a04dc6
Merge remote-tracking branch 'upstream/master'
May 22, 2019
7e6a62e
Merge remote-tracking branch 'upstream/master'
Jun 14, 2019
39e11c9
Merge remote-tracking branch 'upstream/master'
Jun 19, 2019
aedfef3
July2th
Jun 19, 2019
a8c996b
July2th
Jun 19, 2019
15aa824
back Binary
Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...source-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@
"properties": {
"activity": {
"description": "Activity name.",
"type": "string"
"type": "string",
"minLength": 1
},
"dependencyConditions": {
"type": "array",
Expand Down
14 changes: 12 additions & 2 deletions ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@
"properties": {
"activity": {
"description": "Activity name.",
"type": "string"
"type": "string",
"minLength": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change. Looks like this restriction is added in the existing api-version.

},
"dependencyConditions": {
"type": "array",
Expand Down Expand Up @@ -824,6 +825,10 @@
"maxConcurrentConnections": {
"type": "object",
"description": "The maximum concurrent connection count for the source data store. Type: integer (or Expression with resultType integer)."
},
"disableMetricsCollection": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writable properties are typically added in new api-version as they can result in unintentional update of goal state when done in same api-version.

"type": "object",
"description": "Specifies whether to disable collecting data source metrics. Type: boolean (or Expression with resultType boolean)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update x-ms-examples for the operation that uses this model in the request body or response body and populate the example with this new property that has been added in this PR.

}
},
"additionalProperties": {
Expand Down Expand Up @@ -1051,7 +1056,8 @@
"PartitionOnInt",
"PartitionOnCalendarYear",
"PartitionOnCalendarMonth",
"PartitionOnCalendarDate"
"PartitionOnCalendarDate",
"PartitionOnTime"
],
"x-ms-enum": {
"name": "TabularPartitionOption",
Expand Down Expand Up @@ -2158,6 +2164,10 @@
"maxConcurrentConnections": {
"type": "object",
"description": "The maximum concurrent connection count for the sink data store. Type: integer (or Expression with resultType integer)."
},
"disableMetricsCollection": {
"type": "object",
"description": "Specifies whether to disable collecting data source metrics. Type: boolean (or Expression with resultType boolean)."
}
},
"additionalProperties": {
Expand Down