Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compute.json to include hyperVGeneration property for Virtua… #6367

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Update compute.json to include hyperVGeneration property for Virtua… #6367

merged 1 commit into from
Jun 20, 2019

Conversation

srvar
Copy link
Contributor

@srvar srvar commented Jun 17, 2019 •
edited
Loading

…lMachineInstanceView

Adds hyperVGeneration which displays what HyperVisor Generation the VM Boots in, via the VirtualMachineInstanceView.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@srvar
Update compute.json to include hyperVGeneration property for VirtualM…
5e589ea 
…achineInstanceView

Adds hyperVGeneration  which displays what HyperVisor Generation the VM Boots in, via the VirtualMachineInstanceView.
@srvar srvar requested review from huangpf and hyonholee as code owners June 17, 2019 22:20
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 5e589ea)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 17, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3878

@AutorestCI AutorestCI mentioned this pull request Jun 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5853

@AutorestCI AutorestCI mentioned this pull request Jun 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5044

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from jhendrixMSFT June 17, 2019 23:03
@AutorestCI
Copy link

AutorestCI commented Jun 18, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@hyonholee
Copy link
Contributor

LGTM. The failed test (required) doesn't seem to be related with this PR.

@hyonholee hyonholee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 18, 2019
@srvar srvar changed the title [Do Not Merge] Update compute.json to include hyperVGeneration property for Virtua… Update compute.json to include hyperVGeneration property for Virtua… Jun 18, 2019
majastrz
majastrz approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is technically a breaking change, the API itself is GET-only. Based on that, I think we can allow it.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2019
@jhendrixMSFT jhendrixMSFT merged commit 5711e64 into Azure:master Jun 20, 2019
@hyonholee hyonholee mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@majastrz majastrz majastrz approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srvar @AutorestCI @azuresdkci @hyonholee @jhendrixMSFT @majastrz