Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a property name of SignalRService #6345

Merged
merged 5 commits into from
Jun 21, 2019
Merged

Update a property name of SignalRService #6345

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32bc4db
Add signalr service data definition
zackliu May 8, 2019
70e457a
Update readme
zackliu May 8, 2019
0d1a9cb
Fix the format of date-time
zackliu May 17, 2019
ac43dd4
Make a change to the properties
zackliu Jun 14, 2019
1296160
Merge remote-tracking branch 'azure/master'
zackliu Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ation/eventgrid/data-plane/Microsoft.SignalRService/stable/2018-01-01/SignalRService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"format": "date-time",
"type": "string"
},
"hub": {
"hubName": {
Copy link
Contributor

@michaeljqzq michaeljqzq Jun 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a breaking change in stable version here? If yes, we suggest introducing new api-version when including breaking changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the overall EventGrid service is GA, many first party publishers onboard to EventGrid on a continuous basis to publish events to EventGrid and these events preview/GA per the timeframe of the publishing service. I don't think SignalRService events (in this swagger) have GA'ed yet, hence this change wouldn't break any customers (@zackliu, please correct me if that's not correct).

Copy link
Member Author

@zackliu zackliu Jun 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event grid for SignalR service haven't been in public preview now. So, I think it's not a breaking change.

"description": "The hub of connected client connection.",
"type": "string"
},
Expand All @@ -39,7 +39,7 @@
"format": "date-time",
"type": "string"
},
"hub": {
"hubName": {
"description": "The hub of connected client connection.",
"type": "string"
},
Expand Down