Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a property name of SignalRService #6345

Merged
merged 5 commits into from
Jun 21, 2019
Merged

Conversation

zackliu
Copy link
Member

@zackliu zackliu commented Jun 14, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@zackliu zackliu requested a review from kalyanaj as a code owner June 14, 2019 06:25
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 14, 2019

SDK Automation [Logs] (Generated from 1296160)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6007

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2663

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@@ -16,7 +16,7 @@
"format": "date-time",
"type": "string"
},
"hub": {
"hubName": {
Copy link
Contributor

@michaeljqzq michaeljqzq Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a breaking change in stable version here? If yes, we suggest introducing new api-version when including breaking changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the overall EventGrid service is GA, many first party publishers onboard to EventGrid on a continuous basis to publish events to EventGrid and these events preview/GA per the timeframe of the publishing service. I don't think SignalRService events (in this swagger) have GA'ed yet, hence this change wouldn't break any customers (@zackliu, please correct me if that's not correct).

Copy link
Member Author

@zackliu zackliu Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event grid for SignalR service haven't been in public preview now. So, I think it's not a breaking change.

@michaeljqzq michaeljqzq merged commit 15b2184 into Azure:master Jun 21, 2019
@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants