-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a property name of SignalRService #6345
Conversation
SDK Automation [Logs] (Generated from 1296160)
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
@@ -16,7 +16,7 @@ | |||
"format": "date-time", | |||
"type": "string" | |||
}, | |||
"hub": { | |||
"hubName": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a breaking change in stable version here? If yes, we suggest introducing new api-version when including breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the overall EventGrid service is GA, many first party publishers onboard to EventGrid on a continuous basis to publish events to EventGrid and these events preview/GA per the timeframe of the publishing service. I don't think SignalRService events (in this swagger) have GA'ed yet, hence this change wouldn't break any customers (@zackliu, please correct me if that's not correct).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Event grid for SignalR service haven't been in public preview now. So, I think it's not a breaking change.
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.