[Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview #5622

ampravinr · 2019-04-12T03:52:16Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…-01-01 to version 2019-04-01-preview

Usage Details API Contract changes - Usage Details model changes - Usage details sample changes for the new model - Usage Details download operation details - Sample for usage details download - Removed used oprerations and samples

- Added new samples for the query parameters - Changed the "in" from path to query since this is optional query parameter.

Included the samples in the consumption list

- changed the values in samples.

- Change in samples

- changed the sample values

Changed the sample value

Upated the sample file name in consumption.json

- added the scope parameters for the samples

Scope parameter fixed in samples

Scope parameters added to the samples

added scope parameter to the samples

Scope parameter changes

Tags scope changes

Fixed date and download issues

UsageDetails_Download operation id change

AutorestCI · 2019-04-12T03:53:04Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2158

AutorestCI · 2019-04-12T03:53:16Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#2667

azuresdkci · 2019-04-12T03:53:20Z

Can one of the admins verify this patch?

AutorestCI · 2019-04-12T03:53:34Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-04-12T03:55:09Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

adxsdknet · 2019-04-12T03:59:15Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5778
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@a79e3e9
adxsdknet/azure-sdk-for-net@3f33a0b
adxsdknet/azure-sdk-for-net@1ea4c83
adxsdknet/azure-sdk-for-net@7784690
adxsdknet/azure-sdk-for-net@ee4fa56
adxsdknet/azure-sdk-for-net@fa880f0
adxsdknet/azure-sdk-for-net@6aa745a
adxsdknet/azure-sdk-for-net@a9649b0

ampravinr · 2019-04-19T21:51:48Z

Yes. Currently I am working to accommodate the Enum change you suggested on the query string to make it Enum. Once I make changes and pushed the changes I will try to resume the Arm review to see review it and get sign off. Also we where trying to see whether we can accommodate the change Arm suggested for listing different models based on kind and for now we cannot accommodate that so will go ahead with this for the Preview version. Thanks, Praveen Radhakrishnan

…

________________________________ From: Veronica Giaudrone <notifications@github.com> Sent: Friday, April 19, 2019 8:33:12 PM To: Azure/azure-rest-api-specs Cc: Praveen Radhakrishnan; Mention Subject: Re: [Azure/azure-rest-api-specs] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview (#5622) @ampravinr<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fampravinr&data=02%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7Cc12d87d61f1c463c973e08d6c5063e72%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636913027945897093&sdata=qbyUFegl7QJ2tqXoZdz%2BVoYwwl8g0lOt69bHEObga3U%3D&reserved=0> will you be making any changes based on the comments? are you following up with ARM team offline on their questions? Thanks! - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F5622%23issuecomment-485007146&data=02%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7Cc12d87d61f1c463c973e08d6c5063e72%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636913027945907102&sdata=h8W82TN7S5EtLUTBOS%2B3%2FWv%2FLieW8zUHxKY4uXJe5aM%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJXK4GRFYJIDI2EP6Q5XHOTPRIUARANCNFSM4HFNDMHA&data=02%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7Cc12d87d61f1c463c973e08d6c5063e72%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636913027945907102&sdata=xcvCtD16cmq5iG%2FDQNsvEC4UyLo8rte28AjqZka78dA%3D&reserved=0>.

defined allowed values for the metricParameter enum

Changed the download samples accordingly

veronicagg · 2019-04-23T01:11:25Z

@ampravinr ok, please work with ARM team on the ARM changes, so they sign off on the PR.
Regarding CI I see python SDK for example failing to generate with this error: System.InvalidOperationException: Values specified by 'enum' mismatch those specified by 'x-ms-enum' (name: 'metrictype'): 'daily', 'monthly' vs 'usage', 'actualcost', 'amortizedcost'. Please take a look.

Fixed the enum values for metric types

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

changed the sample to match the enum case

ampravinr · 2019-04-25T08:41:32Z

@ampravinr ok, please work with ARM team on the ARM changes, so they sign off on the PR.
Regarding CI I see python SDK for example failing to generate with this error: System.InvalidOperationException: Values specified by 'enum' mismatch those specified by 'x-ms-enum' (name: 'metrictype'): 'daily', 'monthly' vs 'usage', 'actualcost', 'amortizedcost'. Please take a look.

@veronicagg - thanks for pointing me the error. I have fixed it. Please review and let me know if any issues.

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

veronicagg · 2019-04-26T00:14:20Z

I'm good from my side, approval pending on ARM team's signoff. Thanks!

Removed additional property for OData-EntityId.

Removed Odata-EntityId from samples

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

Based on the Doc Preview generated we want to change how the name appears. So changing the operation name for downloads.

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

ms-premp · 2019-04-29T22:41:59Z

@ravbhatnagar we are waiting on ARM Feedback on this PR. Please have a look. Our public announcements for this preview version is at present waiting on this swagger changes.

ravbhatnagar · 2019-05-02T14:58:14Z

Two concerns around this were discussed - 1. RBAC 2. Activity Log + Alert story. With this kind of modeling of action over collection. ARM will not parse the authorization action correctly as the instance segment is missing. hence what gets put in activity log will be wrong. And similarly RBAC will not be over the action which is what this API is. But since this is tenant level, RP handles its own RBAC. And since its tenant level, such logs dont get shown in activity log today. So these concerns are mitigated. ARM should look at this pattern and see if it makes sense to support it.
The RP has agreed that this approval is for preview only. We will have another discussion for the GA story.
Signing off from ARM side.

ampravinr · 2019-05-02T18:04:33Z

@veronicagg - we have the Arm sign off. Could you please merge these changes.

ampravinr · 2019-05-02T18:20:27Z

Thanks Veronica for all the help on this. Thanks, Praveen Radhakrishnan From: Veronica Giaudrone <notifications@github.com> Sent: Thursday, May 2, 2019 11:14 AM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Praveen Radhakrishnan <Praveen.Radhakrishnan@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview (#5622) Merged #5622<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F5622&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C4ccf3990d1f24ed02dcb08d6cf29fac1%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=jWMxEYHzLy918eeZ3JG758r%2FkyLT6x6Y9xkiA%2BA4oVQ%3D&reserved=0> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F5622%23event-2315306404&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C4ccf3990d1f24ed02dcb08d6cf29fac1%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=wmjaezRGp0so%2FlZ0ypkuUjFF%2BuU2HyNYTPSTPdEetFM%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJXK4GQYOHC4LSREW562Q53PTMVPHANCNFSM4HFNDMHA&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C4ccf3990d1f24ed02dcb08d6cf29fac1%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=HjLudPdVPdXx7Ugi6R2JJk6MHq76RdJgVzetKCbRt7Q%3D&reserved=0>.

* .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit * .NET SDK Resource Provider:'Consumption' REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

ampravinr and others added 19 commits April 11, 2019 10:57

Adds base for updating Microsoft.Consumption from version stable/2019…

e42fa06

…-01-01 to version 2019-04-01-preview

Updates readme

61a5c40

Updates API version in new specs and examples

c64058b

Usage Details API contract changes

7b39dc1

- Added new samples for the query parameters - Changed the "in" from path to query since this is optional query parameter.

Usage Details API contract changes for 2019-04-01-preview

db03399

Included the samples in the consumption list

Usage Details API contract changes for 2019-04-01-preview

ba98b1e

- changed the values in samples.

Usage API contract changes

28f3cd2

- Change in samples

Update UsageDetailsExpand.json

ef8c082

- changed the sample values

Update UsageDetailsExpand.json

99335ce

Changed the sample value

Update consumption.json

5a2304f

Upated the sample file name in consumption.json

Scope parameters added for the samples

07fb3b4

- added the scope parameters for the samples

Scope parameter fix

4b0ebb8

Scope parameter fixed in samples

Scope parameters

7645b8f

Scope parameters added to the samples

changed the scope parameter

3f24bd5

added scope parameter to the samples

Correcting scope parameter

0252952

Scope parameter changes

Update Tags.json

f31e7c3

Tags scope changes

Fixed download and mg aggregated cost issues

bcc27a7

Fixed date and download issues

UsageDetails_Download operation id change

3eff072

UsageDetails_Download operation id change

AutorestCI mentioned this pull request Apr 12, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview Azure/azure-sdk-for-python#4832

Merged

AutorestCI mentioned this pull request Apr 12, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview Azure/azure-sdk-for-js#2201

Closed

azuresdkci assigned veronicagg Apr 12, 2019

azuresdkci requested a review from veronicagg April 12, 2019 03:53

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 12, 2019

.NET SDK Resource Provider:'Consumption'

a79e3e9

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

ampravinr added 2 commits April 19, 2019 15:19

metricParameter changes

edc4c8d

defined allowed values for the metricParameter enum

Changed the samples for ValidTill

2465970

Changed the download samples accordingly

AutorestCI mentioned this pull request Apr 19, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview Azure/azure-sdk-for-go#4593

Closed

Fixed the enum values for metric types

f451273

Fixed the enum values for metric types

AutorestCI mentioned this pull request Apr 25, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview Azure/azure-sdk-for-js#2480

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 25, 2019

.NET SDK Resource Provider:'Consumption'

ee4fa56

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

changed the sample to match the case

b68ef19

changed the sample to match the enum case

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 25, 2019

.NET SDK Resource Provider:'Consumption'

fa880f0

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

ampravinr added 2 commits April 25, 2019 19:15

As per review removed the OData-EntityId

bc07306

Removed additional property for OData-EntityId.

Changed the examples

5eb100d

Removed Odata-EntityId from samples

AutorestCI mentioned this pull request Apr 26, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview Azure/azure-sdk-for-js#2506

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 26, 2019

.NET SDK Resource Provider:'Consumption'

6aa745a

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

OperationId change for Downloads

f7c6fd4

Based on the Doc Preview generated we want to change how the name appears. So changing the operation name for downloads.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 26, 2019

.NET SDK Resource Provider:'Consumption'

a9649b0

REST Spec PR 'Azure/azure-rest-api-specs#5622' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 2, 2019

veronicagg approved these changes May 2, 2019

View reviewed changes

veronicagg merged commit 058da7a into Azure:master May 2, 2019

AutorestCI mentioned this pull request May 2, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview Azure/azure-sdk-for-js#2666

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview #5622

[Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview #5622

ampravinr commented Apr 12, 2019

AutorestCI commented Apr 12, 2019 •

edited

Loading

AutorestCI commented Apr 12, 2019 •

edited

Loading

azuresdkci commented Apr 12, 2019

AutorestCI commented Apr 12, 2019 •

edited

Loading

AutorestCI commented Apr 12, 2019 •

edited

Loading

adxsdknet commented Apr 12, 2019 •

edited

Loading

ampravinr commented Apr 19, 2019 via email

veronicagg commented Apr 23, 2019

ampravinr commented Apr 25, 2019

veronicagg commented Apr 26, 2019

ms-premp commented Apr 29, 2019

ravbhatnagar commented May 2, 2019

ampravinr commented May 2, 2019

ampravinr commented May 2, 2019 via email

[Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview #5622

[Hub Generated] Review request for Microsoft.Consumption to add version preview/2019-04-01-preview #5622

Conversation

ampravinr commented Apr 12, 2019

Contribution checklist:

AutorestCI commented Apr 12, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 12, 2019 • edited Loading

Automation for azure-sdk-for-js

azuresdkci commented Apr 12, 2019

AutorestCI commented Apr 12, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 12, 2019 • edited Loading

Automation for azure-sdk-for-go

adxsdknet commented Apr 12, 2019 • edited Loading

Automation for azure-sdk-for-net

ampravinr commented Apr 19, 2019 via email

veronicagg commented Apr 23, 2019

ampravinr commented Apr 25, 2019

veronicagg commented Apr 26, 2019

ms-premp commented Apr 29, 2019

ravbhatnagar commented May 2, 2019

ampravinr commented May 2, 2019

ampravinr commented May 2, 2019 via email

AutorestCI commented Apr 12, 2019 •

edited

Loading

AutorestCI commented Apr 12, 2019 •

edited

Loading

AutorestCI commented Apr 12, 2019 •

edited

Loading

AutorestCI commented Apr 12, 2019 •

edited

Loading

adxsdknet commented Apr 12, 2019 •

edited

Loading