Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAV #5004

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Update OAV #5004

merged 2 commits into from
Jan 8, 2019

Conversation

sergey-shandar
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@sergey-shandar sergey-shandar added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 8, 2019
@sergey-shandar
Copy link
Contributor Author

sergey-shandar commented Jan 8, 2019

@hovsepm model validation (PR_ONLY=false) should fail but it doesn't. I'm going to fix it and I'll let you know when it's ready to review.

@sergey-shandar sergey-shandar removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 8, 2019
@sergey-shandar
Copy link
Contributor Author

@hovsepm ready to review.

@hovsepm hovsepm merged commit 445f051 into master Jan 8, 2019
@sergey-shandar sergey-shandar deleted the sergey/update branch January 8, 2019 19:09
@AutorestCI
Copy link

AutorestCI commented Jan 8, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
* Update OAV

* clear cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants