New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql sku values #4994

Merged

praries880 merged 4 commits into Azure:master from zikalino:fix-mysql

Jan 16, 2019

zikalino commented Jan 5, 2019

Gen4 values are not supported/valid any more.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

zikalino added 4 commits

November 7, 2018 20:54


          fixed some invalid values in dl account examples

4bb8b99


          Merge pull request #1 from Azure/master

037cd89

merging from Azure


          Merge pull request #2 from Azure/master

a3e5dc6

merging from Azure


          updated sku as old sku doesn't work any longer

a1d4df1

openapi-portal-comment bot commented Jan 5, 2019

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI commented Jan 5, 2019 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

AutorestCI commented Jan 5, 2019 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

AutorestCI commented Jan 5, 2019 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

AutorestCI commented Jan 5, 2019 •

edited

Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

AutorestCI commented Jan 5, 2019 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

AutorestCI commented Jan 5, 2019 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

kpajdzik added the review label

Contributor

azuresdkci commented Jan 5, 2019

Can one of the admins verify this patch?

azuresdkci assigned praries880

azuresdkci requested a review from praries880

January 5, 2019 23:59

praries880 reviewed

View reviewed changes

.../resource-manager/Microsoft.DBforMySQL/preview/2017-12-01-preview/examples/ServerCreate.json

@@ @@ -18,10 +18,10 @@ @@
                       "createMode": "Default"
                     },
                     "sku": {
-                      "name": "B_Gen4_2",
+                      "name": "B_Gen5_2",

praries880 Jan 7, 2019 •

edited

Loading

@zikalino Are examples the only places these values appear at? Is there associated documentation or swagger spec that needs to be updated as well?

Author

zikalino Jan 10, 2019

@praries880 I think examples is the only place where you can find these values in the REST API specs. If examples are wrong the only way to figure out proper values is to go to the portal, or use Azure CLI to create the server and then see what values are correct.

Anyway, thanks for reminding me. I did a search and found out that we could also update response values -- this PR only fixes values in the requests.

praries880 Jan 10, 2019

@zikalino will you be updating the PR to fix the values in the responses as well?

Author

zikalino Jan 16, 2019

@praries880 everything is already correct, I haven't found any occurrences of Gen4 anywhere. So I think we can go ahead and merge this PR.

praries880 approved these changes

View reviewed changes

praries880 merged commit 5d20445 into Azure:master

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request


          Fix mysql sku values (Azure#4994)

* fixed some invalid values in dl account examples

* updated sku as old sku doesn't work any longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels