Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ResourceGroup example #4971

Merged
merged 6 commits into from
Jan 24, 2019
Merged

Adding ResourceGroup example #4971

merged 6 commits into from
Jan 24, 2019

Conversation

zikalino
Copy link

@zikalino zikalino commented Jan 2, 2019

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@kpajdzik kpajdzik added the review label Jan 2, 2019
@AutorestCI
Copy link

AutorestCI commented Jan 2, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

@AutorestCI AutorestCI mentioned this pull request Jan 2, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 2, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#504

@azuresdkci azuresdkci requested a review from dsgouda January 2, 2019 03:06
@AutorestCI AutorestCI mentioned this pull request Jan 2, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 2, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4232

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jan 2, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 2, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4192

@AutorestCI AutorestCI mentioned this pull request Jan 2, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 2, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jan 2, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@zikalino
Copy link
Author

zikalino commented Jan 2, 2019

I don't understand what is the problem here? seems like it contains about linter output which is not valid json format....

@dsgouda
Copy link
Contributor

dsgouda commented Jan 2, 2019

@veronicagg any idea why the linter diff would fail here

@dsgouda
Copy link
Contributor

dsgouda commented Jan 22, 2019

@zikalino This seems to be an issue with one of our tools, we are looking into it. Apologize for the delay.

@dsgouda dsgouda mentioned this pull request Jan 24, 2019
Closed
@AutorestCI AutorestCI mentioned this pull request Jan 24, 2019
Merged
@veronicagg
Copy link
Contributor

@dsgouda Hot-fixed the linter diff check issue and now it's all clear. Feel free to merge if you're ok with the change. Thanks!

dsgouda
dsgouda approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@veronicagg Thanks for the help

@dsgouda dsgouda merged commit 8cc6828 into Azure:master Jan 24, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@AnuTalluri
Adding ResourceGroup example (Azure#4971)
16fd8c6 
* fixed some invalid values in dl account examples

* adding resource group sample

* removed .

* updating script to handle output of batch processing from autorest (Azure#5081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zikalino @AutorestCI @azuresdkci @dsgouda @veronicagg @kpajdzik