-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating first and basic swagger for new RP of ASI (Azure Security In… #4970
Conversation
…sight). This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace. This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC.
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Hello!! The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays! Thanks and Have a WONDERFUL HOLIDAY |
Can one of the admins verify this patch? |
…eter and reuse it in the PUT same as in the GET
specification/securityinsight/preview/2019-01-01/SecurityInsight.json
Outdated
Show resolved
Hide resolved
specification/securityinsight/preview/2019-01-01/SecurityInsight.json
Outdated
Show resolved
Hide resolved
specification/securityinsight/preview/2019-01-01/SecurityInsight.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirgfani Your swagger does not have a readme.md file. The Individual language generators need a readme.md file to generate the SDK. Please add them so I can review the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the errors reported in this link https://travis-ci.org/Azure/azure-rest-api-specs/jobs/477310868 and fix it
Azure#4970) * Creating first and basic swagger for new RP of ASI (Azure Security Insight). This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace. This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC. * updating the operationalInsightsResourceProvider to be a global parameter and reuse it in the PUT same as in the GET * Fixing comments from PR * Fixing the Microsoft.OperationalInsight to the right form * Updating the location to be under- "resource-manager" * adding readme files for the swagger * Changing the path of the files to the correct path * Change the location of the readme files * Fixing inconsistency in the naming- changing everything to SecurityInsights * Missed the file when aligned the name to SecurityInsights * Fixing a redundant space in the examples * add alertRule to the CreateAlertRule.json and do some indentation fixes
…sight).
This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace.
This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC.
There is only one endpoint for alertRules that will be changed in the future.
I validate the swagger with autorest azure guidelines.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.