New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Get.json #4961

Merged

sarangan12 merged 1 commit into Azure:master from shouyangli:patch-2

Jan 2, 2019

Contributor

shouyangli commented Dec 25, 2018 •

edited

Loading

Sorry for not familiar with github and create 2 PRs.
Same as PR #4960
Quota value should not be negative. It will output wrong document at:
https://docs.microsoft.com/en-us/rest/api/azurestack/storagequotas/get

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          Update Get.json

83ea33a

Same as PR Azure#4960 
Quota value should not be negative. It will output wrong document at:
https://docs.microsoft.com/en-us/rest/api/azurestack/storagequotas/get

openapi-portal-comment bot commented Dec 25, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI commented Dec 25, 2018 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

AutorestCI commented Dec 25, 2018 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

AutorestCI commented Dec 25, 2018 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

AutorestCI commented Dec 25, 2018 •

edited

Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

AutorestCI commented Dec 25, 2018 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

AutorestCI commented Dec 25, 2018 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

kpajdzik added the review label

Contributor

azuresdkci commented Dec 25, 2018

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

Contributor

azuresdkci commented Dec 25, 2018

Can one of the admins verify this patch?

azuresdkci assigned sarangan12

azuresdkci requested a review from sarangan12

December 25, 2018 09:20

sarangan12 approved these changes

View reviewed changes

sarangan12 merged commit 2d5af45 into Azure:master

kpajdzik removed the review label

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request


          Update Get.json (Azure#4961)

09beecb

Same as PR Azure#4960 
Quota value should not be negative. It will output wrong document at:
https://docs.microsoft.com/en-us/rest/api/azurestack/storagequotas/get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet