Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exposure control APIs according to the ARM compliance requirement. #4958

Merged
merged 4 commits into from
Jan 16, 2019
Merged

Add exposure control APIs according to the ARM compliance requirement. #4958

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f81ef7f
Add exposure control APIs.
zhangyd2015 Dec 22, 2018
741fceb
Resolve reivew comments
zhangyd2015 Dec 27, 2018
0c64157
Delete API ExposureControl_GetFeatureBySubscription
zhangyd2015 Jan 8, 2019
32f235c
Resolve review comments
zhangyd2015 Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 129 additions & 0 deletions ...ion/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,105 @@
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.DataFactory/locations/{locationId}/getFeatureValue": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the usecase for this API? Is it doing something similar to Azure Feature Exposure Control (AFEC)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar ADF doesn't use Azure Feature Exposure Control, instead we have our own implemented in our backend which controls some throttling limits and enabled disabled features for the customer, and this API is allowing the user to query for a specific value.

"post": {
"tags": [
"exposureControl"
],
"operationId": "ExposureControl_GetFeature",
"x-ms-examples": {
"Factories_ConfigureFactoryRepo": {
"$ref": "./examples/ExposureControl_GetFeature.json"
}
},
"description": "Get exposure control feature for specific location.",
"parameters": [
{
"$ref": "#/parameters/subscriptionId"
},
{
"$ref": "#/parameters/locationId"
},
{
"$ref": "#/parameters/api-version"
},
{
"name": "exposureControlRequest",
"description": "The exposure control request.",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/ExposureControlRequest"
}
}
],
"responses": {
"200": {
"description": "OK.",
"schema": {
"$ref": "#/definitions/ExposureControlResponse"
}
},
"default": {
"description": "An error response received from the Azure Data Factory service.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/getFeatureValue": {
"post": {
"tags": [
"exposureControl"
],
"operationId": "ExposureControl_GetFeatureBySubscription",
"x-ms-examples": {
"Factories_ConfigureFactoryRepo": {
"$ref": "./examples/ExposureControl_GetFeatureBySubscription.json"
}
},
"description": "Get exposure control feature for specific data factory.",
"parameters": [
{
"$ref": "#/parameters/subscriptionId"
},
{
"$ref": "#/parameters/resourceGroupName"
},
{
"$ref": "#/parameters/factoryName"
},
{
"$ref": "#/parameters/api-version"
},
{
"name": "exposureControlRequest",
"description": "The exposure control request.",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/ExposureControlRequest"
}
}
],
"responses": {
"200": {
"description": "OK.",
"schema": {
"$ref": "#/definitions/ExposureControlResponse"
}
},
"default": {
"description": "An error response received from the Azure Data Factory service.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories": {
"get": {
"tags": [
Expand Down Expand Up @@ -4693,6 +4792,36 @@
"description": "The operation error message."
}
}
},
"ExposureControlRequest": {
"type": "object",
"description": "The exposure control request.",
"properties": {
"featureName": {
"type": "string",
"description": "The feature name."
},
"featureType": {
"type": "string",
"description": "The feature type."
}
}
},
"ExposureControlResponse": {
"type": "object",
"description": "The exposure control response.",
"properties": {
"featureName": {
"type": "string",
"description": "The feature name.",
"readOnly": true
},
"value": {
"type": "string",
"description": "The feature value.",
"readOnly": true
}
}
}
},
"parameters": {
Expand Down
23 changes: 23 additions & 0 deletions ...-manager/Microsoft.DataFactory/stable/2018-06-01/examples/ExposureControl_GetFeature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"parameters": {
"subscriptionId": "12345678-1234-1234-1234-12345678abc",
"locationId": "WestEurope",
"exposureControlRequest": {
"featureName": "ADFIntegrationRuntimeSharingRbac",
"featureType": "Feature"
},
"api-version": "2018-06-01"
},
"responses": {
"200": {
"headers": {
"Date": "Sat, 22 Dec 2018 09:46:07 GMT",
"X-Content-Type-Options": "nosniff"
},
"body": {
"featureName": "ADFIntegrationRuntimeSharingRbac",
"value": "False"
}
}
}
}
24 changes: 24 additions & 0 deletions ...soft.DataFactory/stable/2018-06-01/examples/ExposureControl_GetFeatureBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"parameters": {
"subscriptionId": "12345678-1234-1234-1234-12345678abc",
"resourceGroupName": "exampleResourceGroup",
"factoryName": "exampleFactoryName",
"exposureControlRequest": {
"featureName": "ADFIntegrationRuntimeSharingRbac",
"featureType": "Feature"
},
"api-version": "2018-06-01"
},
"responses": {
"200": {
"headers": {
"Date": "Sat, 22 Dec 2018 09:45:38 GMT",
"X-Content-Type-Options": "nosniff"
},
"body": {
"featureName": "ADFIntegrationRuntimeSharingRbac",
"value": "False"
}
}
}
}