-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resource provider Microsoft.EngagementFabric #4480
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
@xzsheng Please link the PR that was approved in the private repo |
...resource-manager/Microsoft.EngagementFabric/preview/2018-09-01-preview/EngagementFabric.json
Outdated
Show resolved
Hide resolved
@dsgouda The approved PR in private repo is https://github.com/Azure/azure-rest-api-specs-pr/pull/569 |
@jhendrixMSFT could you take a look at the Go generation failures, not sure why it's failing |
From the log:
Also I don't see the readme.go.md file. Please be sure to put Go SDK config in its own config file not readme.md. |
Thanks @jhendrixMSFT, @xzsheng please address the comments. You can refer to some existing readme.go.md files in the repo. |
@dsgouda Readme.go.md added. All checks are green now. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
The API spec was review and merged via Private repo PR 569