Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource provider Microsoft.EngagementFabric #4480

Merged
merged 6 commits into from
Nov 19, 2018

Conversation

xzsheng
Copy link
Member

@xzsheng xzsheng commented Nov 15, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

The API spec was review and merged via Private repo PR 569

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3332

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3823

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4125

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1924

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2617

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dsgouda dsgouda requested review from dsgouda and removed request for hovsepm November 15, 2018 16:14
@dsgouda dsgouda assigned dsgouda and unassigned hovsepm Nov 15, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Nov 15, 2018

@xzsheng Please link the PR that was approved in the private repo
Were there any additional changes made to the specs since the PR was approved?

@xzsheng
Copy link
Member Author

xzsheng commented Nov 16, 2018

@xzsheng Please link the PR that was approved in the private repo
Were there any additional changes made to the specs since the PR was approved?

@dsgouda The approved PR in private repo is https://github.com/Azure/azure-rest-api-specs-pr/pull/569
There is no change since the PR was approved.

@dsgouda
Copy link
Contributor

dsgouda commented Nov 16, 2018

@jhendrixMSFT could you take a look at the Go generation failures, not sure why it's failing

@jhendrixMSFT
Copy link
Member

From the log:

System.InvalidOperationException: codegen for preview swagger Microsoft.EngagementFabric/preview/2018-09-01/EngagementFabric.json must be under a preview subdirectory

Also I don't see the readme.go.md file. Please be sure to put Go SDK config in its own config file not readme.md.

@dsgouda
Copy link
Contributor

dsgouda commented Nov 16, 2018

Thanks @jhendrixMSFT, @xzsheng please address the comments. You can refer to some existing readme.go.md files in the repo.

@xzsheng
Copy link
Member Author

xzsheng commented Nov 19, 2018

Thanks @jhendrixMSFT, @xzsheng please address the comments. You can refer to some existing readme.go.md files in the repo.

@dsgouda Readme.go.md added. All checks are green now. Thanks.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 633272e into Azure:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants