Add initial set for changes for ANT79 #4435
+147
−15
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1632,7 +1632,7 @@ | |
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/networkConfig/virtualNetwork": { | ||
|
There was a problem hiding this comment. This may be beyond the scope of this PR, but this spec has a few operations that define There was a problem hiding this comment. @dsgouda Thanks for calling out the 404 status codes. I will talk to the feature owners to figure out if we should remove the status codes or use the experimental extension. We will change that as a new PR. Are you good with all the other changes? If so, please approve. There was a problem hiding this comment. Here is a brief explanation |
||
| "get": { | ||
| "tags": [ | ||
| "WebApps" | ||
|
|
@@ -8723,7 +8723,7 @@ | |
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/networkConfig/virtualNetwork": { | ||
| "get": { | ||
| "tags": [ | ||
| "WebApps" | ||
|
|
@@ -14923,6 +14923,58 @@ | |
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/snapshotsdr": { | ||
| "get": { | ||
| "tags": [ | ||
| "WebApps" | ||
| ], | ||
| "summary": "Returns all Snapshots to the user from DRSecondary endpoint.", | ||
| "description": "Returns all Snapshots to the user from DRSecondary endpoint.", | ||
| "operationId": "WebApps_ListSnapshotsFromDRSecondarySlot", | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/resourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "name": "name", | ||
| "in": "path", | ||
| "description": "Website Name.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "slot", | ||
| "in": "path", | ||
| "description": "Website Slot.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/subscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/apiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "schema": { | ||
| "$ref": "#/definitions/SnapshotCollection" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "App Service error response.", | ||
| "schema": { | ||
| "$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": "nextLink" | ||
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/sourcecontrols/web": { | ||
| "get": { | ||
| "tags": [ | ||
|
|
@@ -16573,6 +16625,51 @@ | |
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/snapshotsdr": { | ||
| "get": { | ||
| "tags": [ | ||
| "WebApps" | ||
| ], | ||
| "summary": "Returns all Snapshots to the user from DRSecondary endpoint.", | ||
| "description": "Returns all Snapshots to the user from DRSecondary endpoint.", | ||
| "operationId": "WebApps_ListSnapshotsFromDRSecondary", | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/resourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "name": "name", | ||
| "in": "path", | ||
| "description": "Website Name.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/subscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/apiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "schema": { | ||
| "$ref": "#/definitions/SnapshotCollection" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "App Service error response.", | ||
| "schema": { | ||
| "$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": "nextLink" | ||
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/sourcecontrols/web": { | ||
| "get": { | ||
| "tags": [ | ||
|
|
@@ -18578,6 +18675,10 @@ | |
| "snapshotTime": { | ||
| "description": "Point in time to restore the deleted app from, formatted as a DateTime string. \nIf unspecified, default value is the time that the app was deleted.", | ||
| "type": "string" | ||
| }, | ||
| "useDRSecondary": { | ||
| "description": "If true, the snapshot is retrieved from DRSecondary endpoint.", | ||
| "type": "boolean" | ||
| } | ||
| }, | ||
| "x-ms-client-flatten": true | ||
|
|
@@ -20163,6 +20264,10 @@ | |
| "description": "The Client Secret of this relying party application (in Azure Active Directory, this is also referred to as the Key).\nThis setting is optional. If no client secret is configured, the OpenID Connect implicit auth flow is used to authenticate end users.\nOtherwise, the OpenID Connect Authorization Code Flow is used to authenticate end users.\nMore information on OpenID Connect: http://openid.net/specs/openid-connect-core-1_0.html", | ||
| "type": "string" | ||
| }, | ||
| "clientSecretCertificateThumbprint": { | ||
| "description": "An alternative to the client secret, that is the thumbprint of a certifite used for signing purposes. This property acts as\na replacement for the Client Secret. It is also optional.", | ||
| "type": "string" | ||
| }, | ||
| "issuer": { | ||
| "description": "The OpenID Connect Issuer URI that represents the entity which issues access tokens for this application.\nWhen using Azure Active Directory, this value is the URI of the directory tenant, e.g. https://sts.windows.net/{tenant-guid}/.\nThis URI is a case-sensitive identifier for the token issuer.\nMore information on OpenID Connect Discovery: http://openid.net/specs/openid-connect-discovery-1_0.html", | ||
| "type": "string" | ||
|
|
@@ -21068,6 +21173,10 @@ | |
| "ignoreConflictingHostNames": { | ||
| "description": "If true, custom hostname conflicts will be ignored when recovering to a target web app.\nThis setting is only necessary when RecoverConfiguration is enabled.", | ||
| "type": "boolean" | ||
| }, | ||
| "useDRSecondary": { | ||
| "description": "If true, the snapshot is retrieved from DRSecondary endpoint.", | ||
| "type": "boolean" | ||
| } | ||
| }, | ||
| "x-ms-client-flatten": true | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changes being made to an existing stable version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to stable released versions must be approved by ARM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are additive. We do not want to release a new API-version for small non-breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, missed that. Since these are additive changes I would guess these are not breaking changes.