Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ACR C# specific config to C# #4070

Merged
merged 1 commit into from
Oct 3, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions specification/containerregistry/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ tag: package-2018-09
These settings apply only when `--tag=package-2018-09` is specified on the command line.

``` yaml $(tag) == 'package-2018-09'

csharp:
# stop the simplifier from making Task conflict:
skip-simplifier-on-namespace:
- System.Threading.Tasks

input-file:
- Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
- Microsoft.ContainerRegistry/stable/2018-09-01/containerregistry_build.json
Expand Down Expand Up @@ -122,6 +116,9 @@ Please also specify `--csharp-sdks-folder=<path to "SDKs" directory of your azur

``` yaml $(csharp)
csharp:
# stop the simplifier from making Task conflict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct.

By having csharp: in the global package scope, it does activate csharp every time.

(my bad!)

skip-simplifier-on-namespace:
- System.Threading.Tasks
# last generated using AutoRest.1.0.0-Nightly20170212 with commit 3b0b26b4b6e3bc5e7cf3610b0866d310abb5b814
azure-arm: true
license-header: MICROSOFT_MIT_NO_VERSION
Expand Down