-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ACR C# specific config to C# #4070
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
@@ -122,6 +116,9 @@ Please also specify `--csharp-sdks-folder=<path to "SDKs" directory of your azur | |||
|
|||
``` yaml $(csharp) | |||
csharp: | |||
# stop the simplifier from making Task conflict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is correct.
By having csharp:
in the global package scope, it does activate csharp every time.
(my bad!)
* Copying old api version for easier review * Changing api version * Update readme * Addressing issues * Updating examples to match new sku name * Adding properties back * Removing wrong descriptions
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger