Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ScheduledQueryRule resource documentation to include LogToMetricAction #3990

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Update ScheduledQueryRule resource documentation to include LogToMetricAction #3990

merged 2 commits into from
Sep 27, 2018

Conversation

jagpreetstamber
Copy link
Contributor

@jagpreetstamber jagpreetstamber commented Sep 24, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link

msftclas commented Sep 24, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI AutorestCI mentioned this pull request Sep 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3723

This was referenced Sep 24, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2139

@AutorestCI AutorestCI mentioned this pull request Sep 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2852

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Sep 24, 2018
@sergey-shandar
Copy link
Contributor

@gucalder please, review the PR.

gucalder
gucalder approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@gucalder gucalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@sergey-shandar sergey-shandar added ARM-overdue ARM review has not occurred within the expected timeframe and removed ARM-overdue ARM review has not occurred within the expected timeframe WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 27, 2018
@sergey-shandar sergey-shandar merged commit 5b8de53 into Azure:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@gucalder gucalder gucalder approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
ARM-overdue ARM review has not occurred within the expected timeframe potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jagpreetstamber @msftclas @AutorestCI @azuresdkci @sergey-shandar @gucalder