[HDInsight] Added additional parameters for security profile #3849

wawon-msft · 2018-09-08T21:46:46Z

Note: this API change has not yet been deployed RP-side. I am opening this pull request beforehand to get this API change approved.

We are adding optional parameters to the cluster resource, but we do not expect this to be a breaking change, as this is not modifiable after the initial PUT.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-08T21:47:35Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3306

AutorestCI · 2018-09-08T21:48:01Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2018-09-08T21:48:13Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-08T21:48:49Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp4peoek7w/rest/specification/hdinsight/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp4peoek7w/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.71', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.71->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06-preview"} .
FATAL: System.NotImplementedException: Handling return type 'Map<String, String>' for OtherMethod is not implemented
   at AutoRest.Java.Azure.Fluent.Model.OtherMethod.get_InnerReturnType() in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/OtherMethods/OtherMethod.cs:line 70
   at AutoRest.Java.Azure.Fluent.Model.OtherMethod.get_ReturnModel() in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/OtherMethods/OtherMethod.cs:line 82
   at AutoRest.Java.Azure.Fluent.Model.OtherMethods.<>c.<get_OtherFluentModels>b__12_0(OtherMethod om) in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/OtherMethods/OtherMethods.cs:line 162
   at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source)
   at AutoRest.Java.Azure.Fluent.Model.OtherMethods.get_ImportsForInterface() in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/OtherMethods/OtherMethods.cs:line 43
   at AutoRest.Java.Azure.Fluent.Model.FluentMethodGroup.get_ImportsForInterface() in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/FluentMethodGroup.cs:line 316
   at AutoRest.Java.Azure.Fluent.Model.ProxyFluentMethodGroup.get_ImportsForInterface() in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/ProxyFluentMethodGroup.cs:line 135
   at AutoRest.Java.Azure.Fluent.Model.FluentMethodGroupInterfaceModel.get_Imports() in /opt/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/FluentMethodGroupInterfaceModel.cs:line 41
   at AutoRest.Java.azurefluent.Templates.FluentCommon.FluentMethodGroupInterfaceTemplate.<ExecuteAsync>d__1.MoveNext() in /opt/vsts/work/1/s/src/obj/Razor/azurefluent/Templates/FluentCommon/FluentMethodGroupInterfaceTemplate.cshtml:line 21
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.<Generate>d__6.MoveNext() in /opt/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 63
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.<ProcessInternal>d__3.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Process() cancelled due to exception : Plugin java reported failure.
Failure during batch task - {"tag":"package-2018-06-preview"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.

AutorestCI · 2018-09-08T21:48:51Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3552

AutorestCI · 2018-09-08T21:50:43Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2803

marstr · 2018-09-10T23:03:35Z

@RikkiGibson, have any insights into the Java errors seen above?

RikkiGibson · 2018-09-11T00:11:02Z

Nothing on the top of my head, wonder if @jianghaolu has any idea

KrisBash · 2018-09-12T03:28:30Z

...ation/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json

@@ -446,6 +446,14 @@
                        "type": "string"
                    },
                    "description": "Optional. The Distinguished Names for cluster user groups"
+                },
+                "aaddsResourceId": {


Keep in mind – there is some risk in adding properties without incrementing the API version. This largely depends on the service behavior. In cases of update, a down-level client may PUT/PATCH the resource omitting these added properties (which may have been set by a newer client/portal) while updating other properties. In this case, what happens to the resource? Will the behavior be understood by the user? Incrementing API version enables you to have more control in these cases – such as blocking updates by older API versions.

This should be safe, as we don't allow PUTs or PATCHs (other than tags) on this resource after creation, and will definitely not enable such modifications until the next API version.

KrisBash

Please reference comments about adding properties within an API version

marstr · 2018-09-18T17:11:29Z

I'm going to move ahead, even though the Java integration is still failing. Are you ready for me to merge, @wawon-msft?

marstr · 2018-09-21T23:17:13Z

Closing this PR as stale. Feel free to have it re-opened or to create a new PR and reference this one for review purposes.

AutorestCI · 2018-09-22T01:12:48Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

wawon-msft · 2018-09-26T19:10:01Z

Sorry for the inactivity- I'll open a new PR, as we're ready to merge now.

[HDInsight] Added additional parameters for security profile

8bf7438

AutorestCI mentioned this pull request Sep 8, 2018

[AutoPR hdinsight/resource-manager] [HDInsight] Added additional parameters for security profile Azure/azure-sdk-for-python#3306

Closed

azuresdkci assigned marstr Sep 8, 2018

azuresdkci requested a review from marstr September 8, 2018 21:48

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 10, 2018

KrisBash reviewed Sep 12, 2018

View reviewed changes

KrisBash approved these changes Sep 12, 2018

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 12, 2018

marstr approved these changes Sep 18, 2018

View reviewed changes

marstr closed this Sep 21, 2018

AutorestCI mentioned this pull request Sep 22, 2018

[AutoPR hdinsight/resource-manager] [HDInsight] Added additional parameters for security profile Azure/azure-sdk-for-go#2803

Closed

wawon-msft mentioned this pull request Sep 26, 2018

[HDInsight] Added additional parameters for security profile #4011

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HDInsight] Added additional parameters for security profile #3849

[HDInsight] Added additional parameters for security profile #3849

wawon-msft commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

azuresdkci commented Sep 8, 2018

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

marstr commented Sep 10, 2018

RikkiGibson commented Sep 11, 2018

KrisBash Sep 12, 2018

wawon-msft Sep 12, 2018

KrisBash left a comment

marstr commented Sep 18, 2018

marstr commented Sep 21, 2018

AutorestCI commented Sep 22, 2018 •

edited

Loading

wawon-msft commented Sep 26, 2018

[HDInsight] Added additional parameters for security profile #3849

[HDInsight] Added additional parameters for security profile #3849

Conversation

wawon-msft commented Sep 8, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Sep 8, 2018

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-go

marstr commented Sep 10, 2018

RikkiGibson commented Sep 11, 2018

KrisBash Sep 12, 2018

Choose a reason for hiding this comment

wawon-msft Sep 12, 2018

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

marstr commented Sep 18, 2018

marstr commented Sep 21, 2018

AutorestCI commented Sep 22, 2018 • edited Loading

Automation for azure-sdk-for-js

wawon-msft commented Sep 26, 2018

wawon-msft commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 22, 2018 •

edited

Loading