Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add security fields to directline channel site for botservice #3817

Merged
merged 3 commits into from
Sep 6, 2018
Merged

add security fields to directline channel site for botservice #3817

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce0ac2b
add security fields to directline channel site
Sep 5, 2018
409e6ef
improve documentation for trusted origins field
swagatmishra2007 Sep 6, 2018
d79326c
actually fix the description
swagatmishra2007 Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ...ation/botservice/resource-manager/Microsoft.BotService/preview/2018-07-12/botservice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2092,15 +2092,26 @@
},
"isEnabled": {
"type": "boolean",
"description": "Whether this site is enabled for DirectLine channel"
"description": "Whether this site is enabled for DirectLine channel."
},
"isV1Enabled": {
"type": "boolean",
"description": "Whether this site is enabled for Bot Framework V1 protocol"
"description": "Whether this site is enabled for Bot Framework V1 protocol."
},
"isV3Enabled": {
"type": "boolean",
"description": "Whether this site is enabled for Bot Framework V1 protocol"
"description": "Whether this site is enabled for Bot Framework V1 protocol."
},
"isSecureSiteEnabled": {
"type": "boolean",
"description": "Whether this site is enabled for authentication with Bot Framework."
},
"trustedOrigins": {
"type": "array",
"description": "List of Trusted Origin url's for this site.This field is applicable only if isSecureSiteEnabled is True.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swagatmishra2007 - You didn't actually fix it :)

  • Please capitalize "URLs"
  • Please add a space character (" ") after the period (".").

"items": {
"type": "string"
}
}
},
"description": "A site for the Direct Line channel",
Expand Down