Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datafactory] Add folders to Pipeline and Dataset #3636

Merged
merged 4 commits into from
Aug 28, 2018
+21 −1
Merged

[Datafactory] Add folders to Pipeline and Dataset #3636

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b207da0
Update Pipeline.json
arsunda Aug 14, 2018
89afa6a
Update Dataset.json
arsunda Aug 14, 2018
e4a6b76
Update Pipeline.json
arsunda Aug 14, 2018
c0f87ba
Update Dataset.json
arsunda Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...factory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@
"items": {
"type": "object"
}
},
"folder": {
"description": "The folder that this Dataset is in.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this property is omitted, is there a default folder that is used? If so, it may be worth mentioning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the entities will appear at the root level unless a folder is specified. If that is worth mentioning then i can add that in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

"type": "object",
"properties": {
"name": {
"description": "The name of the folder that this Dataset is in.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

"type": "string"
}
}
}
},
"additionalProperties": {
Expand Down
12 changes: 11 additions & 1 deletion ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,17 @@
"items": {
"type": "object"
}
}
},
"folder": {
"description": "The folder that this Pipeline is in.",
"type": "object",
"properties": {
"name": {
"description": "The name of the folder that this Pipeline is in.",
"type": "string"
}
}
}
}
},
"Activity": {
Expand Down