Publicipprefixaugust #3618

anilingle-ms · 2018-08-09T19:42:16Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…urceModel

…s/azure-rest-api-specs into publicipprefixaugust

azuresdkci · 2018-08-09T19:45:08Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-09T19:52:35Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3122

AutorestCI · 2018-08-09T21:04:07Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1557

AutorestCI · 2018-08-09T21:20:15Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3321

AutorestCI · 2018-08-09T21:22:34Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2437

AutorestCI · 2018-08-09T21:27:55Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2313

lmazuel

Invalid JSON needs to be fixed before we can look at the CI for details.
Thanks!

lmazuel · 2018-08-09T22:44:38Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

@@ -6817,6 +6817,10 @@
          "$ref": "#/definitions/VirtualMachineScaleSetIpTag"
          },
        "description": "The list of IP tags associated with the public IP address."
+        },
+       "publicIPPrefix": {
+	"$ref": "#/definitions/SubResource"


Missing comma

lmazuel · 2018-08-10T00:10:31Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

@@ -6817,6 +6817,10 @@
          "$ref": "#/definitions/VirtualMachineScaleSetIpTag"
          },
        "description": "The list of IP tags associated with the public IP address."
+        },
+       "publicIPPrefix": {


This API of Compute has already been released. Are you saying that this field is already available, or you will add it later at the same time Network 2018-07-01 goes public?
Please tag someone from VMSS team to confirm this.

The field is already available to the public.

Network 2018-07-01 is also public already

lmazuel

Concerns about changing a stable compute file here.

lmazuel

Broken CI unrelated to the content of the PR, merging

* Created folder for 2018-07-01 api version (#3509) * Created folder for 2018-07-01 api version * fixed incorrect encoding symbol * Fix lint diff and improve output on failure (#3528) Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash. * Python conf for Network 2018-06 (#3535) * Py conf for Network 2018-07-01 (#3539) * Introduce Publicipprefix to swagger (#3520) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Publicipprefixaugust (#3573) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Service Endpoint Policies Swagger (#3558) * Service Endpoint Policies Swagger * Fix review comments * Updated Network Usage location parameter pattern (#3583) * Add enableTcpReset property to load balancer (#3545) * Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset. * added global reach flag (#3542) * fix query packet capture status in latest version (#3601) * Publicipprefixaugust (#3618) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Publicipprefixaugust (#3631) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties * Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647) Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003 * Added new API to networkwatcher.json and examples (#3650) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655) * Add/Edit Outbound Rule on Load Balancer and Examples (#3592) * Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit * Removed QueryConnectionMOnitors API (#3661) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

* Revert "Adding Microsoft.Solutions 2021-02-01-preview (#3563)" This reverts commit ff3bc45. * Revert "Revert "Adding Microsoft.Solutions 2021-02-01-preview (#3563)"" This reverts commit 722eafe10cfb14fcc7aae8a620fcc020e46139cb. * Adding new APIs for VM extension * adding agent version * adding suppression for secrets * supressing api key * corrected api version * fixed typo * updating the summary * updating description * resolving warnings * Update logz.json

Anil Ingle and others added 20 commits July 27, 2018 14:53

Add PublicIpPrefix

4769c53

Add PublicIpPrefix

72c7442

Add PublicIpPrefix

a8295b3

Move to 2018-07-01 branch

7792309

revertversionchange

c8d437b

Fix Syntax error

e951857

Fix IpTag description because evidently everything is global

37568d3

Fix $ref for PublicIpPrefix

bab987d

Fix Casing

37bd243

Add Exception for PublicIPPrefix from RequiredPropertiesMissingInReso…

03908b1

…urceModel

Merge branch 'Network-August-Release' into publicipprefixaugust

996a9be

Fix Version#

3c8b51d

Merge branch 'publicipprefixaugust' of https://github.com/anilingle-m…

bb8115c

…s/azure-rest-api-specs into publicipprefixaugust

Merge branch 'Network-August-Release' into publicipprefixaugust

36933bb

Fix Examples

0fe47bf

Merge branch 'publicipprefixaugust' of https://github.com/anilingle-m…

a340246

…s/azure-rest-api-specs into publicipprefixaugust

Remove IdleTimeout parameter

28b81e3

Merge branch 'Network-August-Release' into publicipprefixaugust

371cc27

Fix comma

6282692

Add PublicIpPrefix for PublicIpAddressConfiguration

c93cfc6

anilingle-ms requested a review from MikhailTryakhov as a code owner August 9, 2018 19:42

azuresdkci assigned lmazuel Aug 9, 2018

azuresdkci requested a review from lmazuel August 9, 2018 19:42

Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

3e97a2e

AutorestCI mentioned this pull request Aug 9, 2018

[AutoPR network/resource-manager/compute/resource-manager] Publicipprefixaugust Azure/azure-sdk-for-ruby#1557

Merged

AutorestCI mentioned this pull request Aug 9, 2018

[AutoPR compute/resource-manager/network/resource-manager] Publicipprefixaugust Azure/azure-sdk-for-node#3321

Merged

AutorestCI mentioned this pull request Aug 9, 2018

[AutoPR network/resource-manager/compute/resource-manager] Publicipprefixaugust Azure/azure-sdk-for-java#2313

Merged

lmazuel requested changes Aug 9, 2018

View reviewed changes

Fix Comma

4afe679

This was referenced Aug 9, 2018

[AutoPR network/resource-manager/compute/resource-manager] Publicipprefixaugust Azure/azure-sdk-for-python#3122

Merged

[AutoPR compute/resource-manager/network/resource-manager] Publicipprefixaugust Azure/azure-sdk-for-go#2437

Merged

lmazuel approved these changes Aug 10, 2018

View reviewed changes

lmazuel reviewed Aug 10, 2018

View reviewed changes

lmazuel requested changes Aug 10, 2018

View reviewed changes

Remove compute update

1f74b5f

lmazuel approved these changes Aug 10, 2018

View reviewed changes

lmazuel merged commit 37a0eec into Azure:Network-August-Release Aug 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publicipprefixaugust #3618

Publicipprefixaugust #3618

anilingle-ms commented Aug 9, 2018

azuresdkci commented Aug 9, 2018

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

lmazuel left a comment

lmazuel Aug 9, 2018

anilingle-ms Aug 10, 2018

lmazuel Aug 10, 2018

anilingle-ms Aug 10, 2018 •

edited

Loading

anilingle-ms Aug 10, 2018

lmazuel left a comment

lmazuel left a comment

Publicipprefixaugust #3618

Publicipprefixaugust #3618

Conversation

anilingle-ms commented Aug 9, 2018

PR information

Quality of Swagger

azuresdkci commented Aug 9, 2018

AutorestCI commented Aug 9, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 9, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 9, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 9, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 9, 2018 • edited Loading

Automation for azure-sdk-for-java

lmazuel left a comment

Choose a reason for hiding this comment

lmazuel Aug 9, 2018

Choose a reason for hiding this comment

anilingle-ms Aug 10, 2018

Choose a reason for hiding this comment

lmazuel Aug 10, 2018

Choose a reason for hiding this comment

anilingle-ms Aug 10, 2018 • edited Loading

Choose a reason for hiding this comment

anilingle-ms Aug 10, 2018

Choose a reason for hiding this comment

lmazuel left a comment

Choose a reason for hiding this comment

lmazuel left a comment

Choose a reason for hiding this comment

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

AutorestCI commented Aug 9, 2018 •

edited

Loading

anilingle-ms Aug 10, 2018 •

edited

Loading