-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetricAlert swagger fix #3602
MetricAlert swagger fix #3602
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Can one of the admins verify this patch? |
@jhendrixMSFT waiting for the owner team sign-off. |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
@hovsepm are we still waiting on the owner to review? |
@jhendrixMSFT yes we do. They are kind of slow. |
@hovsepm Any update? Do we need to tag somebody for the review? |
@jhendrixMSFT I sent them couple of emails already. Please reassign it to me if you are ok with the changes (I was aware about breaking change issue that is why am waiting for the owner team to take actions). |
@hovsepm The changes LGTM, but yeah I'll reassign to you since you're working with the owning team. |
Closing due to 0 response from owner team. |
Since enum types were not declared as type=string generation on C# and Java side (checked in Fluent code) was producing object types instead of Enums or ExpandableStringEnum.