New credential api #3532
New credential api #3532
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
| "tags": [ | ||
| "ManagedClusters" | ||
| ], | ||
| "operationId": "ManagedClusters_list_clusteradmin_credential", |
There was a problem hiding this comment.
Could you rename this to "ManagedClusters_ListClusterAdminCredential"? That seems to be the convention in swagger here.
There was a problem hiding this comment.
From the CredentialResults return value, it appears there could be multiple name+value credential pairs returned for a clusteradmin. Is that correct? If so, let's name this "ManagedClusters_ListClusterAdminCredentials".
There was a problem hiding this comment.
yes, it could be multiple pairs. I will rename it to "ManagedClusters_ListClusterAdminCredentials".
| "tags": [ | ||
| "ManagedClusters" | ||
| ], | ||
| "operationId": "ManagedClusters_list_clusteruser_credential", |
There was a problem hiding this comment.
As above, this should be "ManagedClusters_ListClusterUserCredentials".
| "$ref": "#/definitions/CredentialResult" | ||
| } | ||
| }, | ||
| "description": "The list of credential result." |
There was a problem hiding this comment.
This line doesn't pass when I run autorest, as if it's not expecting "description" there:
$ autorest $HOME/Projects/azure-rest-api-specs/specification/containerservices/resource-manager/readme.md --azure-validator
AutoRest code generation utility [version: 2.0.4283; node: v8.9.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/Users/matt/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
Loading AutoRest extension '@microsoft.azure/classic-openapi-validator' (~1.0.9->1.0.13)
Loading AutoRest extension '@microsoft.azure/openapi-validator' (~1.0.2->1.0.4)
ERROR: Schema violation: Expected type object but found type string
- file:///Users/matt/Projects/azure-rest-api-specs/specification/containerservices/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json:1414:8 ($.definitions.CredentialResults.properties.description)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger