-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] remove unsupported properties from managed cluster agent pool #3487
Conversation
This was mistakenly copied from ContainerServiceAgentPoolProfile, but is not supported by AKS.
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
@@ -876,15 +876,6 @@ | |||
"type": "string", | |||
"description": "FDQN for the agent pool." | |||
}, | |||
"ports": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mboersma the agentpool profile is defined at https://github.com/Azure/acs-engine/blob/master/pkg/api/agentPoolOnlyApi/v20170831/types.go#L139
It doesn't have dnsPrefix, fqdn, and storageProfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, regex on ContainerServiceNetworkProfile.podCidr
may need to allow empty string.
@JunSun17 to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we should allow empty string for podCidr. It should be ok as it is for now.
@sarangan12 Can you help to review this PR? |
These fields were mistakenly copied from
ContainerServiceAgentPoolProfile
and was never supported by AKS.storageProfile
is supported but only accepts "ManagedDisks" (the default if empty), so making it read-only is a compromise between retaining a property that is in the data model and preventing user confusion.PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger