Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] remove unsupported properties from managed cluster agent pool #3487

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jul 24, 2018

These fields were mistakenly copied from ContainerServiceAgentPoolProfile and was never supported by AKS. storageProfile is supported but only accepts "ManagedDisks" (the default if empty), so making it read-only is a compromise between retaining a property that is in the data model and preventing user confusion.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

This was mistakenly copied from ContainerServiceAgentPoolProfile,
but is not supported by AKS.
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2954

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2342

@@ -876,15 +876,6 @@
"type": "string",
"description": "FDQN for the agent pool."
},
"ports": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboersma the agentpool profile is defined at https://github.com/Azure/acs-engine/blob/master/pkg/api/agentPoolOnlyApi/v20170831/types.go#L139
It doesn't have dnsPrefix, fqdn, and storageProfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, regex on ContainerServiceNetworkProfile.podCidr may need to allow empty string.
@JunSun17 to confirm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should allow empty string for podCidr. It should be ok as it is for now.

@mboersma mboersma changed the title [AKS] remove "ports" property from managed cluster agent pool [AKS] remove unsupported properties from managed cluster agent pool Jul 26, 2018
@zqingqing1
Copy link
Member

@sarangan12 Can you help to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants