Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlertsManagement RP Public preview Swagger Spec #3431

Merged
merged 1 commit into from
Jul 18, 2018
Merged

AlertsManagement RP Public preview Swagger Spec #3431

merged 1 commit into from
Jul 18, 2018

Conversation

vikram-m
Copy link
Contributor

@vikram-m vikram-m commented Jul 17, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from annatisch July 17, 2018 17:38
@AutorestCI AutorestCI mentioned this pull request Jul 17, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 17, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2949

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@vikram-m
Copy link
Contributor Author

Already reviewed - Reference PR : https://github.com/Azure/azure-rest-api-specs-pr/pull/502

@AutorestCI AutorestCI mentioned this pull request Jul 17, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 17, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@annatisch annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2018
@annatisch
Copy link
Member

Adding @ravbhatnagar for ARM feedback.

@sergey-shandar
Copy link
Contributor

@annatisch they've already received ARM approval and my approval.

@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2018
@sergey-shandar sergey-shandar merged commit 31bbba8 into Azure:master Jul 18, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jul 18, 2018
Merged
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@annatisch annatisch Awaiting requested review from annatisch

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vikram-m @AutorestCI @annatisch @sergey-shandar @jhendrixMSFT