From 8ba71eca64dba00081dd885bb10909588fbaf903 Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sat, 23 Jun 2018 18:56:36 +0530 Subject: [PATCH 01/24] Association resource and example --- ...ateGuestDiagnosticSettingsAssociation.json | 42 ++ ...uestDiagnosticSettingsAssociation_API.json | 374 ++++++++++++++++++ 2 files changed, 416 insertions(+) create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json new file mode 100644 index 000000000000..50855ac660aa --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json @@ -0,0 +1,42 @@ +{ + "parameters": { + "resourceUri":"/subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI", + "diagnosticSettingsAssociationName": "SampleAssociationName", + "api-version": "2018-06-01-preview", + "diagnosticSettingsAssociation": { + "location": "Global", + "tags": {}, + "properties": { + "guestDiagnosticSettingsId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + } + } + }, + "responses": { + "200": { + "headers": {}, + "body": { + "id": "/subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", + "name": "SampleAssociationName", + "location": "Global", + "tags": {}, + "properties": { + "guestDiagnosticSettingsId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + } + } + }, + "201": { + "headers": {}, + "body": { + "id": "/subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", + "name": "SampleAssociationName", + "location": "Global", + "tags": {}, + "properties": { + "guestDiagnosticSettingsId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + } + } + } + } +} \ No newline at end of file diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json new file mode 100644 index 000000000000..53ad294db8f6 --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -0,0 +1,374 @@ +{ + "swagger": "2.0", + "info": { + "title": "Guest Diagnostic Settings Association API", + "description": "API to Add/Remove/List Guest Diagnostics Settings Association for Azure Resources", + "x-ms-code-generation-settings": { + "name": "MonitorManagementClient" + }, + "version": "2018-06-01-preview" + }, + "host": "management.azure.com", + "schemes": [ + "https" + ], + "consumes": [ + "application/json" + ], + "produces": [ + "application/json" + ], + "security": [ + { + "azure_auth": [ + "user_impersonation" + ] + } + ], + "securityDefinitions": { + "azure_auth": { + "type": "oauth2", + "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", + "flow": "implicit", + "description": "Azure Active Directory OAuth2 Flow", + "scopes": { + "user_impersonation": "impersonate your user account" + } + } + }, + "paths": { + "/{resourceUri}/providers/microsoft.insights/guestDiagnosticSettingsAssociation/{associationName}": { + "put": { + "description": "Creates or updates guest diagnostics settings association.", + "tags": [ + "GuestDiagnosticsSettingsAssociation" + ], + "operationId": "guestDiagnosticsSettingsAssociation_CreateOrUpdate", + "x-ms-examples": { + "Create or update an guest diagnostic settings association": { + "$ref": "./examples/createOrUpdateGuestDiagnosticSettingsAssociation" + } + }, + "parameters": [ + { + "name": "resourceUri", + "in": "path", + "required": true, + "type": "string", + "description": "The fully qualified ID of the resource, including the resource name and resource type.", + "x-ms-skip-url-encoding": true + }, + { + "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "name": "diagnosticSettingsAssociation", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + }, + "description": "The diagnostic settings association to create or update." + } + ], + "responses": { + "200": { + "description": "An existing guest diagnostic settings association was successfully updated.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + } + }, + "201": { + "description": "A new guest diagnostic settings association was successfully created.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + } + }, + "default": { + "description": "An error occurred and the guest diagnostic settings association could not be created or updated.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + }, + "get": { + "description": "Gets guest diagnostics association settings.", + "tags": [ + "GuestDiagnosticsSettingsAssociation" + ], + "operationId": "guestDiagnosticsSettingsAssociation_Get", + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The request succeeded.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + } + }, + "404": { + "description": "The diagnostic settings association does not exist.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + } + }, + "default": { + "description": "An error occurred and the diagnostic settings association could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + }, + "delete": { + "description": "Delete guest diagnostics association settings.", + "tags": [ + "GuestDiagnosticsSettingsAssociation" + ], + "operationId": "GuestDiagnosticsSettingsAssociation_Delete", + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The diagnostic settings association was successfully deleted." + }, + "204": { + "description": "The diagnostic settings association does not exist. It may have already been deleted." + }, + "default": { + "description": "An error occurred and the diagnostic settings association could not be deleted.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + } + }, + "/subscriptions/{subscriptionId}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { + "get": { + "description": "Get a list of all guest diagnostic settings association in a subscription.", + "operationId": "guestDiagnosticsSettingsAssociation_ListBySubscriptionId", + "x-ms-pageable": { + "nextLinkName": null + }, + "parameters": [ + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The request succeeded.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationList" + } + }, + "default": { + "description": "An error occurred and the list of guest diagnostic settings association could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { + "get": { + "description": "Get a list of all guest diagnostic settings association in a resource group.", + "operationId": "guestDiagnosticsSettingsAssociation_ListByResourceGroup", + "x-ms-pageable": { + "nextLinkName": null + }, + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The request succeeded.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationList" + } + }, + "default": { + "description": "An error occurred and the list of guest diagnostic settings association could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + } + } + }, + "definitions": { + "ErrorResponse": { + "description": "Describes the format of Error response.", + "type": "object", + "properties": { + "code": { + "description": "Error code", + "type": "string" + }, + "message": { + "description": "Error message indicating why the operation failed.", + "type": "string" + } + } + }, + "GuestDiagnosticSettingsAssociationList": { + "description": "A list of guest diagnostic settings association.", + "properties": { + "value": { + "type": "array", + "items": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + }, + "description": "The list of guest diagnostic settings association." + }, + "nextLink": { + "type": "string", + "description": "Provides the link to retrieve the next set of elements." + } + } + }, + "GuestDiagnosticSettingsAssociation": { + "description": "A guest diagnostic settings association.", + "properties": { + "guestDiagnosticSettingsId": { + "type": "string", + "description": "The guest diagnostic settings name." + } + }, + "required": [ + "guestDiagnosticSettingsName" + ] + }, + "GuestDiagnosticSettingsAssociationResource": { + "type": "object", + "allOf": [ + { + "$ref": "#/definitions/Resource" + } + ], + "required": [ + "properties" + ], + "properties": { + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/GuestDiagnosticSettingsAssociation", + "description": "The diagnostics settings associations of the resource." + } + }, + "description": "Virtual machine guest diagnostic settings resource." + }, + "Resource": { + "properties": { + "id": { + "type": "string", + "readOnly": true, + "description": "Azure resource Id" + }, + "name": { + "type": "string", + "readOnly": true, + "description": "Azure resource name" + }, + "type": { + "type": "string", + "readOnly": true, + "description": "Azure resource type" + }, + "location": { + "type": "string", + "description": "Resource location", + "x-ms-mutability": [ + "create", + "read" + ] + }, + "tags": { + "additionalProperties": { + "type": "string" + }, + "description": "Resource tags" + } + }, + "required": [ + "location" + ], + "x-ms-azure-resource": true, + "description": "An azure resource object" + } + }, + "parameters": { + "SubscriptionIdParameter": { + "name": "subscriptionId", + "in": "path", + "required": true, + "type": "string", + "description": "The Azure subscription Id." + }, + "ResourceGroupNameParameter": { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group.", + "x-ms-parameter-location": "method" + }, + "DiagnosticSettingsAssociationNameParameter": { + "name": "diagnosticSettingsAssociationName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the diagnostic settings association.", + "x-ms-parameter-location": "method" + }, + "ApiVersionParameter": { + "name": "api-version", + "in": "query", + "required": true, + "type": "string", + "description": "Client Api Version." + } + } + } \ No newline at end of file From f229b35ac46f0155e76b174b6bc75b3d2fa7fc73 Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sat, 23 Jun 2018 23:05:31 +0530 Subject: [PATCH 02/24] Guest diagnostic setting --- ...createOrUpdateGuestDiagnosticSettings.json | 241 ++++++++ .../examples/getGuestDiagnosticSettings.json | 168 ++++++ .../guestDiagnosticSettings_API.json | 529 ++++++++++++++++++ 3 files changed, 938 insertions(+) create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json new file mode 100644 index 000000000000..abc21d66d191 --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json @@ -0,0 +1,241 @@ +{ + "parameters": { + "subscriptionId": "187f412d-1758-44d9-b052-169e2564721d", + "resourceGroupName": "Default-ResourceGroup", + "diagnosticSettingsName": "SampleDiagSetting", + "api-version": "2018-06-01-preview", + "diagnosticSettings": { + "location": "Global", + "tags": {}, + "properties": { + "osType": "windows", + "dataSources": [ + { + "kind": "PerformanceCounter", + "configuration": { + "perfCounters": [ + { + "name": "\\Process(_Total)\\%Processor Time", + "samplingPeriod": "PT1M" + }, + { + "name": "\\Process(_Total)\\Working Set", + "samplingPeriod": "PT1M" + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "ETWProviders", + "configuration": { + "providers": [ + { + "name": "AuditLog", + "id": 1, + "filter": "filter exp" + }, + { + "name": "TraceLog", + "id": 2 + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "WindowsEventLogs", + "configuration": { + "eventLogs": [ + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" + + }, + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" + } + + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + } + + ] + } + } + }, + "responses": { + "200": { + "headers": {}, + "body": { + "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", + "name": "SampleDiagSetting", + "type": "Microsoft.Insights/guestDiagnosticSettings", + "location": "West US", + "tags": {}, + "properties": { + "osType": "windows", + "dataSources": [ + { + "kind": "PerformanceCounter", + "configuration": { + "perfCounters": [ + { + "name": "\\Process(_Total)\\%Processor Time", + "samplingPeriod": "PT1M" + }, + { + "name": "\\Process(_Total)\\Working Set", + "samplingPeriod": "PT1M" + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "ETWProviders", + "configuration": { + "providers": [ + { + "name": "AuditLog", + "id": 1, + "filter": "filter exp" + }, + { + "name": "TraceLog", + "id": 2 + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "WindowsEventLogs", + "configuration": { + "eventLogs": [ + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" + + }, + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" + } + + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + } + + ] + } + } + }, + "202": { + "headers": {}, + "body": { + "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", + "name": "SampleDiagSetting", + "type": "Microsoft.Insights/guestDiagnosticSettings", + "location": "West US", + "tags": {}, + "properties": { + "osType": "windows", + "dataSources": [ + { + "kind": "PerformanceCounter", + "configuration": { + "perfCounters": [ + { + "name": "\\Process(_Total)\\%Processor Time", + "samplingPeriod": "PT1M" + }, + { + "name": "\\Process(_Total)\\Working Set", + "samplingPeriod": "PT1M" + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "ETWProviders", + "configuration": { + "providers": [ + { + "name": "AuditLog", + "id": 1, + "filter": "filter exp" + }, + { + "name": "TraceLog", + "id": 2 + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "WindowsEventLogs", + "configuration": { + "eventLogs": [ + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" + + }, + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" + } + + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + } + + ] + } + } + } + } +} \ No newline at end of file diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json new file mode 100644 index 000000000000..a8b80f146ab0 --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json @@ -0,0 +1,168 @@ +{ + "parameters": { + "subscriptionId": "187f412d-1758-44d9-b052-169e2564721d", + "resourceGroupName": "Default-ResourceGroup", + "diagnosticSettingsName": "SampleDiagSetting", + "api-version": "2018-06-01-preview" + }, + "responses": { + "200": { + "headers": {}, + "body": { + "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", + "name": "SampleDiagSetting", + "type": "Microsoft.Insights/guestDiagnosticSettings", + "location": "West US", + "tags": {}, + "properties": { + "osType": "windows", + "dataSources": [ + { + "kind": "PerformanceCounter", + "configuration": { + "perfCounters": [ + { + "name": "\\Process(_Total)\\%Processor Time", + "samplingPeriod": "PT1M" + }, + { + "name": "\\Process(_Total)\\Working Set", + "samplingPeriod": "PT1M" + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "ETWProviders", + "configuration": { + "providers": [ + { + "name": "AuditLog", + "id": 1, + "filter": "filter exp" + }, + { + "name": "TraceLog", + "id": 2 + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "WindowsEventLogs", + "configuration": { + "eventLogs": [ + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" + + }, + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" + } + + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + } + + ] + } + } + }, + "202": { + "headers": {}, + "body": { + "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", + "name": "SampleDiagSetting", + "type": "Microsoft.Insights/guestDiagnosticSettings", + "location": "West US", + "tags": {}, + "properties": { + "osType": "windows", + "dataSources": [ + { + "kind": "PerformanceCounter", + "configuration": { + "perfCounters": [ + { + "name": "\\Process(_Total)\\%Processor Time", + "samplingPeriod": "PT1M" + }, + { + "name": "\\Process(_Total)\\Working Set", + "samplingPeriod": "PT1M" + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "ETWProviders", + "configuration": { + "providers": [ + { + "name": "AuditLog", + "id": 1, + "filter": "filter exp" + }, + { + "name": "TraceLog", + "id": 2 + } + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + }, + { + "kind": "WindowsEventLogs", + "configuration": { + "eventLogs": [ + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" + + }, + { + "logName": "Application", + "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" + } + + ] + }, + "sinks": [ + { + "kind": "LogAnalytics" + } + ] + } + + ] + } + } + } + } +} \ No newline at end of file diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json new file mode 100644 index 000000000000..2f9b2d5f6b5a --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -0,0 +1,529 @@ +{ + "swagger": "2.0", + "info": { + "title": "Guest Diagnostic Settings API", + "description": "API to Add/Remove/List Guest Diagnostics Configuration to Azure Resources", + "x-ms-code-generation-settings": { + "name": "MonitorManagementClient" + }, + "version": "2018-06-01-preview" + }, + "host": "management.azure.com", + "schemes": [ + "https" + ], + "consumes": [ + "application/json" + ], + "produces": [ + "application/json" + ], + "security": [ + { + "azure_auth": [ + "user_impersonation" + ] + } + ], + "securityDefinitions": { + "azure_auth": { + "type": "oauth2", + "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", + "flow": "implicit", + "description": "Azure Active Directory OAuth2 Flow", + "scopes": { + "user_impersonation": "impersonate your user account" + } + } + }, + "paths": { + "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings/{settingName}": { + "put": { + "description": "Creates or updates guest diagnostics settings.", + "tags": [ + "GuestDiagnosticsSettings" + ], + "operationId": "guestDiagnosticsSettings_CreateOrUpdate", + "x-ms-examples": { + "Create or update a guest diagnostic settings": { + "$ref": "./examples/createOrUpdateGuestDiagnosticSettings.json" + } + }, + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/DiagnosticSettingNameParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "name": "diagnosticSettings", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + }, + "description": "The configuration to create or update." + } + ], + "responses": { + "200": { + "description": "An existing guest diagnostic settings was successfully updated.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + } + }, + "201": { + "description": "A new guest diagnostic settings was successfully created.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + } + }, + "default": { + "description": "An error occurred and the guest diagnostic settings could not be created or updated.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + }, + "get": { + "description": "Gets guest diagnostics settings.", + "tags": [ + "GuestDiagnosticsSettings" + ], + "operationId": "guestDiagnosticsSettings_Get", + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/DiagnosticSettingNameParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The request succeeded.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + } + }, + "404": { + "description": "The diagnostic settings does not exist.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + } + }, + "default": { + "description": "An error occurred and the diagnostic settings could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + }, + "delete": { + "description": "Delete guest diagnostics settings.", + "tags": [ + "GuestDiagnosticsSettings" + ], + "operationId": "guestDiagnosticsSettings_Delete", + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/DiagnosticSettingNameParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The diagnostic settings was successfully deleted." + }, + "204": { + "description": "The diagnostic settings does not exist. It may have already been deleted." + }, + "default": { + "description": "An error occurred and the diagnostic settings could not be deleted.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + } + }, + "/subscriptions/{subscriptionId}/providers/microsoft.insights/guestDiagnosticSettings": { + "get": { + "description": "Get a list of all guest diagnostic settings in a subscription.", + "operationId": "guestDiagnosticsSettings_ListBySubscriptionId", + "x-ms-pageable": { + "nextLinkName": null + }, + "parameters": [ + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The request succeeded.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsList" + } + }, + "default": { + "description": "An error occurred and the list of guest diagnostic settings could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings": { + "get": { + "description": "Get a list of all guest diagnostic settings in a resource group.", + "operationId": "guestDiagnosticsSettings_ListByResourceGroup", + "x-ms-pageable": { + "nextLinkName": null + }, + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + } + ], + "responses": { + "200": { + "description": "The request succeeded.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsList" + } + }, + "default": { + "description": "An error occurred and the list of guest diagnostic settings could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + } + } + }, + "definitions": { + "ErrorResponse": { + "description": "Describes the format of Error response.", + "type": "object", + "properties": { + "code": { + "description": "Error code", + "type": "string" + }, + "message": { + "description": "Error message indicating why the operation failed.", + "type": "string" + } + } + }, + "GuestDiagnosticSettingsList": { + "description": "A list of guest diagnostic settings.", + "properties": { + "value": { + "type": "array", + "items": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + }, + "description": "The list of guest diagnostic settings." + }, + "nextLink": { + "type": "string", + "description": "Provides the link to retrieve the next set of elements." + } + } + }, + "GuestDiagnosticSettingsResource": { + "type": "object", + "allOf": [ + { + "$ref": "#/definitions/Resource" + } + ], + "required": [ + "properties" + ], + "properties": { + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/DiagnosticSettings", + "description": "The diagnostic settings to be applied to azure resources." + } + }, + "description": "Virtual machine guest diagnostics settings resource." + }, + "DiagnosticSettings": { + "description": "Virtual machine diagnostic settings", + "properties": { + "osType": { + "type": "string", + "enum": [ + "windows", + "linux" + ], + "description" : "Operating system type for the configuration" + }, + "dataSources": { + "type": "array", + "items": { + "$ref": "#/definitions/DataSource" + }, + "description": "the array of data source object which are configured to collect and send data" + }, + "proxySetting": { + "type": "string" + } + } + }, + "DataSource": { + "type": "object", + "required": [ + "kind", + "configuration", + "sinks" + ], + "properties": { + "kind": { + "type": "string", + "enum": [ + "PerformanceCounter", + "ETWProviders", + "WindowsEventLogs" + ], + "description": "Datasource kind" + }, + "configuration": { + "type": "object", + "$ref": "#/definitions/DataSourceConfiguration" + }, + "sinks": { + "type": "array", + "items": { + "$ref": "#/definitions/SinkConfiguration" + } + } + }, + "description": "Data source object contains configuration to collect telemetry and one or more sinks to send that telemetry data to" + }, + "SinkConfiguration": { + "type": "object", + "required": "type", + "properties": { + "kind": { + "type": "string", + "enum": [ + "EventHub", + "ApplicationInsights", + "LogAnalytics" + ] + } + } + }, + "DataSourceConfiguration": { + "type": "object", + "properties": { + "oneOf": [ + { + "providers": { + "type": "array", + "items": { + "$ref": "#/definitions/EtwProviderConfiguration" + }, + "description": "ETW providers configuration" + } + }, + { + "perfCounters": { + "type": "array", + "items": { + "$ref": "#/definitions/PerformanceCounterConfiguration" + }, + "description": "Performance counter configuration" + } + }, + { + "eventLogs": { + "type": "array", + "items": { + "$ref": "#/definitions/EventLogConfiguration" + }, + "description": "Windows event logs configuration." + } + } + ] + } + }, + "EtwEventConfiguration": { + "type": "object", + "required": [ + "name", + "id" + ], + "properties": { + "name": { + "type": "string" + }, + "id": { + "type": "integer" + }, + "filter": { + "type": "string" + } + } + }, + "EtwProviderConfiguration": { + "type": "object", + "required": [ + "id", + "events" + ], + "properties": { + "id": { + "type": "string" + }, + "events": { + "type": "array", + "items": { + "$ref": "#/definitions/EtwEventConfiguration" + } + } + } + }, + "PerformanceCounterConfiguration": { + "type": "object", + "required": [ + "name", + "samplingPeriod" + ], + "properties": { + "name": { + "type": "string" + }, + "samplingPeriod": { + "type": "string" + }, + "instance": { + "type": "string" + } + } + }, + "EventLogConfiguration": { + "type": "object", + "required": [ + "logName" + ], + "properties": { + "logName": { + "type": "string" + }, + "filter": { + "type": "string" + } + } + }, + "Resource": { + "properties": { + "id": { + "type": "string", + "readOnly": true, + "description": "Azure resource Id" + }, + "name": { + "type": "string", + "readOnly": true, + "description": "Azure resource name" + }, + "type": { + "type": "string", + "readOnly": true, + "description": "Azure resource type" + }, + "location": { + "type": "string", + "description": "Resource location", + "x-ms-mutability": [ + "create", + "read" + ] + }, + "tags": { + "additionalProperties": { + "type": "string" + }, + "description": "Resource tags" + } + }, + "required": [ + "location" + ], + "x-ms-azure-resource": true, + "description": "An azure resource object" + } + }, + "parameters": { + "SubscriptionIdParameter": { + "name": "subscriptionId", + "in": "path", + "required": true, + "type": "string", + "description": "The Azure subscription Id." + }, + "ResourceGroupNameParameter": { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group.", + "x-ms-parameter-location": "method" + }, + "DiagnosticSettingNameParameter": { + "name": "diagnosticSettingsName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the diagnostic setting.", + "x-ms-parameter-location": "method" + }, + "ApiVersionParameter": { + "name": "api-version", + "in": "query", + "required": true, + "type": "string", + "description": "Client Api Version." + } + } + } \ No newline at end of file From a0ee6668a430e04d5231a1f50752287f6e0c7f53 Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sat, 23 Jun 2018 23:52:38 +0530 Subject: [PATCH 03/24] Fixing Travis CI Failure --- .../guestDiagnosticSettingsAssociation_API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 53ad294db8f6..8a283ca50b54 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -46,7 +46,7 @@ "operationId": "guestDiagnosticsSettingsAssociation_CreateOrUpdate", "x-ms-examples": { "Create or update an guest diagnostic settings association": { - "$ref": "./examples/createOrUpdateGuestDiagnosticSettingsAssociation" + "$ref": "./examples/createOrUpdateGuestDiagnosticSettingsAssociation.json" } }, "parameters": [ From 90b000df8e3d1cf1ce5ca95e15153669462cf06c Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sun, 24 Jun 2018 00:35:42 +0530 Subject: [PATCH 04/24] Fixing travis build --- .../guestDiagnosticSettingsAssociation_API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 8a283ca50b54..5a243dae03b6 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -356,7 +356,7 @@ "x-ms-parameter-location": "method" }, "DiagnosticSettingsAssociationNameParameter": { - "name": "diagnosticSettingsAssociationName", + "name": "associationName", "in": "path", "required": true, "type": "string", From 0734d7ca7fd65117b43c19794fee38d42d9a76fb Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sun, 24 Jun 2018 01:07:18 +0530 Subject: [PATCH 05/24] Travis failures --- ...uestDiagnosticSettingsAssociation_API.json | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 5a243dae03b6..b4268816c370 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -103,14 +103,16 @@ "operationId": "guestDiagnosticsSettingsAssociation_Get", "parameters": [ { - "$ref": "#/parameters/ResourceGroupNameParameter" + "name": "resourceUri", + "in": "path", + "required": true, + "type": "string", + "description": "The fully qualified ID of the resource, including the resource name and resource type.", + "x-ms-skip-url-encoding": true }, { "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" }, - { - "$ref": "#/parameters/SubscriptionIdParameter" - }, { "$ref": "#/parameters/ApiVersionParameter" } @@ -144,14 +146,16 @@ "operationId": "GuestDiagnosticsSettingsAssociation_Delete", "parameters": [ { - "$ref": "#/parameters/ResourceGroupNameParameter" + "name": "resourceUri", + "in": "path", + "required": true, + "type": "string", + "description": "The fully qualified ID of the resource, including the resource name and resource type.", + "x-ms-skip-url-encoding": true }, { "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" }, - { - "$ref": "#/parameters/SubscriptionIdParameter" - }, { "$ref": "#/parameters/ApiVersionParameter" } @@ -272,7 +276,7 @@ "GuestDiagnosticSettingsAssociation": { "description": "A guest diagnostic settings association.", "properties": { - "guestDiagnosticSettingsId": { + "guestDiagnosticSettingsName": { "type": "string", "description": "The guest diagnostic settings name." } From 65246017ca51e3d4eace4c77b55bfc95dce4a63d Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sun, 24 Jun 2018 01:45:58 +0530 Subject: [PATCH 06/24] Travis failures --- .../guestDiagnosticSettings_API.json | 52 ++++++++----------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json index 2f9b2d5f6b5a..af8674dfc086 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -37,7 +37,7 @@ } }, "paths": { - "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings/{settingName}": { + "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings/{diagnosticSettingsName}": { "put": { "description": "Creates or updates guest diagnostics settings.", "tags": [ @@ -341,7 +341,9 @@ }, "SinkConfiguration": { "type": "object", - "required": "type", + "required": [ + "type" + ], "properties": { "kind": { "type": "string", @@ -356,35 +358,27 @@ "DataSourceConfiguration": { "type": "object", "properties": { - "oneOf": [ - { - "providers": { - "type": "array", - "items": { - "$ref": "#/definitions/EtwProviderConfiguration" - }, - "description": "ETW providers configuration" - } + "providers": { + "type": "array", + "items": { + "$ref": "#/definitions/EtwProviderConfiguration" }, - { - "perfCounters": { - "type": "array", - "items": { - "$ref": "#/definitions/PerformanceCounterConfiguration" - }, - "description": "Performance counter configuration" - } + "description": "ETW providers configuration" + }, + "perfCounters": { + "type": "array", + "items": { + "$ref": "#/definitions/PerformanceCounterConfiguration" }, - { - "eventLogs": { - "type": "array", - "items": { - "$ref": "#/definitions/EventLogConfiguration" - }, - "description": "Windows event logs configuration." - } - } - ] + "description": "Performance counter configuration" + }, + "eventLogs": { + "type": "array", + "items": { + "$ref": "#/definitions/EventLogConfiguration" + }, + "description": "Windows event logs configuration." + } } }, "EtwEventConfiguration": { From b1f3c4f923df5328ce0f952c2387f00dbc908484 Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Sun, 24 Jun 2018 15:20:00 +0530 Subject: [PATCH 07/24] Travis failures --- .../preview/2018-06-01-preview/guestDiagnosticSettings_API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json index af8674dfc086..30354741e14e 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -342,7 +342,7 @@ "SinkConfiguration": { "type": "object", "required": [ - "type" + "kind" ], "properties": { "kind": { From af6c1168b7bdb2385bde93bfce7ba4adb55e1ccd Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Tue, 26 Jun 2018 13:54:37 +0530 Subject: [PATCH 08/24] Travis failures --- .../examples/createOrUpdateGuestDiagnosticSettings.json | 2 +- .../createOrUpdateGuestDiagnosticSettingsAssociation.json | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json index abc21d66d191..57f1311a1dbb 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json @@ -158,7 +158,7 @@ } } }, - "202": { + "201": { "headers": {}, "body": { "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json index 50855ac660aa..73fd24991ed7 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json @@ -1,13 +1,13 @@ { "parameters": { - "resourceUri":"/subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI", + "resourceUri":"subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI", "diagnosticSettingsAssociationName": "SampleAssociationName", "api-version": "2018-06-01-preview", "diagnosticSettingsAssociation": { "location": "Global", "tags": {}, "properties": { - "guestDiagnosticSettingsId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" } } }, @@ -21,7 +21,7 @@ "location": "Global", "tags": {}, "properties": { - "guestDiagnosticSettingsId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" } } }, @@ -34,7 +34,7 @@ "location": "Global", "tags": {}, "properties": { - "guestDiagnosticSettingsId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" } } } From d09b424e9cb9cfd90d30319423cfe362a4e0ce60 Mon Sep 17 00:00:00 2001 From: sankalpsoni Date: Wed, 27 Jun 2018 12:24:50 +0530 Subject: [PATCH 09/24] Travis failures --- .../createOrUpdateGuestDiagnosticSettingsAssociation.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json index 73fd24991ed7..53f26c409781 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json @@ -1,7 +1,7 @@ { "parameters": { "resourceUri":"subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI", - "diagnosticSettingsAssociationName": "SampleAssociationName", + "associationName": "SampleAssociationName", "api-version": "2018-06-01-preview", "diagnosticSettingsAssociation": { "location": "Global", From 22eff7435687ef917692740bf80797dc1180d3a2 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Thu, 28 Jun 2018 13:24:47 +0530 Subject: [PATCH 10/24] Review comments --- ...createOrUpdateGuestDiagnosticSettings.json | 4 +- ...ateGuestDiagnosticSettingsAssociation.json | 12 ++-- .../examples/getGuestDiagnosticSettings.json | 10 +-- ...uestDiagnosticSettingsAssociation_API.json | 6 -- .../guestDiagnosticSettings_API.json | 69 +++++++++++++++++-- 5 files changed, 76 insertions(+), 25 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json index 57f1311a1dbb..348e454c8471 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json @@ -8,7 +8,7 @@ "location": "Global", "tags": {}, "properties": { - "osType": "windows", + "osType": "Windows", "dataSources": [ { "kind": "PerformanceCounter", @@ -83,7 +83,7 @@ "headers": {}, "body": { "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", - "name": "SampleDiagSetting", + "name": "productionMachineSetting", "type": "Microsoft.Insights/guestDiagnosticSettings", "location": "West US", "tags": {}, diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json index 53f26c409781..9de11c6437ae 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json @@ -1,7 +1,7 @@ { "parameters": { - "resourceUri":"subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI", - "associationName": "SampleAssociationName", + "resourceUri":"subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai", + "associationName": "healthSystemMachineConfigAssociation", "api-version": "2018-06-01-preview", "diagnosticSettingsAssociation": { "location": "Global", @@ -15,9 +15,9 @@ "200": { "headers": {}, "body": { - "id": "/subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", - "name": "SampleAssociationName", + "name": "healthSystemMachineConfigAssociation", "location": "Global", "tags": {}, "properties": { @@ -28,9 +28,9 @@ "201": { "headers": {}, "body": { - "id": "/subscriptions/4abcdefgh-ijkl-mnop-qrstuvwxyz/resourceGroups/rhctestenv/providers/Microsoft.ClassicCompute/virtualMachines/rhctestenvV1PI/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", - "name": "SampleAssociationName", + "name": "healthSystemMachineConfigAssociation", "location": "Global", "tags": {}, "properties": { diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json index a8b80f146ab0..09a003c11131 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettings.json @@ -2,15 +2,15 @@ "parameters": { "subscriptionId": "187f412d-1758-44d9-b052-169e2564721d", "resourceGroupName": "Default-ResourceGroup", - "diagnosticSettingsName": "SampleDiagSetting", + "diagnosticSettingsName": "productionMachineSetting", "api-version": "2018-06-01-preview" }, "responses": { "200": { "headers": {}, "body": { - "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", - "name": "SampleDiagSetting", + "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/productionMachineSetting", + "name": "productionMachineSetting", "type": "Microsoft.Insights/guestDiagnosticSettings", "location": "West US", "tags": {}, @@ -88,8 +88,8 @@ "202": { "headers": {}, "body": { - "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagSetting", - "name": "SampleDiagSetting", + "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-ResourceGroup/providers/microsoft.insights/guestDiagnosticSettings/productionMachineSetting", + "name": "productionMachineSetting", "type": "Microsoft.Insights/guestDiagnosticSettings", "location": "West US", "tags": {}, diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index b4268816c370..f14e2ddaf16c 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -124,12 +124,6 @@ "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" } }, - "404": { - "description": "The diagnostic settings association does not exist.", - "schema": { - "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" - } - }, "default": { "description": "An error occurred and the diagnostic settings association could not be retrieved.", "schema": { diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json index 30354741e14e..4b3379102a4e 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -120,20 +120,61 @@ "$ref": "#/definitions/GuestDiagnosticSettingsResource" } }, - "404": { - "description": "The diagnostic settings does not exist.", + "default": { + "description": "An error occurred and the diagnostic settings could not be retrieved.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + } + }, + "patch": { + "description": "Updates guest diagnostics settings.", + "operationId": "guestDiagnosticsSettings_Update", + "parameters": [ + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/DiagnosticSettingNameParameter" + }, + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "name": "diagnosticSettingsPatch", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsPatchResource" + }, + "description": "The configuration to patch." + } + ], + "responses": { + "200": { + "description": "An existing guest diagnostic settings was successfully updated.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsResource" + } + }, + "201": { + "description": "A new guest diagnostic settings was successfully created.", "schema": { "$ref": "#/definitions/GuestDiagnosticSettingsResource" } }, "default": { - "description": "An error occurred and the diagnostic settings could not be retrieved.", + "description": "An error occurred and the guest diagnostic settings could not be created or updated.", "schema": { "$ref": "#/definitions/ErrorResponse" } } } - }, + }, "delete": { "description": "Delete guest diagnostics settings.", "tags": [ @@ -292,8 +333,8 @@ "osType": { "type": "string", "enum": [ - "windows", - "linux" + "Windows", + "Linux" ], "description" : "Operating system type for the configuration" }, @@ -309,6 +350,22 @@ } } }, + "GuestDiagnosticSettingsPatchResource": { + "description": "An diagnostic settings object for the body of patch operations.", + "properties": { + "tags": { + "additionalProperties": { + "type": "string" + }, + "description": "Resource tags" + }, + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/DiagnosticSettings", + "description": "The diagnostic settings for an update operation." + } + } + }, "DataSource": { "type": "object", "required": [ From 4ca6bc6b856488e6c4fc009e9ead8a150196b91b Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Thu, 28 Jun 2018 15:23:45 +0530 Subject: [PATCH 11/24] Trying out to fix linter error --- ...createOrUpdateGuestDiagnosticSettings.json | 50 ++----------------- 1 file changed, 3 insertions(+), 47 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json index 348e454c8471..ba72ae7a24f6 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json @@ -88,7 +88,7 @@ "location": "West US", "tags": {}, "properties": { - "osType": "windows", + "osType": "Windows", "dataSources": [ { "kind": "PerformanceCounter", @@ -109,51 +109,7 @@ "kind": "LogAnalytics" } ] - }, - { - "kind": "ETWProviders", - "configuration": { - "providers": [ - { - "name": "AuditLog", - "id": 1, - "filter": "filter exp" - }, - { - "name": "TraceLog", - "id": 2 - } - ] - }, - "sinks": [ - { - "kind": "LogAnalytics" - } - ] - }, - { - "kind": "WindowsEventLogs", - "configuration": { - "eventLogs": [ - { - "logName": "Application", - "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" - - }, - { - "logName": "Application", - "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" - } - - ] - }, - "sinks": [ - { - "kind": "LogAnalytics" - } - ] - } - + } ] } } @@ -167,7 +123,7 @@ "location": "West US", "tags": {}, "properties": { - "osType": "windows", + "osType": "Windows", "dataSources": [ { "kind": "PerformanceCounter", From 411a8a5feae99e52daa64b94c71ae59ef1fe7eb7 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Thu, 28 Jun 2018 15:31:04 +0530 Subject: [PATCH 12/24] Trying out to fix linter error --- ...createOrUpdateGuestDiagnosticSettings.json | 46 +------------------ 1 file changed, 1 insertion(+), 45 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json index ba72ae7a24f6..e57cc6ec6235 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettings.json @@ -144,51 +144,7 @@ "kind": "LogAnalytics" } ] - }, - { - "kind": "ETWProviders", - "configuration": { - "providers": [ - { - "name": "AuditLog", - "id": 1, - "filter": "filter exp" - }, - { - "name": "TraceLog", - "id": 2 - } - ] - }, - "sinks": [ - { - "kind": "LogAnalytics" - } - ] - }, - { - "kind": "WindowsEventLogs", - "configuration": { - "eventLogs": [ - { - "logName": "Application", - "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"CatWoman\"" - - }, - { - "logName": "Application", - "filter": "SourceName == Xyz AND EventId = \"100\" AND $Xpath/Column=\"DCName\" = \"BatMan\"" - } - - ] - }, - "sinks": [ - { - "kind": "LogAnalytics" - } - ] - } - + } ] } } From 794d132182a9f97849d53cd418fbb7eb6bd1314a Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 14:46:17 +0530 Subject: [PATCH 13/24] PR Comments --- .../guestDiagnosticSettingsAssociation_API.json | 4 ++-- .../guestDiagnosticSettings_API.json | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index f14e2ddaf16c..e3d5a44c4707 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -173,7 +173,7 @@ "/subscriptions/{subscriptionId}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { "get": { "description": "Get a list of all guest diagnostic settings association in a subscription.", - "operationId": "guestDiagnosticsSettingsAssociation_ListBySubscriptionId", + "operationId": "guestDiagnosticsSettingsAssociation_List", "x-ms-pageable": { "nextLinkName": null }, @@ -204,7 +204,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { "get": { "description": "Get a list of all guest diagnostic settings association in a resource group.", - "operationId": "guestDiagnosticsSettingsAssociation_ListByResourceGroup", + "operationId": "guestDiagnosticsSettingsAssociation_List", "x-ms-pageable": { "nextLinkName": null }, diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json index 4b3379102a4e..44bc8b4d750c 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -145,7 +145,7 @@ "$ref": "#/parameters/SubscriptionIdParameter" }, { - "name": "diagnosticSettingsPatch", + "name": "parameters", "in": "body", "required": true, "schema": { @@ -214,7 +214,7 @@ "/subscriptions/{subscriptionId}/providers/microsoft.insights/guestDiagnosticSettings": { "get": { "description": "Get a list of all guest diagnostic settings in a subscription.", - "operationId": "guestDiagnosticsSettings_ListBySubscriptionId", + "operationId": "guestDiagnosticsSettings_List", "x-ms-pageable": { "nextLinkName": null }, @@ -245,7 +245,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings": { "get": { "description": "Get a list of all guest diagnostic settings in a resource group.", - "operationId": "guestDiagnosticsSettings_ListByResourceGroup", + "operationId": "guestDiagnosticsSettings_List", "x-ms-pageable": { "nextLinkName": null }, @@ -321,13 +321,13 @@ "properties": { "properties": { "x-ms-client-flatten": true, - "$ref": "#/definitions/DiagnosticSettings", + "$ref": "#/definitions/GuestDiagnosticSettings", "description": "The diagnostic settings to be applied to azure resources." } }, "description": "Virtual machine guest diagnostics settings resource." }, - "DiagnosticSettings": { + "GuestDiagnosticSettings": { "description": "Virtual machine diagnostic settings", "properties": { "osType": { @@ -361,7 +361,7 @@ }, "properties": { "x-ms-client-flatten": true, - "$ref": "#/definitions/DiagnosticSettings", + "$ref": "#/definitions/GuestDiagnosticSettings", "description": "The diagnostic settings for an update operation." } } From ce1133ba970459fc3803b80a250e746db282a6ee Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 15:58:50 +0530 Subject: [PATCH 14/24] Adding more examples --- ...eteGuestDiagnosticSettingsAssociation.json | 17 ++++++++++++++ ...getGuestDiagnosticSettingsAssociation.json | 22 +++++++++++++++++++ .../guestDiagnosticSettings_API.json | 2 +- 3 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/deleteGuestDiagnosticSettingsAssociation.json create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/deleteGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/deleteGuestDiagnosticSettingsAssociation.json new file mode 100644 index 000000000000..2de5c4bb50ef --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/deleteGuestDiagnosticSettingsAssociation.json @@ -0,0 +1,17 @@ +{ + "parameters": { + "resourceUri":"subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai", + "associationName": "healthSystemMachineConfigAssociation", + "api-version": "2018-06-01-preview" + }, + "responses": { + "200": { + "headers": {}, + "body": null + }, + "204": { + "headers": {}, + "body": null + } + } +} \ No newline at end of file diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json new file mode 100644 index 000000000000..3f9c43f8fdff --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json @@ -0,0 +1,22 @@ +{ + "parameters": { + "resourceUri":"subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai", + "associationName": "healthSystemMachineConfigAssociation", + "api-version": "2018-06-01-preview" + }, + "responses": { + "200": { + "headers": {}, + "body": { + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", + "name": "healthSystemMachineConfigAssociation", + "location": "Global", + "tags": {}, + "properties": { + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + } + } + } + } +} \ No newline at end of file diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json index 44bc8b4d750c..77c95ba878c5 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -245,7 +245,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings": { "get": { "description": "Get a list of all guest diagnostic settings in a resource group.", - "operationId": "guestDiagnosticsSettings_List", + "operationId": "guestDiagnosticsSettings_ListByRG", "x-ms-pageable": { "nextLinkName": null }, From cf9f582e032ea97aa661b5350aeb2a15a8d43434 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 16:07:02 +0530 Subject: [PATCH 15/24] Build failures --- .../guestDiagnosticSettingsAssociation_API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index e3d5a44c4707..856c38418f20 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -204,7 +204,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { "get": { "description": "Get a list of all guest diagnostic settings association in a resource group.", - "operationId": "guestDiagnosticsSettingsAssociation_List", + "operationId": "guestDiagnosticsSettingsAssociation_ListByRG", "x-ms-pageable": { "nextLinkName": null }, From 8d3e723694d29e8c3255ba4cc6396464d3f9aa90 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 16:19:56 +0530 Subject: [PATCH 16/24] Build failures --- ...eateOrUpdateGuestDiagnosticSettingsAssociation.json | 10 +++++----- .../getGuestDiagnosticSettingsAssociation.json | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json index 9de11c6437ae..c35cff6c5de2 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/createOrUpdateGuestDiagnosticSettingsAssociation.json @@ -7,7 +7,7 @@ "location": "Global", "tags": {}, "properties": { - "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/vmSettingForSecurity" } } }, @@ -15,26 +15,26 @@ "200": { "headers": {}, "body": { - "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/healthSystemMachineConfigAssociation", "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", "name": "healthSystemMachineConfigAssociation", "location": "Global", "tags": {}, "properties": { - "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/vmSettingForSecurity" } } }, "201": { "headers": {}, "body": { - "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/healthSystemMachineConfigAssociation", "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", "name": "healthSystemMachineConfigAssociation", "location": "Global", "tags": {}, "properties": { - "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/SampleDiagnosticSettingsName" + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/vmSettingForSecurity" } } } diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json index 3f9c43f8fdff..5ee3afd4ef02 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/getGuestDiagnosticSettingsAssociation.json @@ -8,7 +8,7 @@ "200": { "headers": {}, "body": { - "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/SampleAssociationName", + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/healthSystemMachineConfigAssociation", "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", "name": "healthSystemMachineConfigAssociation", "location": "Global", From 84994fb67f395c77fbc09e64d1777d172587b374 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 16:28:08 +0530 Subject: [PATCH 17/24] Documentation fixes --- .../guestDiagnosticSettingsAssociation_API.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 856c38418f20..8ee17e217a93 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -101,6 +101,11 @@ "GuestDiagnosticsSettingsAssociation" ], "operationId": "guestDiagnosticsSettingsAssociation_Get", + "x-ms-examples": { + "Create or update an guest diagnostic settings association": { + "$ref": "./examples/getGuestDiagnosticSettingsAssociation.json" + } + }, "parameters": [ { "name": "resourceUri", @@ -137,6 +142,11 @@ "tags": [ "GuestDiagnosticsSettingsAssociation" ], + "x-ms-examples": { + "Create or update an guest diagnostic settings association": { + "$ref": "./examples/deleteGuestDiagnosticSettingsAssociation.json" + } + }, "operationId": "GuestDiagnosticsSettingsAssociation_Delete", "parameters": [ { From bed5a2b8eb6783bd73989d52f238156b20d3607a Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 17:09:55 +0530 Subject: [PATCH 18/24] Documentation fixes --- ...ateGuestDiagnosticSettingsAssociation.json | 28 +++++++++ ...uestDiagnosticSettingsAssociation_API.json | 61 ++++++++++++++++++- 2 files changed, 88 insertions(+), 1 deletion(-) create mode 100644 specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json new file mode 100644 index 000000000000..1cb3634f9265 --- /dev/null +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json @@ -0,0 +1,28 @@ +{ + "parameters": { + "resourceUri":"subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai", + "associationName": "healthSystemMachineConfigAssociation", + "api-version": "2018-06-01-preview", + "diagnosticSettingsAssociation": { + "tags": null, + "properties": { + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/vmSettingForSecurity" + } + } + }, + "responses": { + "200": { + "headers": {}, + "body": { + "id": "/subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai/providers/microsoft.insights/guestDiagnosticSettingsAssociation/healthSystemMachineConfigAssociation", + "type": "Microsoft.Insights/GuestDiagnosticSettingsAssociation", + "name": "healthSystemMachineConfigAssociation", + "location": "Global", + "tags": null, + "properties": { + "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/vmSettingForSecurity" + } + } + } + } +} \ No newline at end of file diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 8ee17e217a93..f41a7f8803c5 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -178,7 +178,50 @@ } } } - } + }, + "patch": { + "description": "Updates an existing guestDiagnosticsSettingsAssociation Resource. To update other fields use the CreateOrUpdate method", + "operationId": "guestDiagnosticsSettingsAssociation_Update", + "parameters": [ + { + "name": "resourceUri", + "in": "path", + "required": true, + "type": "string", + "description": "The fully qualified ID of the resource, including the resource name and resource type.", + "x-ms-skip-url-encoding": true + }, + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResourcePatch" + }, + "description": "Parameters supplied to the operation." + } + ], + "responses": { + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + }, + "200": { + "description": "An existing service diagnostics setting resource was successfully updated.", + "schema": { + "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" + } + } + }, + "x-ms-examples": { + "Update a service diagnostic setting": { "$ref": "./examples/updateServiceDiagnosticSetting.json" } + } + } }, "/subscriptions/{subscriptionId}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { "get": { @@ -277,6 +320,22 @@ } } }, + "GuestDiagnosticSettingsAssociationResourcePatch": { + "description": "Guest diagnostic setting resource for patch operations", + "properties": { + "tags": { + "additionalProperties": { + "type": "string" + }, + "description": "Resource tags" + }, + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/GuestDiagnosticSettingsAssociation", + "description": "The service diagnostics settings for an update operation." + } + } + }, "GuestDiagnosticSettingsAssociation": { "description": "A guest diagnostic settings association.", "properties": { From 4e3741e3d3406aaf8497676cbf0b6a58875b9ebc Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 17:20:09 +0530 Subject: [PATCH 19/24] Fixes --- .../guestDiagnosticSettingsAssociation_API.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index f41a7f8803c5..1256ed98eaee 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -212,14 +212,14 @@ } }, "200": { - "description": "An existing service diagnostics setting resource was successfully updated.", + "description": "An existing guest diagnostics setting resource was successfully updated.", "schema": { "$ref": "#/definitions/GuestDiagnosticSettingsAssociationResource" } } }, "x-ms-examples": { - "Update a service diagnostic setting": { "$ref": "./examples/updateServiceDiagnosticSetting.json" } + "Update a service diagnostic setting": { "$ref": "./examples/updateGuestDiagnosticSettingsAssociation.json" } } } }, From 4ba12667cccb02870bee3db156f5300884cdadc7 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 17:25:26 +0530 Subject: [PATCH 20/24] Fixes --- .../guestDiagnosticSettingsAssociation_API.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 1256ed98eaee..5de2383a801d 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -194,6 +194,9 @@ { "$ref": "#/parameters/ApiVersionParameter" }, + { + "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" + }, { "name": "parameters", "in": "body", From cc48583366d3939db4d47c45d1b6fcaa8f7f2704 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Fri, 29 Jun 2018 17:29:20 +0530 Subject: [PATCH 21/24] Fixes --- .../guestDiagnosticSettingsAssociation_API.json | 2 +- .../2016-09-01/examples/updateServiceDiagnosticSetting.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 5de2383a801d..c1ee15ceea3d 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -198,7 +198,7 @@ "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" }, { - "name": "parameters", + "name": "diagnosticSettingsAssociation", "in": "body", "required": true, "schema": { diff --git a/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/examples/updateServiceDiagnosticSetting.json b/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/examples/updateServiceDiagnosticSetting.json index 9dc9115491a0..da047720e4ff 100644 --- a/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/examples/updateServiceDiagnosticSetting.json +++ b/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/examples/updateServiceDiagnosticSetting.json @@ -2,7 +2,7 @@ "parameters": { "resourceUri": "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6", "api-version": "2016-09-01", - "serviceDiagnosticSettingsResource": { + "parameters": { "tags": null, "properties": { "storageAccountId":"/subscriptions/df602c9c-7aa0-407d-a6fb-eb20c8bd1192/resourceGroups/apptest/providers/Microsoft.Storage/storageAccounts/appteststorage1", From 3dd7e67f55b95d079658f3a120b4646ec32b2584 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Mon, 9 Jul 2018 15:25:17 +0530 Subject: [PATCH 22/24] Comments resolution --- .../guestDiagnosticSettingsAssociation_API.json | 2 +- .../preview/2018-06-01-preview/guestDiagnosticSettings_API.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index c1ee15ceea3d..61d3f342f0c8 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -260,7 +260,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettingsAssociations": { "get": { "description": "Get a list of all guest diagnostic settings association in a resource group.", - "operationId": "guestDiagnosticsSettingsAssociation_ListByRG", + "operationId": "guestDiagnosticsSettingsAssociation_ListByResourceGroup", "x-ms-pageable": { "nextLinkName": null }, diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json index 77c95ba878c5..092ba0613f6f 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettings_API.json @@ -245,7 +245,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/guestDiagnosticSettings": { "get": { "description": "Get a list of all guest diagnostic settings in a resource group.", - "operationId": "guestDiagnosticsSettings_ListByRG", + "operationId": "guestDiagnosticsSettings_ListByResourceGroup", "x-ms-pageable": { "nextLinkName": null }, From 352fcc0702834bfd2796d40bfb01621582d21263 Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Mon, 9 Jul 2018 15:31:34 +0530 Subject: [PATCH 23/24] Comments resolution --- .../guestDiagnosticSettingsAssociation_API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json index 61d3f342f0c8..80487b3dc64d 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/guestDiagnosticSettingsAssociation_API.json @@ -198,7 +198,7 @@ "$ref": "#/parameters/DiagnosticSettingsAssociationNameParameter" }, { - "name": "diagnosticSettingsAssociation", + "name": "parameters", "in": "body", "required": true, "schema": { From a33822cebfd629e8b442120bd2cf3f60684be44b Mon Sep 17 00:00:00 2001 From: SankalpSoni Date: Mon, 9 Jul 2018 16:02:53 +0530 Subject: [PATCH 24/24] Model CI Failure --- .../examples/updateGuestDiagnosticSettingsAssociation.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json index 1cb3634f9265..e33341549273 100644 --- a/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json +++ b/specification/monitor/resource-manager/microsoft.insights/preview/2018-06-01-preview/examples/updateGuestDiagnosticSettingsAssociation.json @@ -3,7 +3,7 @@ "resourceUri":"subscriptions/8498f01b-8064-4e37-856e-318f3c6c685f/resourceGroups/healthsystem/providers/Microsoft.Compute/virtualMachines/eastussojai", "associationName": "healthSystemMachineConfigAssociation", "api-version": "2018-06-01-preview", - "diagnosticSettingsAssociation": { + "parameters": { "tags": null, "properties": { "guestDiagnosticSettingsName": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-Association-ResourceGroup/providers/providers/microsoft.insights/guestDiagnosticSettings/vmSettingForSecurity"