Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Search Management Plane 2025-02-01-preview #31991

Merged
merged 57 commits into from
Jan 16, 2025

Conversation

kuanlu95
Copy link
Contributor

@kuanlu95 kuanlu95 commented Jan 3, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

efrainretana and others added 28 commits November 27, 2024 14:05
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-06-01-preview to preview/2025-02-01-preview.
@efrainretana
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@live1206
Copy link
Member

SDK azure-sdk-for-net-track2 is failing due to .NET SDK breaking changes, we will handle it in azure-sdk-for-net.
Right now, SDK azure-sdk-for-net-track2 is optional for spec PR merge.

@AzureRestAPISpecReview AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jan 16, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jan 16, 2025
@kuanlu95
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@efrainretana
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@efrainretana efrainretana merged commit a682ad9 into Azure:main Jan 16, 2025
27 of 29 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
* Copy files from preview/2024-06-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-02-01-preview

Updated the API version from preview/2024-06-01-preview to preview/2025-02-01-preview.

* Added tag for 2025-02-01-preview in readme file

* Swagger prettier fixes

* Swagger prettier fixes

* Add new properties for service upgrade

* Add upgrade properties to examples

* Add example for service upgrade

* Add service upgrade enpoint

* Swagger prettier changes

* Fix typo

* Add computeType to search contract.

* Fix formatting for prettier.

* Address PR feedback.

* Update swagger.

* Add Feature by region changes

* Add endpoint support feature

* Use common systemData properties

* fix typo

* Added fields to Features by region feature

* Update to have 400 aligned with other operations

* Fixing CI build errors

* Fixed CI builds

* Fix JSON

* Fix LintDiff

* Added example for update sku

* Prettier fix and avocado fix. Update example to use systemdata

* Renamed features to resource availability

* Add default region in resource availability

* Remove compute type example

* Fix ResourceAvailabilities typo

* remove isDefaultRegion

* SDK generation bug fix

* Service upgrade uses LRO, rename FeatureAvailabilities

* Model Feature Availability as enum

* Updated to align example with swagger definition

* add serviceUpgradeDate property to searchServiceProperties

* update examples with the serviceUpgradedDate property

* fix a Typo in the name of the property

* Change name to offering

* Update example file name for offering

* Add  long-running-operation pattern to upgrade path.

* prettier fix

* Some more prettier fix

* Search.json swagger prettier

---------

Co-authored-by: efrainretana <efrainretana@microsoft.com>
Co-authored-by: Leonardo Galindo Sánchez <leonardogal@microsoft.com>
Co-authored-by: Jacob Hill <thhill@microsoft.com>
Co-authored-by: efrainretana <141282336+efrainretana@users.noreply.github.com>
Co-authored-by: marcop <marcop@microsoft.com>
Co-authored-by: Kuan Lu <kualu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.