-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Search Management Plane 2025-02-01-preview #31991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-06-01-preview to preview/2025-02-01-preview.
…alu/2025-02-01-preview-changes
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
SDK azure-sdk-for-net-track2 is failing due to .NET SDK breaking changes, we will handle it in azure-sdk-for-net. |
…upgrade add serviceUpgradeDate properties to searchServiceProperty
@microsoft-github-policy-service agree company="Microsoft" |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
8 tasks
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Feb 6, 2025
* Copy files from preview/2024-06-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-02-01-preview Updated the API version from preview/2024-06-01-preview to preview/2025-02-01-preview. * Added tag for 2025-02-01-preview in readme file * Swagger prettier fixes * Swagger prettier fixes * Add new properties for service upgrade * Add upgrade properties to examples * Add example for service upgrade * Add service upgrade enpoint * Swagger prettier changes * Fix typo * Add computeType to search contract. * Fix formatting for prettier. * Address PR feedback. * Update swagger. * Add Feature by region changes * Add endpoint support feature * Use common systemData properties * fix typo * Added fields to Features by region feature * Update to have 400 aligned with other operations * Fixing CI build errors * Fixed CI builds * Fix JSON * Fix LintDiff * Added example for update sku * Prettier fix and avocado fix. Update example to use systemdata * Renamed features to resource availability * Add default region in resource availability * Remove compute type example * Fix ResourceAvailabilities typo * remove isDefaultRegion * SDK generation bug fix * Service upgrade uses LRO, rename FeatureAvailabilities * Model Feature Availability as enum * Updated to align example with swagger definition * add serviceUpgradeDate property to searchServiceProperties * update examples with the serviceUpgradedDate property * fix a Typo in the name of the property * Change name to offering * Update example file name for offering * Add long-running-operation pattern to upgrade path. * prettier fix * Some more prettier fix * Search.json swagger prettier --------- Co-authored-by: efrainretana <efrainretana@microsoft.com> Co-authored-by: Leonardo Galindo Sánchez <leonardogal@microsoft.com> Co-authored-by: Jacob Hill <thhill@microsoft.com> Co-authored-by: efrainretana <141282336+efrainretana@users.noreply.github.com> Co-authored-by: marcop <marcop@microsoft.com> Co-authored-by: Kuan Lu <kualu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Approved-Previously
Changes were reviewed and approved in a previous PR
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
brownfield
Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec.
new-api-version
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.