Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AML] add missing parameter patter #31197

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[AML] add missing parameter patter #31197

merged 1 commit into from
Oct 25, 2024

Conversation

ZhidaLiu
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@ZhidaLiu
Add missing parameter pattern
402e128 
add missing pattern for parameter

Add missing pattern for the parameter
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 24, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 24, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning https://apiview.dev/Assemblies/Review/c19328b4fc084461adfa498aa764be2f?revisionId=23314009aab441f6b6552f2b10ea1aa6
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=75c3bda549ca40d2a8fdbb12f7e78c79
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=8d1093587e844436baa893cbf27eace0
.Net Azure.ResourceManager.MachineLearning There is no API change compared with the previous version
Swagger Microsoft.MachineLearningServices https://apiview.dev/Assemblies/Review/af9cc69e6ae94f27ab2ca41fddf6ba46?revisionId=4d04324543ed4c308ee2cc5e107491b6

@ZhidaLiu ZhidaLiu marked this pull request as ready for review October 24, 2024 03:00
This was referenced Oct 24, 2024
Closed
Closed
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 24, 2024
This was referenced Oct 24, 2024
Closed
Closed
ramoka178
ramoka178 reviewed Oct 24, 2024
View reviewed changes
...vices/resource-manager/Microsoft.MachineLearningServices/preview/2024-10-01-preview/mfe.json
@@ -10131,14 +10131,16 @@
"name": "poolName",
"description": "InferencePool name.",
"required": true,
"type": "string"
"type": "string",
"pattern": "^[a-zA-Z0-9][a-zA-Z0-9\\-_]{0,254}$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens to the resources that exist today that do not follow this pattern ?

same comment for all places.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a new resource that just released in this API version, we actually have this check in server side, just missed in the swagger

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@ramoka178 ramoka178 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Oct 25, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 25, 2024
@ragovada ragovada merged commit 28ebcea into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-10-01-preview Oct 25, 2024
23 of 26 checks passed
@ragovada ragovada mentioned this pull request Oct 25, 2024
Merged
8 tasks
ZhidaLiu added a commit that referenced this pull request Oct 28, 2024
@ragovada @ZhidaLiu
@paledger @u9009 @sagarsumant
Release machinelearningservices microsoft.machine learning services 2…
98f21ae 
…024 10 01 preview (#30112)

* Copy files from preview/2024-07-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from preview/2024-07-01-preview to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* Fix for Prettier gate failures on Oct24 Preview (#30373)

* [AML]re-order mfe.json in 2024-10-01-preview (#30540)

* re-order mfe.json

* update order for properties

* fix description

* Add InferencePools resource to 2024-10-01-preview  (#30531)

* Add InferencePool APIs to 2024-10-01-preview

* Run Prettier to fix gates

* [AML]re-order mfe.json in 2024-10-01-preview (#30540)

* re-order mfe.json

* update order for properties

* fix description

* rebase main

* Run prettier to fix gates

* Add delta model API - accidentally excluded before

* Add deltamodel examples

* Move delta model examples

* Fix examples

* Update examples to remove outdated properties

* Remove schema

* KeyValuePair

* Update examples with array of KVP

* Update examples with array of KVP

* Update examples with array of KVP

* Run prettier on examples

---------

Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>

* [AML] 2024-10-01-preview change for workspace RP (#30651)

* update workspace RP

fix proxy API version parameter

fix format

* Fix JS automation

* update properties

* update with fix

* address feedback

* resolve lintdiff

* Update format

* remove one property

* Updated "WorkspaceRP.json" to add the property `ProvisionNetworkNow`. (#30754)

- To provision the managed VNet with the default Options when creating a Workspace with the managed VNet enabled, or
  else it does nothing

Co-authored-by: Jing Li <jingli8@microsoft.com>

* [MFE][InferencePools] Add operation IDs (#30776)

Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>

* 2024-10-01-preview - Update finetuning job related contracts in oct preview api. (#30798)

* Update finetuning contracts.

* Prettify

* update examples.

* make it prettier.

* Fix gates.

* fix bad json.

* prettify

* Fix the model validation gates.

* Fix model validation gates.

* Fix.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* [AML] Add capabilityHosts support in MFE (#30666)

* temp save

* Add capabilityHost support to MFE

* Update location header in example

* Fix errors

* Change readonly location to enum

* Add suppression

* [AML]Update capabilityHost schema (#30957)

* Update capabilityHost

* Update CapabilityHost schema

* Fix typo

* Fix bug in swagger (#31070)

* [AML] Fix LintDiff in staging branch (#31135)

* Add some suppression

* Fixing MFE LintDiff

* Update RP suppression

* Add missing parameter pattern (#31197)

add missing pattern for parameter

Add missing pattern for the parameter

---------

Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Paula Ledgerwood <pledgerw@calpoly.edu>
Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>
Co-authored-by: Jing Li <u9009@outlook.com>
Co-authored-by: Jing Li <jingli8@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Oct 29, 2024
@ragovada @ZhidaLiu
@paledger @u9009 @sagarsumant @markcowl
Release machinelearningservices microsoft.machine learning services 2…
12da569 
…024 10 01 preview (Azure#30112)

* Copy files from preview/2024-07-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from preview/2024-07-01-preview to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* Fix for Prettier gate failures on Oct24 Preview (Azure#30373)

* [AML]re-order mfe.json in 2024-10-01-preview (Azure#30540)

* re-order mfe.json

* update order for properties

* fix description

* Add InferencePools resource to 2024-10-01-preview  (Azure#30531)

* Add InferencePool APIs to 2024-10-01-preview

* Run Prettier to fix gates

* [AML]re-order mfe.json in 2024-10-01-preview (Azure#30540)

* re-order mfe.json

* update order for properties

* fix description

* rebase main

* Run prettier to fix gates

* Add delta model API - accidentally excluded before

* Add deltamodel examples

* Move delta model examples

* Fix examples

* Update examples to remove outdated properties

* Remove schema

* KeyValuePair

* Update examples with array of KVP

* Update examples with array of KVP

* Update examples with array of KVP

* Run prettier on examples

---------

Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>

* [AML] 2024-10-01-preview change for workspace RP (Azure#30651)

* update workspace RP

fix proxy API version parameter

fix format

* Fix JS automation

* update properties

* update with fix

* address feedback

* resolve lintdiff

* Update format

* remove one property

* Updated "WorkspaceRP.json" to add the property `ProvisionNetworkNow`. (Azure#30754)

- To provision the managed VNet with the default Options when creating a Workspace with the managed VNet enabled, or
  else it does nothing

Co-authored-by: Jing Li <jingli8@microsoft.com>

* [MFE][InferencePools] Add operation IDs (Azure#30776)

Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>

* 2024-10-01-preview - Update finetuning job related contracts in oct preview api. (Azure#30798)

* Update finetuning contracts.

* Prettify

* update examples.

* make it prettier.

* Fix gates.

* fix bad json.

* prettify

* Fix the model validation gates.

* Fix model validation gates.

* Fix.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* [AML] Add capabilityHosts support in MFE (Azure#30666)

* temp save

* Add capabilityHost support to MFE

* Update location header in example

* Fix errors

* Change readonly location to enum

* Add suppression

* [AML]Update capabilityHost schema (Azure#30957)

* Update capabilityHost

* Update CapabilityHost schema

* Fix typo

* Fix bug in swagger (Azure#31070)

* [AML] Fix LintDiff in staging branch (Azure#31135)

* Add some suppression

* Fixing MFE LintDiff

* Update RP suppression

* Add missing parameter pattern (Azure#31197)

add missing pattern for parameter

Add missing pattern for the parameter

---------

Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Paula Ledgerwood <pledgerw@calpoly.edu>
Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>
Co-authored-by: Jing Li <u9009@outlook.com>
Co-authored-by: Jing Li <jingli8@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
haagha pushed a commit that referenced this pull request Nov 19, 2024
@ragovada @ZhidaLiu
@paledger @u9009 @sagarsumant @haagha
Release machinelearningservices microsoft.machine learning services 2…
eebec25 
…024 10 01 preview (#30112)

* Copy files from preview/2024-07-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from preview/2024-07-01-preview to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* Fix for Prettier gate failures on Oct24 Preview (#30373)

* [AML]re-order mfe.json in 2024-10-01-preview (#30540)

* re-order mfe.json

* update order for properties

* fix description

* Add InferencePools resource to 2024-10-01-preview  (#30531)

* Add InferencePool APIs to 2024-10-01-preview

* Run Prettier to fix gates

* [AML]re-order mfe.json in 2024-10-01-preview (#30540)

* re-order mfe.json

* update order for properties

* fix description

* rebase main

* Run prettier to fix gates

* Add delta model API - accidentally excluded before

* Add deltamodel examples

* Move delta model examples

* Fix examples

* Update examples to remove outdated properties

* Remove schema

* KeyValuePair

* Update examples with array of KVP

* Update examples with array of KVP

* Update examples with array of KVP

* Run prettier on examples

---------

Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>

* [AML] 2024-10-01-preview change for workspace RP (#30651)

* update workspace RP

fix proxy API version parameter

fix format

* Fix JS automation

* update properties

* update with fix

* address feedback

* resolve lintdiff

* Update format

* remove one property

* Updated "WorkspaceRP.json" to add the property `ProvisionNetworkNow`. (#30754)

- To provision the managed VNet with the default Options when creating a Workspace with the managed VNet enabled, or
  else it does nothing

Co-authored-by: Jing Li <jingli8@microsoft.com>

* [MFE][InferencePools] Add operation IDs (#30776)

Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>

* 2024-10-01-preview - Update finetuning job related contracts in oct preview api. (#30798)

* Update finetuning contracts.

* Prettify

* update examples.

* make it prettier.

* Fix gates.

* fix bad json.

* prettify

* Fix the model validation gates.

* Fix model validation gates.

* Fix.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* [AML] Add capabilityHosts support in MFE (#30666)

* temp save

* Add capabilityHost support to MFE

* Update location header in example

* Fix errors

* Change readonly location to enum

* Add suppression

* [AML]Update capabilityHost schema (#30957)

* Update capabilityHost

* Update CapabilityHost schema

* Fix typo

* Fix bug in swagger (#31070)

* [AML] Fix LintDiff in staging branch (#31135)

* Add some suppression

* Fixing MFE LintDiff

* Update RP suppression

* Add missing parameter pattern (#31197)

add missing pattern for parameter

Add missing pattern for the parameter

---------

Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Paula Ledgerwood <pledgerw@calpoly.edu>
Co-authored-by: Paula Ledgerwood <paledger@microsoft.com>
Co-authored-by: Jing Li <u9009@outlook.com>
Co-authored-by: Jing Li <jingli8@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramoka178 ramoka178 ramoka178 left review comments

@ragovada ragovada ragovada approved these changes

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhidaLiu @ramoka178 @ragovada @AzureRestAPISpecReview