Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Modules and Activities Response #2941

Closed
wants to merge 1 commit into from
Closed

Updating Modules and Activities Response #2941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions ...ation/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"description": "Gets or sets a Boolean value that indicates true if the parameter is dynamic."
},
"position": {
"type": "boolean",
"type": "integer",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for code gen in most or all languages, and this swagger is in the stable folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our SDK is still in preview mode and open for breaking changes (https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/3.0.1-preview). Also, from what I understood, the service returns integer and not boolean, which is why we corrected this and changed to integer type from boolean.

@avkaur Could you please confirm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's right.

"description": "Gets or sets the position of the activity parameter."
},
"valueFromPipeline": {
Expand All @@ -74,7 +74,18 @@
"valueFromRemainingArguments": {
"type": "boolean",
"description": "Gets or sets a Boolean value that indicates true if the cmdlet parameter accepts all the remaining command-line arguments that are associated with this parameter in the form of an array. false if the cmdlet parameter does not accept all the remaining argument values."
}
},
"description": {
"type": "string",
"description": "Gets or sets the description of the activity parameter."
},
"validationSet": {
"type": "array",
"items": {
"$ref": "#/definitions/ActivityParameterValidationSet"
},
"description": "Gets or sets the validation set of activity parameter."
}
},
"description": "Definition of the activity parameter."
},
Expand All @@ -94,6 +105,15 @@
},
"description": "Definition of the activity parameter set."
},
"ActivityParameterValidationSet": {
"properties": {
"memberValue": {
"type": "string",
"description": "Gets or sets the name of the activity parameter validation set member."
}
},
"description": "Definition of the activity parameter validation set."
},
"ActivityOutputType": {
"properties": {
"name": {
Expand Down Expand Up @@ -2365,6 +2385,10 @@
"description": {
"type": "string",
"description": "Gets or sets the description."
},
"isComposite": {
"type": "boolean",
"description": "Gets or sets type of module, if its composite or not."
}
},
"description": "Definition of the module property type."
Expand Down
6 changes: 4 additions & 2 deletions ...esource-manager/Microsoft.Automation/stable/2015-10-31/examples/createOrUpdateModule.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@
"code": null,
"message": null
},
"provisioningState": "Creating"
"provisioningState": "Creating",
"isComposite": false
}
}
},
Expand All @@ -63,7 +64,8 @@
"code": null,
"message": null
},
"provisioningState": "Creating"
"provisioningState": "Creating",
"isComposite": false
}
}
}
Expand Down
Loading