Adding support for HTTP2 to Web Apps

[tombuildsstuff]

Based on the information in this article, I believe this is correct: https://blogs.msdn.microsoft.com/appserviceteam/2018/04/13/announcing-http2-support-in-azure-app-service/

@mcardosos @marstr @jhendrixMSFT I also added support for generating the missing 2018-02-01 Web SDK - although in my limited testing that appears to be broken due to Invalid Swagger, so I can revert this if needed:

* azurerm_app_service_plan.test: web.AppServicePlansClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'eastus' and API version '2018-02-01' for type 'serverFarms'. The supported api-versions are '2017-08-01, 2016-09-01, 2016-03-01, 2015-08-01, 2015-07-01, 2015-06-01, 2015-05-01, 2015-04-01, 2015-02-01, 2014-11-01, 2014-06-01, 2014-04-01, 2014-04-01-preview'. The supported locations are 'centralus, northeurope, westeurope, southeastasia, koreacentral, koreasouth, westus, eastus, japanwest, japaneast, eastasia, eastus2, northcentralus, southcentralus, brazilsouth, australiaeast, australiasoutheast, westindia, centralindia, southindia, canadacentral, canadaeast, westcentralus, ukwest, uksouth, westus2, msftwestus, msfteastus, msfteastasia, msftnortheurope, eastus2stage, eastasiastage, centralusstage, northcentralusstage, francecentral'."

---

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2065

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1782

[AutorestCI]

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#4

[AutorestCI]

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2612

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 783 Error(s): 0
After the PR: Warning(s): 783 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 783 Error(s): 0
After the PR: Warning(s): 783 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[tombuildsstuff]

I've integrated the result of this into Terraform and I can confirm the result looks good to us:

$ acctests azurerm TestAccAzureRMAppService_http2Enabled
=== RUN   TestAccAzureRMAppService_http2Enabled
--- PASS: TestAccAzureRMAppService_http2Enabled (98.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       98.568s

[mcardosos]

Hello @tombuildsstuff !
Thanks for submitting a PR :) We will take a look at this
@LukaszStem @naveedaz @nking92

[naveedaz]

@tombuildsstuff I am trying to understand why you want to add http20Enabled property to the MigrateMySqlStatus object. The http20Enabled property already exists on SiteConfig, at https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json#L2180.

[marstr]

Ping @tombuildsstuff.

Do you have any insight for me and @naveedaz here?

[tombuildsstuff]

@marstr sorry, missed this ping.

@naveedaz apologies, you're right - I'd searched for this but missed it. We're now using this field and as such I'll close this PR