ContainerInstance: Adding April Swagger For GA #2778
Conversation
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
| } | ||
| } | ||
| }, | ||
| "Logs": { |
There was a problem hiding this comment.
"Logs": { [](start = 1, length = 12)
This type is used only as return value from the server. It is not supposed to be sent back to server thus all the properties should be marked as read-only.
| } | ||
| }, | ||
| "ContainerExecResponse": { | ||
| "description": "The information for the container exec command.", |
There was a problem hiding this comment.
Same comment here - the type is used only as server response. Please mark all the properties as read-only.
| } | ||
| }, | ||
| "Operation": { | ||
| "description": "An operation for Azure Container Instance service.", |
There was a problem hiding this comment.
same comment - this is used only as server return value. please mark all the properties as read-only.
| "required": [ | ||
| "name", | ||
| "display" | ||
| ] |
There was a problem hiding this comment.
does not make sense to put required fields in the type that is used only as a server response.
| } | ||
| }, | ||
| "ContainerState": { | ||
| "description": "The container instance state.", |
There was a problem hiding this comment.
the name of this type suggest that it is populated only by server - please mark all the properties as read-only
| } | ||
| } | ||
| }, | ||
| "Event": { |
There was a problem hiding this comment.
Event [](start = 5, length = 5)
same here - user should not modify the events received from server. Please mark properties as read-only.
|
@ravbhatnagar Could you check if it was approved before? |
|
@samkreter according to swagger spec specifications https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#fixed-fields-13 |
|
@hovsepm Just finished the changes you requested. |
de12b25 to
ab364c6
Compare
|
@samkreter once ARM team will sing off on the new stable version we will be able to merge. |
|
Signing off from ARM side. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger