Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial review of the swagger json for DataBox #2772

Merged
merged 10 commits into from
Apr 18, 2018
Merged

Initial review of the swagger json for DataBox #2772

merged 10 commits into from
Apr 18, 2018

Conversation

kushalvms
Copy link
Contributor

@kushalvms kushalvms commented Mar 29, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

swagger for DataBox service
gets or sets removal from comments
@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1645

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2757

@sarangan12
Copy link
Contributor

Please resolve the errors reported at: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/359709970

@sarangan12
Copy link
Contributor

@kushalvms Did you get a chance to look at the errors?

@kushalvms
Copy link
Contributor Author

@sarangan12 I am fixing the issues but I am facing few challenges in it.
I am following the https://github.com/Azure/azure-powershell/blob/preview/documentation/testing-docs/using-azure-test-framework.md#new-testcredential for recording tests so that I can generate examples, but the setup is not seems to be working. I am getting: Message: System.Exception : SubscriptionList:'' retrieved for the user/spn id '', do not match with the provided subscriptionId '3c66da21-607e-49b4-8bdf-f25fbb8f705f' in connection string. Am I missing something?
I tried creating an example file for operations from other existing services(edited response) and added the reference in swagger but still getting one error: ERROR (XmsExamplesRequired/R2022/SDKViolation): Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.

@kushalvms
Copy link
Contributor Author

I have included x-ms-examples for operations api but still the linter validation is failing for this. Could anyone help me with how to fix this? I have used https://github.com/Azure/oav for generating the examples from the test result.

@kushalvms
Copy link
Contributor Author

@sarangan12 Could you have a look and tell me what am I missing here? As I have included x-ms-examples for the operations api.
Thanks.

Added examples for all the service apis.
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/databox/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 8 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Removing the internal api that is only being used by the runner service
and should not be visible to customers.
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/databox/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 6 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@sarangan12 sarangan12 merged commit 7b0ce29 into Azure:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants