Web: adding support for `computeMode` to App Service plans #2645

tombuildsstuff · 2018-03-13T22:18:34Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

I've based this on this ARM Template: https://github.com/Azure/azure-quickstart-templates/blob/master/101-function-app-create-dynamic/azuredeploy.json#L48 - which appears that it's possible to create a Dynamic App Service Plan without the App Service Environment. This is currently blocking hashicorp/terraform-provider-azurerm#960

dsgouda · 2018-03-13T22:21:17Z

specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json

+     "type": "string",
+     "x-ms-enum": {
+      "name": "ComputeModeOptions",
+      "modelAsString": false


Are you sure you want to set "modelAsString":false this could cause breaking changes when/if the enum values are modified.

Also, you may want to update some of the x-ms-examples with this property

I copied and paste this from another section below, so I assume that’s intentional ¯_(ツ)_/¯

I can definitely add an example though, sure 👍🏼

As long as you are aware of the implications of breaking changes, we are OK with this. If you think that the value of this enum may change in the future we recommend setting "modelAsString":true
If unsure, we can leave it as is.

pushed changes to update this and the existing reference to true. There appears to be no examples for creating an App Service Plan at the moment; I can add one but I believe it'd be better for the service team to provide complete samples of the common scenarios?

@tombuildsstuff What is the motivation for adding computemode to App Service Plan. You can get that information about dedicated/shared/dynamic from the App Service Plan SKU. https://docs.microsoft.com/en-us/rest/api/appservice/appserviceplans/createorupdate#skudescription

Consumption Plan:
"sku": {
"name": "Y1",
"tier": "Dynamic",
"size": "Y1",
"family": "Y",
"capacity": 0
}

From: https://docs.microsoft.com/en-us/rest/api/appservice/appserviceplans/getserverfarmskus

{
"value": [
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "F1",
"tier": "Free"
},
"capacity": {
"minimum": 0,
"maximum": 0,
"default": 0,
"scaleType": "none"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "D1",
"tier": "Shared"
},
"capacity": {
"minimum": 0,
"maximum": 0,
"default": 0,
"scaleType": "none"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "B1",
"tier": "Basic"
},
"capacity": {
"minimum": 1,
"maximum": 3,
"default": 1,
"scaleType": "manual"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "B2",
"tier": "Basic"
},
"capacity": {
"minimum": 1,
"maximum": 3,
"default": 1,
"scaleType": "manual"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "B3",
"tier": "Basic"
},
"capacity": {
"minimum": 1,
"maximum": 3,
"default": 1,
"scaleType": "manual"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "S1",
"tier": "Standard"
},
"capacity": {
"minimum": 1,
"maximum": 10,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "S2",
"tier": "Standard"
},
"capacity": {
"minimum": 1,
"maximum": 10,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "S3",
"tier": "Standard"
},
"capacity": {
"minimum": 1,
"maximum": 10,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "P1",
"tier": "Premium"
},
"capacity": {
"minimum": 1,
"maximum": 20,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "P2",
"tier": "Premium"
},
"capacity": {
"minimum": 1,
"maximum": 20,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "P3",
"tier": "Premium"
},
"capacity": {
"minimum": 1,
"maximum": 20,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "I1",
"tier": "Isolated"
},
"capacity": {
"minimum": 1,
"maximum": 20,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "I2",
"tier": "Isolated"
},
"capacity": {
"minimum": 1,
"maximum": 20,
"default": 1,
"scaleType": "automatic"
}
},
{
"resourceType": "Microsoft.Web/serverfarms",
"sku": {
"name": "I3",
"tier": "Isolated"
},
"capacity": {
"minimum": 1,
"maximum": 20,
"default": 1,
"scaleType": "automatic"
}
}
],
"nextLink": null,
"id": null
}

AutorestCI · 2018-03-13T22:37:16Z

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp_7yy99ro/rest/specification/web/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp_7yy99ro/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ComputeModeOptions' and different values: Shared,Dedicated,Dynamic vs. Shared,Dedicated,Dynamic
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: java/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

AutorestCI · 2018-03-13T22:41:29Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp5xwcwdro/rest/specification/web/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp5xwcwdro/sdk', '--multiapi', '--package-version=latest', '--use=@microsoft.azure/autorest.go@~2.1.87', "--user-agent='Azure-SDK-For-Go/latest services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.87->2.1.88)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2016-09"} .
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ComputeModeOptions' and different values: Shared,Dedicated,Dynamic vs. Shared,Dedicated,Dynamic
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
Failure during batch task - {"tag":"package-2016-09"} -- Error: Plugin imodeler1 reported failure..
  Error: Plugin imodeler1 reported failure.

AutorestCI · 2018-03-13T22:47:44Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpidflw4h_/rest/specification/web/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpidflw4h_/sdk', '--use=@microsoft.azure/autorest.python@2.1.40', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4259/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4259)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (2.1.40->2.1.40)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ComputeModeOptions' and different values: Shared,Dedicated,Dynamic vs. Shared,Dedicated,Dynamic
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 217
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 48
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 310
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: python/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

dsgouda

LGTM

dsgouda · 2018-03-13T23:40:49Z

specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json

+     ],
+     "type": "string",
+     "x-ms-enum": {
+      "name": "ComputeModeOptions",


Looks like you are redefining the same enum ComputeModeOptions multiple times but with different values for "modelAsString". What you may do is

Create a single definition for it and have it referenced wherever required

Modify "modelAsString":true for each definition of ComputeModeOptions

I'd recommend the former

yeah I was just trying to debug that 😄

I've gone with the latter for the moment to get the build to pass, and I'll now look into the former :)

pushed a change for the former 🤞

@dsgouda sorry to pester, but would you be able to advise/explain how I can fix this build on Java and Go, since it appears fine in the Node build?

salameer · 2018-03-14T00:15:52Z

Hey Tom!

Nice to see you here again! we'll tag someone from the Web team to review and Ack and we can move forward!

dsgouda · 2018-03-14T00:18:27Z

@naveedaz PTAL since you may have some context regarding this spec.
@tombuildsstuff I will try and debug the issues with CIs once we get a review from the service team
Thanks!

tombuildsstuff · 2018-03-14T22:21:20Z

@naveedaz replying out of the in-line thread to be able to scroll to the bottom and see the latest reply - hope you don't mind :)

AFAIK in order to create a Function App in a Consumption plan this is required, as can be seen in this ARM Template - if that's not the case is there any documentation we can reference about this? All of the examples I've seen for creating a Consumption plan referencing the ARM Templates which have this field present, which is why we believe it's required, but maybe we're wrong 😄

At the moment customers are unable to deploy Function Apps into a Consumption Plan with Terraform since this field is missing - hence the disclaimer here: https://www.terraform.io/docs/providers/azurerm/r/function_app.html

Thanks!

dsgouda

Needs review

naveedaz · 2018-03-15T02:33:59Z

@tombuildsstuff
Not sure if it is documented publicly. The template at https://github.com/Azure/azure-quickstart-templates/blob/master/101-function-app-create-dynamic/azuredeploy.json#L48 is fairly old and uses the old serverfarm API.

The template excerpt below will achieve what you are looking for:
{
"type": "Microsoft.Web/serverfarms",
"apiVersion": "2016-09-01",
"name": "[variables('hostingPlanName')]",
"kind": "functionapp",
"sku": {
"name": "Y1",
"tier": "Dynamic",
"size": "Y1"
},
"location": "[resourceGroup().location]",
"properties": {
}
}

tombuildsstuff · 2018-03-15T03:29:28Z

@naveedaz I've taken a look and this appears correct, as such I've opened hashicorp/terraform-provider-azurerm#981. Given this field is available in the API (and ARM Templates) - should it be exposed in the Swagger either way? Thanks!

naveedaz · 2018-03-15T07:10:08Z

@tombuildsstuff
It is already defined in the swagger: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json#L2211

and is referenced in the App Service Plan model: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json#L379

tombuildsstuff · 2018-03-15T19:58:59Z

@naveedaz right - however this value isn't configurable using the current Swagger (the value is only retrievable) - hence this PR :)

naveedaz · 2018-03-15T21:09:57Z

@tombuildsstuff
The property sku is settable from swagger. The property sku is at the same level as kind, type and location not within the "properties" property

{
             "type": "Microsoft.Web/serverfarms",
             "kind": "functionapp",
             "sku": {
                          "name": "Y1",
                          "tier": "Dynamic",
                          "size": "Y1"
             },
             "location": "",
             "properties": {
             }
}

tombuildsstuff · 2018-03-15T23:19:18Z

@naveedaz the field computeMode is available in the API within the SKU block - but isn't visible/setable in any of the SDK's: https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/WebSites/Management.Websites/Generated/Models/SkuDescription.cs#L61

Whilst admittedly the field lives within the SKU block, which is available in the SDK - the computeMode field isn't exposed in either the C#/.net SDK or the Go SDK (or any of the other SDK's) since they're missing from the Swagger

Hope that helps clarify what I mean :)

Thanks!

naveedaz · 2018-03-15T23:24:24Z

@tombuildsstuff
You should NOT be using the ComputeMode field at all. Please only use the sku block to set the App Service Plan. ComputeMode will eventually be removed. The supported way of creating a consumption plan is to use the sku property.

tombuildsstuff · 2018-03-15T23:37:17Z

@naveedaz ok cool, thanks for confirming that - I'll close this PR in the meantime :)

I guess there's two outstanding issues which need to be fixed as a result of this PR:

Document this field has been removed/deprecated, so folks don't continue using it
Fix the outdated ARM Templates in the Azure/azure-quickstart-templates repository to use the newer SKUs without the computeMode field

No. 2 is particularly important in our case since many folks are either using/looking at ARM Templates in order to determine which configuration of fields needs to be set in other tooling (such as Terraform) in order to achieve certain configurations.

@salameer @naveedaz where would be the best place to file bugs for these two issues? :)

Thanks!

AutorestCI · 2018-03-15T23:38:12Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

naveedaz · 2018-03-15T23:44:11Z

For #2 Please create an issue on https://github.com/Azure/azure-quickstart-templates against the template: https://github.com/Azure/azure-quickstart-templates/blob/master/101-function-app-create-dynamic/azuredeploy.json.

I am not aware of a good place for documenting api-version differences. We will need to figure that out.

tombuildsstuff · 2018-03-16T01:30:28Z

@naveedaz opened Azure/azure-quickstart-templates#4352 to cover No. 2

@salameer would you be able to comment on the best way forward to fix No. 1? :)

Thanks!

azuresdkciprbot · 2018-03-19T17:12:55Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 22
After the PR: Warning(s): 0 Error(s): 22

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Web: adding support for computeMode to App Service plans

97244d8

azuresdkci assigned dsgouda Mar 13, 2018

dsgouda suggested changes Mar 13, 2018

View reviewed changes

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR web/resource-manager] Web: adding support for computeMode to App Service plans Azure/azure-libraries-for-java#270

Closed

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR web/resource-manager] Web: adding support for computeMode to App Service plans Azure/azure-sdk-for-go#1250

Closed

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR web/resource-manager] Web: adding support for computeMode to App Service plans Azure/azure-sdk-for-python#2162

Closed

dsgouda approved these changes Mar 13, 2018

View reviewed changes

dsgouda closed this Mar 13, 2018

dsgouda reopened this Mar 13, 2018

dsgouda reviewed Mar 13, 2018

View reviewed changes

Updating modelAsString to true

39f9498

tombuildsstuff force-pushed the app-service-plan-computemode branch from 215ad7e to 39f9498 Compare March 13, 2018 23:42

Creating a single definition for ComputeModeOptions

372c1a5

tombuildsstuff force-pushed the app-service-plan-computemode branch from 16775c5 to 372c1a5 Compare March 13, 2018 23:54

dsgouda assigned naveedaz Mar 14, 2018

tombuildsstuff mentioned this pull request Mar 14, 2018

Azure Functions App in Consumption Plan hashicorp/terraform-provider-azurerm#960

Closed

dsgouda suggested changes Mar 15, 2018

View reviewed changes

tombuildsstuff mentioned this pull request Mar 15, 2018

Support for Function Apps in Consumption Plans hashicorp/terraform-provider-azurerm#981

Merged

tombuildsstuff closed this Mar 15, 2018

tombuildsstuff mentioned this pull request Mar 16, 2018

Web Apps fields are deprecated but are still used Azure/azure-quickstart-templates#4352

Open

tombuildsstuff mentioned this pull request Sep 25, 2019

Open Source the Wiki required for contributing to API Specifications #7315

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web: adding support for `computeMode` to App Service plans #2645

Web: adding support for `computeMode` to App Service plans #2645

tombuildsstuff commented Mar 13, 2018 •

edited by azuresdkci

Loading

dsgouda Mar 13, 2018

dsgouda Mar 13, 2018

tombuildsstuff Mar 13, 2018

dsgouda Mar 13, 2018

tombuildsstuff Mar 13, 2018

naveedaz Mar 14, 2018

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

dsgouda left a comment

dsgouda Mar 13, 2018

tombuildsstuff Mar 13, 2018

tombuildsstuff Mar 13, 2018

tombuildsstuff Mar 14, 2018

salameer commented Mar 14, 2018

dsgouda commented Mar 14, 2018

tombuildsstuff commented Mar 14, 2018

dsgouda left a comment

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018 •

edited

Loading

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 16, 2018

azuresdkciprbot commented Mar 19, 2018

Web: adding support for computeMode to App Service plans #2645

Web: adding support for computeMode to App Service plans #2645

Conversation

tombuildsstuff commented Mar 13, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Mar 13, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Mar 13, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 13, 2018 • edited Loading

Automation for azure-sdk-for-python

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salameer commented Mar 14, 2018

dsgouda commented Mar 14, 2018

tombuildsstuff commented Mar 14, 2018

dsgouda left a comment

Choose a reason for hiding this comment

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018 • edited Loading

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 15, 2018 • edited Loading

AutorestCI commented Mar 15, 2018 • edited Loading

Automation for azure-sdk-for-node

naveedaz commented Mar 15, 2018

tombuildsstuff commented Mar 16, 2018

azuresdkciprbot commented Mar 19, 2018

Web: adding support for `computeMode` to App Service plans #2645

Web: adding support for `computeMode` to App Service plans #2645

tombuildsstuff commented Mar 13, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

tombuildsstuff commented Mar 15, 2018 •

edited

Loading

tombuildsstuff commented Mar 15, 2018 •

edited

Loading

AutorestCI commented Mar 15, 2018 •

edited

Loading