Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add directive to avoid breaking change in js #25490

Merged
merged 1 commit into from
Aug 28, 2023
Merged

add directive to avoid breaking change in js #25490

merged 1 commit into from
Aug 28, 2023

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 requested a review from MaryGao August 24, 2023 01:43
@kazrael2119 kazrael2119 requested a review from qiaozha as a code owner August 24, 2023 01:43
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 24, 2023 •
edited
Loading

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 24, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.4) new version base version
default default(01cbc63) default(main)
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 24, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️❌SDK Breaking Change Tracking failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-resource-manager-schemas warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 24, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/apimanagement/armapimanagement https://apiview.dev/Assemblies/Review/946db4ee90aa47aba81d96f9b26de03e
JavaScript @azure/arm-apimanagement https://apiview.dev/Assemblies/Review/14d08f39fadf454b9715aa0bc2070fb9

@kazrael2119 kazrael2119 mentioned this pull request Aug 24, 2023
Merged
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 24, 2023
@azure-sdk azure-sdk mentioned this pull request Aug 24, 2023
Closed
@azure-sdk azure-sdk mentioned this pull request Aug 24, 2023
Closed
This was referenced Aug 24, 2023
Closed
Closed
MaryGao pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 25, 2023
@kazrael2119
[mgmt] apimanagement release (#26720)
e7e552a 
Azure/sdk-release-request#4372
swagger pr:Azure/azure-rest-api-specs#25490
MaryGao
MaryGao approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only JS config changes and no need to require ARM review

@kazrael2119
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@MaryGao MaryGao removed ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript labels Aug 28, 2023
@MaryGao MaryGao merged commit 0c4762d into Azure:main Aug 28, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 28, 2023
This was referenced Aug 28, 2023
Closed
Closed
Closed
Closed
Closed
@kazrael2119 kazrael2119 deleted the add-directive-for-apimanagement branch August 28, 2023 05:48
dgetu pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 6, 2023
@kazrael2119 @dgetu
[mgmt] apimanagement release (#26720)
e7b932c 
Azure/sdk-release-request#4372
swagger pr:Azure/azure-rest-api-specs#25490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees

@rkmanda rkmanda

Labels
ARMReview CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazrael2119 @MaryGao @rkmanda @AzureRestAPISpecReview