[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 #23563

tibanyas · 2023-04-14T17:43:05Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…23-03-01-preview to version 2023-05-01

openapi-workflow-bot · 2023-04-14T17:43:08Z

Hi, @tibanyas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-04-14T17:43:11Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 7 Errors, 4 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
amlfilesystem.json	2023-05-01(c9fec1c)	2023-03-01-preview(main)
storagecache.json	2023-05-01(c9fec1c)	2023-01-01(main)
storagecache.json	2023-05-01(c9fec1c)	2023-03-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed? New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L3475:3 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L3471:3
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Cancelled' from the old version. New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2113:13 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L2121:13
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Cancelled' from the old version. New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2829:9 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L2825:9
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2381:11 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L2389:11
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2449:9 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L2453:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2454:9 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L2457:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2459:9 Old: Microsoft.StorageCache/stable/2023-01-01/storagecache.json#L2461:9

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'mgsAddress' renamed or removed? New: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L633:11 Old: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L633:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'mountCommand' renamed or removed? New: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L633:11 Old: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L633:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'lustreVersion' renamed or removed? New: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L633:11 Old: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L633:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'scalingFactor' renamed or removed? New: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L2090:11 Old: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2090:11

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌LintDiff: 3 Errors, 2 Warnings failed [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2023-05	package-2023-05(c9fec1c)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` LongRunningResponseStatusCode	A 'delete' operation 'amlFilesystems_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L126	RPC-Async-V1-01
`❌` PatchIdentityProperty	The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L320	RPC-Patch-V1-11
`❌` PatchSkuProperty	The patch operation body parameter schema should contains property 'sku'. Location: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L320	RPC-Patch-V1-09
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L633
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json#L761

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L297
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L342
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L343
`❌` LongRunningResponseStatusCode	A 'delete' operation 'Caches_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L343
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L443
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L486
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L486
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L531
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L531
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property location. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L531
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L586
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L587
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L648
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L649
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L710
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L711
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L772
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L773
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L834
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L835
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L896
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L944
`❌` TrackedResourcePatchOperation	Tracked resource 'StorageTarget' must have patch operation that at least supports the update of tags. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L944
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L945
`❌` LongRunningResponseStatusCode	A 'delete' operation 'StorageTargets_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L945
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L1058
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L1104
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L1104
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L1133
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.StorageCache/stable/2023-05-01/storagecache.json#L1134

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` API Readiness check failed. Please make sure your service is deployed.	"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.StorageCache' for api version '2023-05-01'. The supported api-versions are '2019-08-01-preview, 2019-11-01, 2020-03-01, 2020-10-01, 2021-03-01, 2021-05-01, 2021-09-01, 2021-10-01-preview, 2021-11-01-preview, 2022-01-01, 2022-05-01, 2022-09-01-preview, 2023-01-01, 2023-03-01-preview'."

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-14T17:43:13Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/storagecache/armstoragecache - 4.0.0

+	Type of `CacheIdentity.UserAssignedIdentities` has been changed from `map[string]*UserAssignedIdentitiesValue` to `map[string]*UserAssignedIdentitiesValueAutoGenerated`

❌azure-sdk-for-js - @azure/arm-storagecache - 7.0.0

+	Enum KnownProvisioningStateType no longer has value Cancelled
+	Type of parameter userAssignedIdentities of interface CacheIdentity is changed from {
        [propertyName: string]: UserAssignedIdentitiesValue;
    } to {
        [propertyName: string]: UserAssignedIdentitiesValueAutoGenerated;
    }

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 7a65f22. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.5` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'userAssignedIdentitiesValue' (2 differences):
cmdout	[automation_generate.sh] [Autorest]   - properties.principalId.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:129"
cmdout	[automation_generate.sh] [Autorest]   - properties.clientId.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:130"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'userAssignedIdentitiesValue' (2 differences):
cmdout	[automation_generate.sh] [Autorest]   - properties.principalId.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:129"
cmdout	[automation_generate.sh] [Autorest]   - properties.clientId.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:130"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 7a65f22. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:759
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 759 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.StorageCache [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 7a65f22. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-storagecache [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a65f22. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/storagecache/armstoragecache [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `CacheIdentity.UserAssignedIdentities` has been changed from `map[string]*UserAssignedIdentitiesValue` to `map[string]*UserAssignedIdentitiesValueAutoGenerated`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `AmlFilesystemHealthStateType` with values `AmlFilesystemHealthStateTypeAvailable`, `AmlFilesystemHealthStateTypeDegraded`, `AmlFilesystemHealthStateTypeMaintenance`, `AmlFilesystemHealthStateTypeTransitioning`, `AmlFilesystemHealthStateTypeUnavailable`
info	[Changelog] - New enum type `AmlFilesystemIdentityType` with values `AmlFilesystemIdentityTypeNone`, `AmlFilesystemIdentityTypeUserAssigned`
info	[Changelog] - New enum type `AmlFilesystemProvisioningStateType` with values `AmlFilesystemProvisioningStateTypeCanceled`, `AmlFilesystemProvisioningStateTypeCreating`, `AmlFilesystemProvisioningStateTypeDeleting`, `AmlFilesystemProvisioningStateTypeFailed`, `AmlFilesystemProvisioningStateTypeSucceeded`, `AmlFilesystemProvisioningStateTypeUpdating`
info	[Changelog] - New enum type `ArchiveStatusType` with values `ArchiveStatusTypeCanceled`, `ArchiveStatusTypeCancelling`, `ArchiveStatusTypeCompleted`, `ArchiveStatusTypeFSScanInProgress`, `ArchiveStatusTypeFailed`, `ArchiveStatusTypeIdle`, `ArchiveStatusTypeInProgress`, `ArchiveStatusTypeNotConfigured`
info	[Changelog] - New enum type `FilesystemSubnetStatusType` with values `FilesystemSubnetStatusTypeInvalid`, `FilesystemSubnetStatusTypeOk`
info	[Changelog] - New enum type `MaintenanceDayOfWeekType` with values `MaintenanceDayOfWeekTypeFriday`, `MaintenanceDayOfWeekTypeMonday`, `MaintenanceDayOfWeekTypeSaturday`, `MaintenanceDayOfWeekTypeSunday`, `MaintenanceDayOfWeekTypeThursday`, `MaintenanceDayOfWeekTypeTuesday`, `MaintenanceDayOfWeekTypeWednesday`
info	[Changelog] - New function `NewAmlFilesystemsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AmlFilesystemsClient, error)`
info	[Changelog] - New function `*AmlFilesystemsClient.Archive(context.Context, string, string, *AmlFilesystemsClientArchiveOptions) (AmlFilesystemsClientArchiveResponse, error)`
info	[Changelog] - New function `*AmlFilesystemsClient.CancelArchive(context.Context, string, string, *AmlFilesystemsClientCancelArchiveOptions) (AmlFilesystemsClientCancelArchiveResponse, error)`
info	[Changelog] - New function `*AmlFilesystemsClient.BeginCreateOrUpdate(context.Context, string, string, AmlFilesystem, *AmlFilesystemsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AmlFilesystemsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*AmlFilesystemsClient.BeginDelete(context.Context, string, string, *AmlFilesystemsClientBeginDeleteOptions) (*runtime.Poller[AmlFilesystemsClientDeleteResponse], error)`
info	[Changelog] - New function `*AmlFilesystemsClient.Get(context.Context, string, string, *AmlFilesystemsClientGetOptions) (AmlFilesystemsClientGetResponse, error)`
info	[Changelog] - New function `*AmlFilesystemsClient.NewListByResourceGroupPager(string, *AmlFilesystemsClientListByResourceGroupOptions) *runtime.Pager[AmlFilesystemsClientListByResourceGroupResponse]`
info	[Changelog] - New function `*AmlFilesystemsClient.NewListPager(*AmlFilesystemsClientListOptions) *runtime.Pager[AmlFilesystemsClientListResponse]`
info	[Changelog] - New function `*AmlFilesystemsClient.BeginUpdate(context.Context, string, string, AmlFilesystemUpdate, *AmlFilesystemsClientBeginUpdateOptions) (*runtime.Poller[AmlFilesystemsClientUpdateResponse], error)`
info	[Changelog] - New function `*ClientFactory.NewAmlFilesystemsClient() *AmlFilesystemsClient`
info	[Changelog] - New function `*ClientFactory.NewManagementClient() *ManagementClient`
info	[Changelog] - New function `NewManagementClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagementClient, error)`
info	[Changelog] - New function `*ManagementClient.CheckAmlFSSubnets(context.Context, *ManagementClientCheckAmlFSSubnetsOptions) (ManagementClientCheckAmlFSSubnetsResponse, error)`
info	[Changelog] - New function `*ManagementClient.GetRequiredAmlFSSubnetsSize(context.Context, *ManagementClientGetRequiredAmlFSSubnetsSizeOptions) (ManagementClientGetRequiredAmlFSSubnetsSizeResponse, error)`
info	[Changelog] - New struct `AmlFilesystem`
info	[Changelog] - New struct `AmlFilesystemArchive`
info	[Changelog] - New struct `AmlFilesystemArchiveInfo`
info	[Changelog] - New struct `AmlFilesystemArchiveStatus`
info	[Changelog] - New struct `AmlFilesystemCheckSubnetError`
info	[Changelog] - New struct `AmlFilesystemCheckSubnetErrorFilesystemSubnet`
info	[Changelog] - New struct `AmlFilesystemClientInfo`
info	[Changelog] - New struct `AmlFilesystemContainerStorageInterface`
info	[Changelog] - New struct `AmlFilesystemEncryptionSettings`
info	[Changelog] - New struct `AmlFilesystemHealth`
info	[Changelog] - New struct `AmlFilesystemHsmSettings`
info	[Changelog] - New struct `AmlFilesystemIdentity`
info	[Changelog] - New struct `AmlFilesystemProperties`
info	[Changelog] - New struct `AmlFilesystemPropertiesHsm`
info	[Changelog] - New struct `AmlFilesystemPropertiesMaintenanceWindow`
info	[Changelog] - New struct `AmlFilesystemSubnetInfo`
info	[Changelog] - New struct `AmlFilesystemUpdate`
info	[Changelog] - New struct `AmlFilesystemUpdateProperties`
info	[Changelog] - New struct `AmlFilesystemUpdatePropertiesMaintenanceWindow`
info	[Changelog] - New struct `AmlFilesystemsListResult`
info	[Changelog] - New struct `RequiredAmlFilesystemSubnetsSize`
info	[Changelog] - New struct `RequiredAmlFilesystemSubnetsSizeInfo`
info	[Changelog] - New struct `Resource`
info	[Changelog] - New struct `SKUName`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New struct `UserAssignedIdentitiesValueAutoGenerated`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 102 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a65f22. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-storagecache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-storagecache-7.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group AmlFilesystems
info	[Changelog]   - Added Interface AmlFilesystem
info	[Changelog]   - Added Interface AmlFilesystemArchive
info	[Changelog]   - Added Interface AmlFilesystemArchiveInfo
info	[Changelog]   - Added Interface AmlFilesystemArchiveStatus
info	[Changelog]   - Added Interface AmlFilesystemCheckSubnetError
info	[Changelog]   - Added Interface AmlFilesystemCheckSubnetErrorFilesystemSubnet
info	[Changelog]   - Added Interface AmlFilesystemClientInfo
info	[Changelog]   - Added Interface AmlFilesystemContainerStorageInterface
info	[Changelog]   - Added Interface AmlFilesystemEncryptionSettings
info	[Changelog]   - Added Interface AmlFilesystemHealth
info	[Changelog]   - Added Interface AmlFilesystemHsmSettings
info	[Changelog]   - Added Interface AmlFilesystemIdentity
info	[Changelog]   - Added Interface AmlFilesystemPropertiesHsm
info	[Changelog]   - Added Interface AmlFilesystemPropertiesMaintenanceWindow
info	[Changelog]   - Added Interface AmlFilesystemsArchiveOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsCancelArchiveOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsCreateOrUpdateHeaders
info	[Changelog]   - Added Interface AmlFilesystemsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsDeleteHeaders
info	[Changelog]   - Added Interface AmlFilesystemsDeleteOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsGetOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsListByResourceGroupOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsListNextOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsListOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemsListResult
info	[Changelog]   - Added Interface AmlFilesystemSubnetInfo
info	[Changelog]   - Added Interface AmlFilesystemsUpdateHeaders
info	[Changelog]   - Added Interface AmlFilesystemsUpdateOptionalParams
info	[Changelog]   - Added Interface AmlFilesystemUpdate
info	[Changelog]   - Added Interface AmlFilesystemUpdatePropertiesMaintenanceWindow
info	[Changelog]   - Added Interface CheckAmlFSSubnetsOptionalParams
info	[Changelog]   - Added Interface GetRequiredAmlFSSubnetsSizeOptionalParams
info	[Changelog]   - Added Interface RequiredAmlFilesystemSubnetsSize
info	[Changelog]   - Added Interface RequiredAmlFilesystemSubnetsSizeInfo
info	[Changelog]   - Added Interface Resource
info	[Changelog]   - Added Interface SkuName
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Interface UserAssignedIdentitiesValueAutoGenerated
info	[Changelog]   - Added Type Alias AmlFilesystemHealthStateType
info	[Changelog]   - Added Type Alias AmlFilesystemIdentityType
info	[Changelog]   - Added Type Alias AmlFilesystemProvisioningStateType
info	[Changelog]   - Added Type Alias AmlFilesystemsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias AmlFilesystemsGetResponse
info	[Changelog]   - Added Type Alias AmlFilesystemsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias AmlFilesystemsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias AmlFilesystemsListNextResponse
info	[Changelog]   - Added Type Alias AmlFilesystemsListResponse
info	[Changelog]   - Added Type Alias AmlFilesystemsUpdateResponse
info	[Changelog]   - Added Type Alias ArchiveStatusType
info	[Changelog]   - Added Type Alias FilesystemSubnetStatusType
info	[Changelog]   - Added Type Alias GetRequiredAmlFSSubnetsSizeResponse
info	[Changelog]   - Added Type Alias MaintenanceDayOfWeekType
info	[Changelog]   - Added Enum KnownAmlFilesystemHealthStateType
info	[Changelog]   - Added Enum KnownAmlFilesystemProvisioningStateType
info	[Changelog]   - Added Enum KnownArchiveStatusType
info	[Changelog]   - Added Enum KnownFilesystemSubnetStatusType
info	[Changelog]   - Enum KnownProvisioningStateType has a new value Canceled
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter userAssignedIdentities of interface CacheIdentity is changed from {
info	[Changelog]         [propertyName: string]: UserAssignedIdentitiesValue;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: UserAssignedIdentitiesValueAutoGenerated;
info	[Changelog]     }
info	[Changelog]   - Enum KnownProvisioningStateType no longer has value Cancelled

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 7a65f22. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️storagecache [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 7a65f22. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.storagecache.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.storagecache.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-14T17:43:14Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/storagecache/armstoragecache	https://apiview.dev/Assemblies/Review/5ff1a17ad1d64f2a86355a0cce1aaa52
Java	azure-resourcemanager-storagecache	https://apiview.dev/Assemblies/Review/f1191f3f5442417aa338a9e819b399ad
JavaScript	@azure/arm-storagecache	https://apiview.dev/Assemblies/Review/b4df28c1bfbf4ca8b0a4a5efad80c001

openapi-workflow-bot · 2023-04-14T19:56:41Z

Hi @tibanyas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

mikekistler · 2023-04-17T17:08:52Z

Breaking changes previously reviewed and approved in #19724

tibanyas · 2023-04-17T19:56:52Z

This PR is for the new 2023-05-01 stable API version for Microsoft.StorageCache and is based off of the Approved 2023-03-01-preview API version.

The most recent stable API version is 2023-01-01, and the main difference between 2023-03-01-preview and 2023-01-01 is the support for the amlFilesystem resource, which went public preview with the 2023-03-01-preview API version. The amlFilesystem resource is planning to go GA with the 2023-05-01 API version and this is the main difference with the most recent stable API version (2023-01-01).

After creating 2023-05-01, based off of 2023-03-01-preview, the following changes were made:

1. Remove reference to scalingFactor and scalableSkus from storageCache.json and associated examples.

Scalable Skus is a preview feature for storagecache and it is not going GA at this time. Therefore, these fields were in the last preview API version, but needed removed for this stable version.

2. Added a new clientInfo structure in amlfilesystem.json.

Previous API versions had three client read-only fields under the AmlFilesystem structure: mgsAddress, mountCommand, and lustreVersion.
We are adding three new client fields in this new API version: (persistentVolumeClaim, persistentVolume, and storageClass)
Rather than continuing to expand the client fields under the AmlFilesystem structure, we decided to add a reference to a new clientInfo structure instead, and move the client read only fields under there. All six client fields (3 existing fields, 3 new fields) were added to the new clientInfo structure.
The 3 existing client fields were removed from the AmlFilesystem structure and moved inside of the clientInfo structure instead, and the 3 new client fields were added inside the new clientInfo structure.

Link to Breaking Changes Scenario work item: https://msazure.visualstudio.com/One/_workitems/edit/17974426

Note Regarding Commits:

The first three commits (on Mar 17, 2023) were generated by OpenApi hub and simply created the 2023-05-01 API version, based on copying the contents from 2023-03-01-preview.
The remaining commits (on Apr 14 and Apr 17, 2023) constitute the real changes from the previous preview version and this is what the reviewer should focus on. The initial April 14th commit contains the bulk of the new changes, whereas the last two commits were just Checker Error fixes (Lint, SpellCheck, and Prettier Check)

tibanyas · 2023-04-17T20:02:30Z

The Swagger LintDiff errors were all present and noted in our previous review for 2023-03-01-preview; see this PR:
#19724

They were all noted and approved at that time. Nothing is new here related to LintDiff

tadelesh · 2023-04-18T03:35:28Z

@tibanyas do your service has plan to resolve all the lint error? We bypassed the lint error based on the promise that service will handle them in next version.

tadelesh · 2023-04-19T07:30:27Z

SDK breaking changes is possibly from m4 bug. Need to handle when SDK release. @MaryGao

sjanamma · 2023-04-21T18:30:49Z

...on/storagecache/resource-manager/Microsoft.StorageCache/stable/2023-05-01/amlfilesystem.json

+        }
+      }
+    },
+    "AmlFilesystemUpdate": {


"AmlFilesystemUp

Track resource update must be able to update sku along with tags

https://github.com/Azure/azure-openapi-validator/blob/main/docs/patch-sku-property.md

@sjanamma ,
A SKU cannot be modified in our service; this is intentional. We have it's mutability classified accordingly as shown below:

"SkuName": {
"x-ms-mutability": [
"read",
"create"
],

sjanamma · 2023-04-21T19:28:01Z

The Swagger LintDiff errors were all present and noted in our previous review for 2023-03-01-preview; see this PR: #19724

They were all noted and approved at that time. Nothing is new here related to LintDiff

You are introducing a new version and breaking changes have been approved. This is the good opportunity for you to address the LintDiff issues

openapi-workflow-bot · 2023-04-21T19:31:02Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

tibanyas · 2023-04-21T22:11:15Z

@sjanamma ,

Regarding the LintDiff errors,

The following errors/warnings are false alarms:

LongRunningResponseStatusCode
AvoidNestedProperties
AvoidNextedProperties.

The other two errors listed are:

PatchSku
PatchIdentity.

As is the case with Sku, our service doesn't support modifying the Identity object, and we have its mutability classified accordingly as shown below:

"AmlFilesystemIdentity": {
"type": "object",
"description": "Managed Identity properties.",
"x-ms-mutability": [
"read",
"create"
],

Thanks,
Tim

…ion stable/2023-05-01 (Azure#23563) * Adds base for updating Microsoft.StorageCache from version preview/2023-03-01-preview to version 2023-05-01 * Updates readme * Updates API version in new specs and examples * Update files with new API changes * Fix Lint Errors * Fix SpellCheck and PrettierCheck Errors

tibanyas added 4 commits March 17, 2023 13:04

Adds base for updating Microsoft.StorageCache from version preview/20…

fcbeced

…23-03-01-preview to version 2023-05-01

Updates readme

3e780ce

Updates API version in new specs and examples

ef66f07

Update files with new API changes

6a48a0f

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 14, 2023

azure-sdk mentioned this pull request Apr 14, 2023

[AutoPR @azure/arm-storagecache] [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 azure-sdk/azure-sdk-for-js#4782

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 14, 2023

Fix Lint Errors

bd93e43

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Apr 14, 2023

azure-sdk mentioned this pull request Apr 14, 2023

[AutoPR storagecache] [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 azure-sdk/azure-resource-manager-schemas#2418

Closed

tibanyas added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 17, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 17, 2023

Fix SpellCheck and PrettierCheck Errors

c9fec1c

tibanyas marked this pull request as ready for review April 17, 2023 19:57

openapi-assignment-bot bot assigned tadelesh Apr 17, 2023

tadelesh added Approved-LintDiff ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 19, 2023

sjanamma reviewed Apr 21, 2023

View reviewed changes

This comment was marked as off-topic.

Sign in to view

sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 21, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 21, 2023

tibanyas removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 21, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 21, 2023

sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 21, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 21, 2023

tadelesh merged commit 7a65f22 into main Apr 22, 2023

tadelesh deleted the tibanyas-storagecache-Microsoft.StorageCache-2023-05-01 branch April 22, 2023 01:12

rebecca337 mentioned this pull request Jun 26, 2023

Update for Microsoft.StorageCache 2023-05-01 Azure/azure-sdk-for-net#37072

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 #23563

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 #23563

tibanyas commented Apr 14, 2023 •

edited by tadelesh

Loading

openapi-workflow-bot bot commented Apr 14, 2023

openapi-pipeline-app bot commented Apr 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 14, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 14, 2023

mikekistler commented Apr 17, 2023

tibanyas commented Apr 17, 2023 •

edited

Loading

tibanyas commented Apr 17, 2023

tadelesh commented Apr 18, 2023

tadelesh commented Apr 19, 2023

sjanamma Apr 21, 2023 •

edited

Loading

tibanyas Apr 21, 2023

sjanamma commented Apr 21, 2023

This comment was marked as off-topic.

openapi-workflow-bot bot commented Apr 21, 2023

tibanyas commented Apr 21, 2023 •

edited

Loading

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 #23563

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2023-05-01 #23563

Conversation

tibanyas commented Apr 14, 2023 • edited by tadelesh Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 14, 2023

openapi-pipeline-app bot commented Apr 14, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 14, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 14, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 14, 2023

mikekistler commented Apr 17, 2023

tibanyas commented Apr 17, 2023 • edited Loading

tibanyas commented Apr 17, 2023

tadelesh commented Apr 18, 2023

tadelesh commented Apr 19, 2023

sjanamma Apr 21, 2023 • edited Loading

Choose a reason for hiding this comment

tibanyas Apr 21, 2023

Choose a reason for hiding this comment

sjanamma commented Apr 21, 2023

This comment was marked as off-topic.

openapi-workflow-bot bot commented Apr 21, 2023

tibanyas commented Apr 21, 2023 • edited Loading

tibanyas commented Apr 14, 2023 •

edited by tadelesh

Loading

openapi-pipeline-app bot commented Apr 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2023 •

edited

Loading

tibanyas commented Apr 17, 2023 •

edited

Loading

sjanamma Apr 21, 2023 •

edited

Loading

tibanyas commented Apr 21, 2023 •

edited

Loading