Sql job agent

[jaredmoo]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@eb09067

[AutorestCI]

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@ae2c630

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[jhendrixMSFT]

@jaredmoo You still iterating on this?

[jaredmoo]

The API will not be live for a little while (i.e. at least a couple weeks) and there will be a few minor tweaks before then. How should we handle this?

[jhendrixMSFT]

I'm fine with letting it linger until ready. Has ARM already reviewed this?

[jhendrixMSFT]

@jaredmoo Has this been reviewed by ARM already?

[jaredmoo]

Sorry, missed your question earlier :) it has not been explicitly approved by ARM team

[lmazuel]

@AutorestCI rebuild azure-sdk-for-python

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1950

[lmazuel]

@AutorestCI rebuild azure-sdk-for-python

[jhendrixMSFT]

@jaredmoo We still waiting for this to be merged? Also there is a merge conflict that needs to be resolved.

[jaredmoo]

Yes, this feature has been delayed. We will message when it's ready to be merged. Thanks :)

[AutorestCI]

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

[jaredmoo]

@jhendrixMSFT the API is not public yet, but I am going on vacation soon and I want to avoid having too much work in-flight. So I have removed the new file from readme.md. This way we can get the swagger checked in but not included in SDKs yet. I am removing "do not merge" tag.

[jaredmoo]

@johnpaulkee fyi

[AutorestCI]

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-libraries-for-java#292

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[jhendrixMSFT]

@jaredmoo Sounds good, can I then assume that the remaining model validation failures will be addressed when the file is added back to the readme?

[jaredmoo]

This model validation error is a validator bug:

{ code: 'RESPONSE_VALIDATION_ERROR',
  id: 'OAV108',
  message: 'Found errors in validating the response with statusCode "200" for x-ms-example "Create or update a credential" in operation "JobCredentials_CreateOrUpdate".',
  innerErrors: 
   [ { code: 'INVALID_RESPONSE_BODY',
       errors: 
        [ { code: 'ONE_OF_MISSING',
            params: [],
            message: 'Data does not match any schemas from \'oneOf\'',
            path: [ 'properties' ],
            inner: 
             [ { code: 'OBJECT_MISSING_REQUIRED_PROPERTY',
                 params: [ 'password' ],
                 message: 'Missing required property: password',
                 path: [ 'properties' ],
                 description: 'Properties of a job credential.' },
               { code: 'INVALID_TYPE',
                 params: [ 'null', 'object' ],
                 message: 'Expected type null but found type object',
                 path: [ 'properties' ] } ] } ],
       message: 'Invalid body: Data does not match any schemas from \'oneOf\'',
       path: [] } ] }

Password is a required write-only parameter. Because it is write-only, the validator should not be checking it for null in responses.

Taking a look at the other errors.

[jaredmoo]

The other model errors were legit and I have fixed them. Should be good to merge now.

[jhendrixMSFT]

@AutorestCI rebuild azure-sdk-for-go

[jhendrixMSFT]

@AutorestCI regenerate azure-sdk-for-go

[jhendrixMSFT]

@AutorestCI regenerate azure-sdk-for-go