Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.DesktopVirtualization to add version preview/2022-10-14-preview #21700

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
70f96e1
Adds base for updating Microsoft.DesktopVirtualization from version s…
alec-baird Nov 8, 2022
3a842af
Updates readme
alec-baird Nov 8, 2022
65528b9
Updates API version in new specs and examples
alec-baird Nov 8, 2022
6e81023
Added removed changes from 2022-04-01-preview to 2022-10-14-preview
alec-baird Nov 8, 2022
1fffe1e
Removed MigrationRequest from version
alec-baird Nov 8, 2022
6c80a0f
Copied examples over from previous preview
alec-baird Nov 8, 2022
8e6124f
Added missing changes for private link to swagger
alec-baird Nov 29, 2022
ad177a4
Added enabled/disabled status to check descriptions.
alec-baird Nov 30, 2022
573377e
Added regex pattern to parameter in types.json
alec-baird Dec 1, 2022
c83b6a9
reverted mistaken common type edit and added pattern to parameters
alec-baird Dec 1, 2022
40ef1db
Revert "Added enabled/disabled status to check descriptions."
alec-baird Dec 2, 2022
62a94dc
Removed pattern requirement; will get exception on linter errors
alec-baird Dec 2, 2022
90693cf
Revert "Revert "Added enabled/disabled status to check descriptions.""
alec-baird Dec 2, 2022
e552f8a
Replaced v1 and v2 common types with v3 and added 201 responses as di…
alec-baird Dec 4, 2022
beaa83f
Only added v3 to new resources to avoid breaking changes
alec-baird Dec 5, 2022
78e07f6
Fixed incorrect find replace from param to def
alec-baird Dec 5, 2022
16f10b6
changed system data from v3 to v2 to avoid breaking changes
alec-baird Dec 5, 2022
e11c044
Updated resource version from v3 to v1 to avoid breaking changes
alec-baird Dec 5, 2022
06cfacc
Removed added 201 responses
alec-baird Dec 6, 2022
0f3fa56
Changed PrivateLinkResourceListResult to use internal definition and …
alec-baird Dec 7, 2022
22f1928
Update to use same version of PrivateEndpointConnection type
alec-baird Dec 7, 2022
7b6ec7b
Update PrivateLink version from v3 to v2 to use the same Resource def
alec-baird Dec 7, 2022
d06673c
Reverted PrivateLinkConnection v3 to v2 due to sdk problems.
alec-baird Dec 7, 2022
eb15e39
Added missed pagable to privatelink ListByHostpool
alec-baird Dec 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview",
"applicationGroup": {
"location": "centralus",
"tags": {
"tag1": "value1",
"tag2": "value2"
},
"properties": {
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"applicationGroupType": "RemoteApp"
}
}
},
"responses": {
"200": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
},
"201": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview"
},
"responses": {
"200": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
},
"204": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview"
},
"responses": {
"200": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"api-version": "2022-10-14-preview",
"$filter": "applicationGroupType eq 'RailApplication'",
"pageSize": 10,
"isDescending": true,
"initialSkip": 0
},
"responses": {
"200": {
"body": {
"value": [
{
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
},
{
"name": "applicationGroup2",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup2",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"api-version": "2022-10-14-preview",
"$filter": "applicationGroupType eq 'RailApplication'",
"pageSize": 10,
"isDescending": true,
"initialSkip": 0
},
"responses": {
"200": {
"body": {
"value": [
{
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
},
{
"name": "applicationGroup2",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup2",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview",
"applicationGroup": {
"tags": {
"tag1": "value1",
"tag2": "value2"
},
"properties": {
"description": "des1",
"friendlyName": "friendly"
}
}
},
"responses": {
"200": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
}
}
}
Loading