-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntex: moving 2022-09-15-preview version from azure-rest-api-specs-pr/RPSaaSMaster to azure-rest-api-specs/main #20959
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ad44417
Initial commit of microsoft.syntex to RPSaaSMaster branch (#6063)
yurych 7bfabd6
Added a new API version to accommodate a new spoTenantAdminUrl proper…
yurych 323d9c6
New API version: 2022-09-15-preview (#8815)
yurych fb1f524
Removed API versions that we don't want to move from azure-rest-api-s…
yurych 0ffa86a
Added "x-ms-parameter-location": "method" to fix XmsParameterLocatio…
yurych 8999b55
Tim's feedback:
yurych 3240f7e
Fixed prettier errors
yurych 22bf4f6
Tim's feedback:
yurych 1bb3c97
Tim's feedback:
yurych 1feb74c
Tim's feedback:
yurych 6bfd85e
Tim's feedback
yurych dc9aa5f
Tim's feedback:
yurych 0904838
Tim's feedback:
yurych 70f6cb4
Tim's feedback:
yurych File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2141,6 +2141,7 @@ Sybase | |
| Syncer | ||
| syncfunctiontriggers | ||
| synonymmaps | ||
| Syntex | ||
| syntheticmonitorlocations | ||
| sysctl | ||
| Sysctl | ||
|
|
||
40 changes: 40 additions & 0 deletions
40
...anager/Microsoft.Syntex/preview/2022-09-15-preview/examples/DocumentProcessor_Create.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "cd0d3cc8-cae2-4559-b882-cd707170799b", | ||
| "resourceGroupName": "mygroup", | ||
| "processorName": "myprocessor", | ||
| "api-version": "2022-09-15-preview", | ||
| "body": { | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor", | ||
| "name": "myprocessor", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
yurych marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
12 changes: 12 additions & 0 deletions
12
...anager/Microsoft.Syntex/preview/2022-09-15-preview/examples/DocumentProcessor_Delete.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "cd0d3cc8-cae2-4559-b882-cd707170799b", | ||
| "resourceGroupName": "mygroup", | ||
| "processorName": "myprocessor", | ||
| "api-version": "2022-09-15-preview" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
28 changes: 28 additions & 0 deletions
28
...e-manager/Microsoft.Syntex/preview/2022-09-15-preview/examples/DocumentProcessor_Get.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "cd0d3cc8-cae2-4559-b882-cd707170799b", | ||
| "resourceGroupName": "mygroup", | ||
| "processorName": "myprocessor", | ||
| "api-version": "2022-09-15-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor", | ||
| "name": "myprocessor", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
yurych marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
46 changes: 46 additions & 0 deletions
46
...-manager/Microsoft.Syntex/preview/2022-09-15-preview/examples/DocumentProcessor_List.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "cd0d3cc8-cae2-4559-b882-cd707170799b", | ||
| "api-version": "2022-09-15-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor1", | ||
yurych marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "name": "myprocessor1", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
yurych marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| }, | ||
| { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor2", | ||
| "name": "myprocessor2", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
47 changes: 47 additions & 0 deletions
47
...oft.Syntex/preview/2022-09-15-preview/examples/DocumentProcessor_ListByResourceGroup.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "cd0d3cc8-cae2-4559-b882-cd707170799b", | ||
| "resourceGroupName": "mygroup", | ||
| "api-version": "2022-09-15-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor1", | ||
| "name": "myprocessor1", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| }, | ||
| { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor2", | ||
| "name": "myprocessor2", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string1", | ||
| "additionalProp2": "string2", | ||
| "additionalProp3": "string3" | ||
| }, | ||
| "properties": { | ||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
...anager/Microsoft.Syntex/preview/2022-09-15-preview/examples/DocumentProcessor_Update.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "cd0d3cc8-cae2-4559-b882-cd707170799b", | ||
| "resourceGroupName": "mygroup", | ||
| "processorName": "myprocessor", | ||
| "api-version": "2022-09-15-preview", | ||
| "body": { | ||
| "tags": { | ||
| "additionalProp1": "string4", | ||
| "additionalProp2": "string5", | ||
| "additionalProp3": "string6" | ||
| }, | ||
| "properties": { | ||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
TimLovellSmith marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "body": { | ||
| "id": "/subscriptions/cd0d3cc8-cae2-4559-b882-cd707170799b/resourceGroups/mygroup/providers/microsoft.syntex/documentProcessors/myprocessor", | ||
| "name": "myprocessor", | ||
| "type": "Microsoft.Syntex/documentprocessors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "additionalProp1": "string4", | ||
| "additionalProp2": "string5", | ||
| "additionalProp3": "string6" | ||
| }, | ||
| "properties": { | ||
| "spoTenantUrl": "https://test123.sharepoint.com", | ||
| "spoTenantId": "e9bb744b-9558-4dc6-9e50-a3297e3332fa", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
103 changes: 103 additions & 0 deletions
103
...esource-manager/Microsoft.Syntex/preview/2022-09-15-preview/examples/Operations_List.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2022-09-15-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "Microsoft.Syntex/documentProcessors/read", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "Microsoft.Syntex", | ||
| "resource": "documentProcessors", | ||
| "operation": "DocumentProcessor_List", | ||
| "description": "Returns document processors in the subscription." | ||
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Syntex/documentProcessors/read", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "Microsoft.Syntex", | ||
| "resource": "documentProcessors", | ||
| "operation": "DocumentProcessor_ListByResourceGroup", | ||
| "description": "Returns document processors in a resource group." | ||
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Syntex/documentProcessors/read", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "Microsoft.Syntex", | ||
| "resource": "documentProcessors", | ||
| "operation": "DocumentProcessor_Get", | ||
| "description": "Returns a document processor for a given name." | ||
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Syntex/documentProcessors/write", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "Microsoft.Syntex", | ||
| "resource": "documentProcessors", | ||
| "operation": "DocumentProcessor_Create", | ||
| "description": "Creates a document processor resource for a given name." | ||
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Syntex/documentProcessors/delete", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "Microsoft.Syntex", | ||
| "resource": "documentProcessors", | ||
| "operation": "DocumentProcessor_Delete", | ||
| "description": "Deletes document processor resource for a given name." | ||
| } | ||
| }, | ||
| { | ||
| "name": "Microsoft.Syntex/documentProcessors/write", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "Microsoft.Syntex", | ||
| "resource": "documentProcessors", | ||
| "operation": "DocumentProcessor_Update", | ||
| "description": "Updates a document processor resource for a given name." | ||
| } | ||
| }, | ||
| { | ||
| "name": "microsoft.syntex/operations/read", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "microsoft.syntex", | ||
| "resource": "operations", | ||
| "operation": "read_operations", | ||
| "description": "read operations" | ||
| } | ||
| }, | ||
| { | ||
| "name": "microsoft.syntex/register/action", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "microsoft.syntex", | ||
| "resource": "microsoft.syntex", | ||
| "operation": "Register the microsoft.syntex", | ||
| "description": "Register the subscription for microsoft.syntex" | ||
| } | ||
| }, | ||
| { | ||
| "name": "microsoft.syntex/unregister/action", | ||
| "isDataAction": false, | ||
| "display": { | ||
| "provider": "microsoft.syntex", | ||
| "resource": "microsoft.syntex", | ||
| "operation": "Unregister the microsoft.syntex", | ||
| "description": "Unregister the subscription for microsoft.syntex" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add 201 response example? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that returning 201 makes PUT an asynchronous operation, and we agreed at the ARM review board meeting earlier this year that this PR will not b asynchronous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, returning 201 Created for PUT is just following standard HTTP behavior. Returning 202 makes PUT asynchronous. You may be thinking of returning 201 with nonterminal provisioning status or returning Azure-AsyncOperation headers with 201 which are only needed for async operations. Please review the RPC for further clarification.