From 8e9f27feb9091b8a43f46ed77d05a9d8161787df Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Tue, 15 Mar 2022 18:32:34 -0700 Subject: [PATCH 01/16] (Internal only) Added Private Endpoint Proxy Private Endpoint Update --- .../2020-03-01-preview/deviceupdate.json | 79 +++++++++++++++++++ ...ConnectionProxy_PrivateEndpointUpdate.json | 19 +++++ 2 files changed, 98 insertions(+) create mode 100644 specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 0a9a07e70a3c..dcc49ffdbdf0 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1030,6 +1030,55 @@ "deprecated": false } }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/updatePrivateEndpointProperties": { + "post": { + "description": "(INTERNAL - DO NOT USE) Validates a private endpoint connection proxy object.", + "operationId": "PrivateEndpointConnectionProxies_Validate", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/AccountNameParameter" + }, + { + "$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter" + }, + { + "name": "privateEndpointUpdate", + "in": "body", + "description": "The parameters for updating a private endpoint connection proxy.", + "required": true, + "schema": { + "$ref": "#/definitions/PrivateEndpointUpdate" + } + } + ], + "responses": { + "200": { + "description": "Validate private endpoint connection proxy empty response." + }, + "default": { + "description": "Error response describing the reason for operation failure.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "PrivateEndpointConnectionProxyValidate": { + "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json" + } + }, + "deprecated": false + } + }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}": { "get": { "tags": [ @@ -1617,6 +1666,36 @@ } } }, + "PrivateEndpointUpdate": { + "description": "Private endpoint update details.", + "type": "object", + "properties": { + "id": { + "description": "Remote endpoint resource ID.", + "type": "string" + }, + "location": { + "description": "ARM location of the remote private endpoint.", + "type": "string", + "readOnly": true + }, + "immutableSubscriptionId": { + "description": "Original subscription ID needed by Microsoft.Network.", + "type": "string", + "readOnly": true + }, + "immutableResourceId": { + "description": "Original resource ID needed by Microsoft.Network.", + "type": "string", + "readOnly": true + }, + "vnetTrafficTag": { + "description": "Virtual network traffic tag.", + "type": "string", + "readOnly": true + } + } + }, "PrivateLinkServiceConnection": { "description": "Private link service connection details.", "type": "object", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json new file mode 100644 index 000000000000..d9f827d69e34 --- /dev/null +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json @@ -0,0 +1,19 @@ +{ + "parameters": { + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "test-rg", + "accountName": "contoso", + "privateEndpointConnectionProxyId": "peexample01", + "api-version": "2020-03-01-preview", + "privateEndpointUpdate": { + "id": "/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "vnetTrafficTag": "12345678" + } + }, + "responses": { + "200": {} + } +} From 362fb660bf6a4a0ec636479e22258b0775519bfe Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Tue, 15 Mar 2022 18:48:24 -0700 Subject: [PATCH 02/16] The existing resource also needs a change --- .../preview/2020-03-01-preview/deviceupdate.json | 15 +++++++++++++++ ...ateEndpointConnectionProxy_CreateOrUpdate.json | 10 ++++++++-- .../PrivateEndpointConnectionProxy_Get.json | 5 ++++- ...vateEndpointConnectionProxy_ListByAccount.json | 5 ++++- .../PrivateEndpointConnectionProxy_Validate.json | 3 +++ 5 files changed, 34 insertions(+), 4 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index dcc49ffdbdf0..4e4d4b8a6c1d 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1631,6 +1631,21 @@ "description": "Remote endpoint resource ID.", "type": "string" }, + "location": { + "description": "ARM location of the remote private endpoint.", + "type": "string", + "readOnly": true + }, + "immutableSubscriptionId": { + "description": "Original subscription ID needed by Microsoft.Network.", + "type": "string", + "readOnly": true + }, + "immutableResourceId": { + "description": "Original resource ID needed by Microsoft.Network.", + "type": "string", + "readOnly": true + }, "vnetTrafficTag": { "description": "Virtual network traffic tag.", "type": "string", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json index 93a28ec2f88c..c7e5d5e4d542 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json @@ -7,7 +7,10 @@ "api-version": "2020-03-01-preview", "privateEndpointConnectionProxy": { "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", "manualPrivateLinkServiceConnections": [ { "name": "{privateEndpointConnectionProxyId}", @@ -33,7 +36,10 @@ "name": "peexample01", "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", "manualPrivateLinkServiceConnections": [ { "name": "{plsConnectionName}", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json index 1ae43f3d3a1f..ff91aca1a7aa 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json @@ -13,7 +13,10 @@ "name": "peexample01", "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", "manualPrivateLinkServiceConnections": [ { "name": "{plsConnectionName}", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json index c02dec9714ca..d46b71e4680f 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json @@ -14,7 +14,10 @@ "name": "peexample01", "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", "manualPrivateLinkServiceConnections": [ { "name": "{plsConnectionName}", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json index 30a2a6a8dfbd..cd155245c3ec 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json @@ -8,6 +8,9 @@ "privateEndpointConnectionProxy": { "remotePrivateEndpoint": { "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", "manualPrivateLinkServiceConnections": [ { "name": "{privateEndpointConnectionProxyId}", From f8b893f3dbfcc2590742a3c3a5dc2dee46f989d6 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 16 Mar 2022 22:22:01 -0700 Subject: [PATCH 03/16] Renamed example --- .../preview/2020-03-01-preview/deviceupdate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 4e4d4b8a6c1d..a0434c11e1aa 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1072,7 +1072,7 @@ } }, "x-ms-examples": { - "PrivateEndpointConnectionProxyValidate": { + "PrivateEndpointConnectionProxyPrivateEndpointUpdate": { "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json" } }, From f6b3ae0319a7fa6e02e61b26c0014ac217d7d1ad Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 16 Mar 2022 22:24:34 -0700 Subject: [PATCH 04/16] Fixing more copy and paste errors --- .../preview/2020-03-01-preview/deviceupdate.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index a0434c11e1aa..52413043cd3e 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1032,8 +1032,8 @@ }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/updatePrivateEndpointProperties": { "post": { - "description": "(INTERNAL - DO NOT USE) Validates a private endpoint connection proxy object.", - "operationId": "PrivateEndpointConnectionProxies_Validate", + "description": "(INTERNAL - DO NOT USE) Updates a private endpoint inside the private endpoint connection proxy object.", + "operationId": "PrivateEndpointConnectionProxies_PrivateEndpointUpdate", "parameters": [ { "$ref": "#/parameters/ApiVersionParameter" @@ -1062,7 +1062,7 @@ ], "responses": { "200": { - "description": "Validate private endpoint connection proxy empty response." + "description": "Update private endpoint in private endpoint connection proxy empty response." }, "default": { "description": "Error response describing the reason for operation failure.", From 3a20ede4a46122b5b0f005aec685012026101f4b Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Thu, 17 Mar 2022 04:39:47 -0700 Subject: [PATCH 05/16] Removed read only, formatted new file --- .../2020-03-01-preview/deviceupdate.json | 24 +++++++------------ ...ConnectionProxy_PrivateEndpointUpdate.json | 12 +++++----- 2 files changed, 14 insertions(+), 22 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 52413043cd3e..75465bbf5833 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1633,23 +1633,19 @@ }, "location": { "description": "ARM location of the remote private endpoint.", - "type": "string", - "readOnly": true + "type": "string" }, "immutableSubscriptionId": { "description": "Original subscription ID needed by Microsoft.Network.", - "type": "string", - "readOnly": true + "type": "string" }, "immutableResourceId": { "description": "Original resource ID needed by Microsoft.Network.", - "type": "string", - "readOnly": true + "type": "string" }, "vnetTrafficTag": { "description": "Virtual network traffic tag.", - "type": "string", - "readOnly": true + "type": "string" }, "manualPrivateLinkServiceConnections": { "description": "List of private link service connections that need manual approval.", @@ -1691,23 +1687,19 @@ }, "location": { "description": "ARM location of the remote private endpoint.", - "type": "string", - "readOnly": true + "type": "string" }, "immutableSubscriptionId": { "description": "Original subscription ID needed by Microsoft.Network.", - "type": "string", - "readOnly": true + "type": "string" }, "immutableResourceId": { "description": "Original resource ID needed by Microsoft.Network.", - "type": "string", - "readOnly": true + "type": "string" }, "vnetTrafficTag": { "description": "Virtual network traffic tag.", - "type": "string", - "readOnly": true + "type": "string" } } }, diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json index d9f827d69e34..c3f4cabc345f 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json @@ -6,12 +6,12 @@ "privateEndpointConnectionProxyId": "peexample01", "api-version": "2020-03-01-preview", "privateEndpointUpdate": { - "id": "/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", - "location": "westus2", - "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", - "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", - "vnetTrafficTag": "12345678" - } + "id": "/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "location": "westus2", + "immutableSubscriptionId": "00000000-0000-0000-0000-000000000000", + "immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "vnetTrafficTag": "12345678" + } }, "responses": { "200": {} From 414d0c687ca3420426606d0f4d54923ee58ddb82 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Thu, 17 Mar 2022 21:04:45 -0700 Subject: [PATCH 06/16] Move provisioning state inside proxy properties --- .../preview/2020-03-01-preview/deviceupdate.json | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 75465bbf5833..d740232d08aa 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1613,13 +1613,15 @@ "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" }, - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." - }, "status": { "description": "Operation status.", "type": "string" + }, + "properties": { + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." + } } } }, From e4e46e0fa0b61c2ce8e661c3753e4c97905470c2 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Thu, 17 Mar 2022 21:24:28 -0700 Subject: [PATCH 07/16] Revert "Move provisioning state inside proxy properties" This reverts commit 414d0c687ca3420426606d0f4d54923ee58ddb82. --- .../preview/2020-03-01-preview/deviceupdate.json | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index d740232d08aa..75465bbf5833 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1613,15 +1613,13 @@ "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" }, + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." + }, "status": { "description": "Operation status.", "type": "string" - }, - "properties": { - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." - } } } }, From e662e7842f702148d85c02c099f7ba7cdd0fdfa1 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 07:37:40 -0700 Subject: [PATCH 08/16] Moved proxy provisioning state into properties, try #2 --- .../preview/2020-03-01-preview/deviceupdate.json | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 75465bbf5833..20d2692ff5fc 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1597,7 +1597,15 @@ { "$ref": "#/definitions/PrivateEndpointConnectionProxyProperties" } - ] + ], + "properties": { + "properties": { + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." + } + } + } }, "PrivateEndpointConnectionProxyProperties": { "description": "Private endpoint connection proxy object properties.", @@ -1613,10 +1621,6 @@ "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" }, - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." - }, "status": { "description": "Operation status.", "type": "string" From 067ff1b34dc7e98327b9c8d204269b9c2657ad2b Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 07:44:59 -0700 Subject: [PATCH 09/16] Moved proxy provisioning state into properties, try number 3 --- .../preview/2020-03-01-preview/deviceupdate.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 20d2692ff5fc..4ef6348d0021 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1599,11 +1599,9 @@ } ], "properties": { - "properties": { - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." - } + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." } } }, From a541f801320a12c1406e9db0a37f998ce3dcaa8d Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 07:53:47 -0700 Subject: [PATCH 10/16] Moved proxy provisioning state into properties, try number 4 --- .../preview/2020-03-01-preview/deviceupdate.json | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 4ef6348d0021..c32558b40bb9 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1599,9 +1599,12 @@ } ], "properties": { - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." + "properties": { + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "x-ms-client-flatten": true, + "description": "The provisioning state of the private endpoint connection proxy resource." + } } } }, From 73d8c35cd3036ee3514537a94b6e79baa85fecb1 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 16:19:12 -0700 Subject: [PATCH 11/16] Moved Proxy provisioningState to top level, removed property bag --- .../preview/2020-03-01-preview/deviceupdate.json | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index c32558b40bb9..4ef6348d0021 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1599,12 +1599,9 @@ } ], "properties": { - "properties": { - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "x-ms-client-flatten": true, - "description": "The provisioning state of the private endpoint connection proxy resource." - } + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." } } }, From 69479054e58e2b7c9b89ce1dd20e2308bb612169 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 16:46:11 -0700 Subject: [PATCH 12/16] Fixed a naming error --- .../preview/2020-03-01-preview/deviceupdate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 4ef6348d0021..fefb9ab43413 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1599,7 +1599,7 @@ } ], "properties": { - "provisioningState": { + "properties": { "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", "description": "The provisioning state of the private endpoint connection proxy resource." } From 6e476979f9d85101323940e63a34f98c408b9107 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 16:51:52 -0700 Subject: [PATCH 13/16] Linter fixes --- .../preview/2020-03-01-preview/deviceupdate.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index fefb9ab43413..864ad14ac40e 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1033,7 +1033,7 @@ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/updatePrivateEndpointProperties": { "post": { "description": "(INTERNAL - DO NOT USE) Updates a private endpoint inside the private endpoint connection proxy object.", - "operationId": "PrivateEndpointConnectionProxies_PrivateEndpointUpdate", + "operationId": "PrivateEndpointConnectionProxies_UpdatePrivateEndpointProperties", "parameters": [ { "$ref": "#/parameters/ApiVersionParameter" @@ -1601,6 +1601,7 @@ "properties": { "properties": { "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "x-ms-client-flatten": true, "description": "The provisioning state of the private endpoint connection proxy resource." } } From 52e66c5bc3ecf2ad890fffb5d26b007bba5ef401 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 17:07:54 -0700 Subject: [PATCH 14/16] Removed flatten in Proxy properties --- .../preview/2020-03-01-preview/deviceupdate.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 864ad14ac40e..18534a73eb3f 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1601,7 +1601,6 @@ "properties": { "properties": { "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "x-ms-client-flatten": true, "description": "The provisioning state of the private endpoint connection proxy resource." } } From c1cb68fc43cc19c71a955418b3afe3f3ca14e666 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 17:40:18 -0700 Subject: [PATCH 15/16] Reverted all provisioningState changes --- .../preview/2020-03-01-preview/deviceupdate.json | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 18534a73eb3f..03dc5f383a30 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1597,13 +1597,7 @@ { "$ref": "#/definitions/PrivateEndpointConnectionProxyProperties" } - ], - "properties": { - "properties": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." - } - } + ] }, "PrivateEndpointConnectionProxyProperties": { "description": "Private endpoint connection proxy object properties.", @@ -1622,6 +1616,10 @@ "status": { "description": "Operation status.", "type": "string" + }, + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." } } }, From 94563316849fd453d1fb4bd0853fee3986b9a5fd Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Fri, 18 Mar 2022 17:43:01 -0700 Subject: [PATCH 16/16] Swapped properties to match the old swagger --- .../preview/2020-03-01-preview/deviceupdate.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 03dc5f383a30..51a0f5fc7a12 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1613,13 +1613,13 @@ "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" }, - "status": { - "description": "Operation status.", - "type": "string" - }, "provisioningState": { "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", "description": "The provisioning state of the private endpoint connection proxy resource." + }, + "status": { + "description": "Operation status.", + "type": "string" } } },