Add x-ms-identifiers to timeseriesinsights/resource-manager. #17803

vukelich · 2022-02-10T21:18:41Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify:

EXPLANATION OF THIS CHANGE
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-10T21:18:43Z

Hi, @vukelich Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2022-02-10T21:18:44Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-10T21:18:45Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:preview/2021-06-30-preview/timeseriesinsights.json compared with base:preview/2021-06-30-preview/timeseriesinsights.json
- current:stable/2020-05-15/timeseriesinsights.json compared with base:stable/2020-05-15/timeseriesinsights.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- timeseriesinsights/resource-manager/readme.md tag:package-preview-2021-06
- timeseriesinsights/resource-manager/readme.md tag:package-2020-05-15
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- timeseriesinsights/resource-manager/readme.md tag:package-preview-2021-06
- timeseriesinsights/resource-manager/readme.md tag:package-2020-05-15

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1646
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2182
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1646
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L2177
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.TimeSeriesInsights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L37
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.TimeSeriesInsights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L37
`❌` R4032 - MissingXmsErrorResponse	Response code 404 is defined without a x-ms-error-response. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L129
`❌` R4032 - MissingXmsErrorResponse	Response code 404 is defined without a x-ms-error-response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L129
`❌` R4037 - MissingTypeObject	The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1095
`❌` R4037 - MissingTypeObject	The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1125
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1295
`❌` R4037 - MissingTypeObject	The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1316
`❌` R4037 - MissingTypeObject	The schema 'ResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1344
`❌` R4037 - MissingTypeObject	The schema 'CreateOrUpdateTrackedResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1465
`❌` R4037 - MissingTypeObject	The schema 'EnvironmentCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1488
`❌` R4037 - MissingTypeObject	The schema 'Gen1EnvironmentCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1523
`❌` R4037 - MissingTypeObject	The schema 'Gen2EnvironmentCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1541
`❌` R4037 - MissingTypeObject	The schema 'EnvironmentListResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1626
`❌` R4037 - MissingTypeObject	The schema 'Gen1EnvironmentResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1666
`❌` R4037 - MissingTypeObject	The schema 'Gen2EnvironmentResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1684
`❌` R4037 - MissingTypeObject	The schema 'Gen1EnvironmentCreationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1702
`❌` R4037 - MissingTypeObject	The schema 'Gen2EnvironmentCreationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1737
`❌` R4037 - MissingTypeObject	The schema 'EnvironmentResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1765
`❌` R4037 - MissingTypeObject	The schema 'Gen2EnvironmentResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1809
`❌` R4037 - MissingTypeObject	The schema 'TimeSeriesIdProperty' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1880
`❌` R4037 - MissingTypeObject	The schema 'EventSourceCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2037
`❌` R4037 - MissingTypeObject	The schema 'EventHubEventSourceCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2067
`❌` R4037 - MissingTypeObject	The schema 'IoTHubEventSourceCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2085
`❌` R4037 - MissingTypeObject	The schema 'EventSourceListResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2166
`❌` R4037 - MissingTypeObject	The schema 'EventHubEventSourceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2201

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 8 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: kind Url: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1559:36 ExampleUrl: preview/2021-06-30-preview/examples/EnvironmentsPatchTags.json#L6:36
`❌` DISCRIMINATOR_VALUE_NOT_FOUND	Discriminator value "" not found Url: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L1559:36 ExampleUrl: preview/2021-06-30-preview/examples/EnvironmentsPatchTags.json#L6:36
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: kind Url: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2103:36 ExampleUrl: preview/2021-06-30-preview/examples/EventSourcesPatchTags.json#L7:36
`❌` DISCRIMINATOR_VALUE_NOT_FOUND	Discriminator value "" not found Url: Microsoft.TimeSeriesInsights/preview/2021-06-30-preview/timeseriesinsights.json#L2103:36 ExampleUrl: preview/2021-06-30-preview/examples/EventSourcesPatchTags.json#L7:36
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: kind Url: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1559:36 ExampleUrl: stable/2020-05-15/examples/EnvironmentsPatchTags.json#L6:36
`❌` DISCRIMINATOR_VALUE_NOT_FOUND	Discriminator value "" not found Url: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1559:36 ExampleUrl: stable/2020-05-15/examples/EnvironmentsPatchTags.json#L6:36
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: kind Url: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L2098:36 ExampleUrl: stable/2020-05-15/examples/EventSourcesPatchTags.json#L7:36
`❌` DISCRIMINATOR_VALUE_NOT_FOUND	Discriminator value "" not found Url: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L2098:36 ExampleUrl: stable/2020-05-15/examples/EventSourcesPatchTags.json#L7:36

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-10T21:18:45Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-timeseriesinsights - 1.0.0

❌azure-sdk-for-go - timeseriesinsights/mgmt/2020-05-15/timeseriesinsights - v61.4.0

+	Field `CreationTime` of struct `Gen1EnvironmentResourceProperties` has been removed
+	Field `LocalTimestamp` of struct `EventHubEventSourceMutableProperties` has been removed
+	Field `LocalTimestamp` of struct `EventSourceMutableProperties` has been removed
+	Field `LocalTimestamp` of struct `IoTHubEventSourceMutableProperties` has been removed
+	Field `ProvisioningState` of struct `Gen1EnvironmentResourceProperties` has been removed
+	Function `EnvironmentsClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, EnvironmentUpdateParameters)` to `(context.Context, string, string, BasicEnvironmentUpdateParameters)`
+	Function `EnvironmentsClient.Update` parameter(s) have been changed from `(context.Context, string, string, EnvironmentUpdateParameters)` to `(context.Context, string, string, BasicEnvironmentUpdateParameters)`
+	Function `EventSourcesClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, EventSourceUpdateParameters)` to `(context.Context, string, string, string, BasicEventSourceUpdateParameters)`
+	Function `EventSourcesClient.Update` parameter(s) have been changed from `(context.Context, string, string, string, EventSourceUpdateParameters)` to `(context.Context, string, string, string, BasicEventSourceUpdateParameters)`

️✔️azure-sdk-for-go - timeseriesinsights/mgmt/2017-11-15/timeseriesinsights - v61.4.0
️✔️azure-sdk-for-go - preview/timeseriesinsights/mgmt/2018-08-15-preview/timeseriesinsights - v61.4.0
️✔️azure-sdk-for-go - preview/timeseriesinsights/mgmt/2017-02-28-preview/timeseriesinsights - v61.4.0

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 6790f9f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
Resource not accessible by integration
HttpError: Resource not accessible by integration
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit+request@5.6.2_encoding@0.1.13/node_modules/@octokit/request/dist-node/index.js:86:21
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

️✔️Az.TimeSeriesInsights [View full logs]

Az.TimeSeriesInsights.0.1.0.nupkg

error	Fatal error: Resource not accessible by integration
error	The following packages are still pending:
error		Az.TimeSeriesInsights

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 6790f9f. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️timeseriesinsights/mgmt/2020-05-15/timeseriesinsights [View full logs] [Release SDK Changes]

Only show 30 items here, please refer to log for details.

info	[Changelog] - New struct `MetricAvailability`
info	[Changelog] - New struct `MetricSpecification`
info	[Changelog] - New struct `OperationProperties`
info	[Changelog] - New struct `ServiceSpecification`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventHubEventSourceCommonProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `EventHubEventSourceCommonProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `IoTHubEventSourceCreationProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `IoTHubEventSourceCreationProperties`
info	[Changelog] - New field `Kind` in struct `Gen1EnvironmentUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `IoTHubEventSourceResourceProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `IoTHubEventSourceResourceProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventHubEventSourceResourceProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `EventHubEventSourceResourceProperties`
info	[Changelog] - New anonymous field `*OperationProperties` in struct `Operation`
info	[Changelog] - New field `Origin` in struct `Operation`
info	[Changelog] - New field `Kind` in struct `Gen2EnvironmentUpdateParameters`
info	[Changelog] - New field `Kind` in struct `IoTHubEventSourceUpdateParameters`
info	[Changelog] - New field `Kind` in struct `EnvironmentUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventSourceCommonProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `EventSourceCommonProperties`
info	[Changelog] - New field `Kind` in struct `EventSourceUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `AzureEventSourceProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `AzureEventSourceProperties`
info	[Changelog] - New field `Kind` in struct `EventHubEventSourceUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `IoTHubEventSourceCommonProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `IoTHubEventSourceCommonProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventHubEventSourceCreationProperties`
info	[Changelog] - New field `LocalTimestamp` in struct `EventHubEventSourceCreationProperties`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 76 additive change(s).

️✔️timeseriesinsights/mgmt/2017-11-15/timeseriesinsights [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/timeseriesinsights/mgmt/2018-08-15-preview/timeseriesinsights [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/timeseriesinsights/mgmt/2017-02-28-preview/timeseriesinsights [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 6790f9f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-timeseriesinsights [View full logs] [Release SDK Changes]

azure-arm-timeseriesinsights-2.1.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group PrivateEndpointConnections
info	[Changelog]   - Added operation group PrivateLinkResources
info	[Changelog]   - Added Interface PrivateEndpoint
info	[Changelog]   - Added Interface PrivateEndpointConnectionListResult
info	[Changelog]   - Added Interface PrivateEndpointConnectionsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteOptionalParams
info	[Changelog]   - Added Interface PrivateEndpointConnectionsGetOptionalParams
info	[Changelog]   - Added Interface PrivateEndpointConnectionsListByEnvironmentOptionalParams
info	[Changelog]   - Added Interface PrivateLinkResourceListResult
info	[Changelog]   - Added Interface PrivateLinkResourcesListSupportedOptionalParams
info	[Changelog]   - Added Interface PrivateLinkServiceConnectionState
info	[Changelog]   - Added Type Alias PrivateEndpointConnection
info	[Changelog]   - Added Type Alias PrivateEndpointConnectionProvisioningState
info	[Changelog]   - Added Type Alias PrivateEndpointConnectionsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias PrivateEndpointConnectionsGetResponse
info	[Changelog]   - Added Type Alias PrivateEndpointConnectionsListByEnvironmentResponse
info	[Changelog]   - Added Type Alias PrivateEndpointServiceConnectionStatus
info	[Changelog]   - Added Type Alias PrivateLinkResource
info	[Changelog]   - Added Type Alias PrivateLinkResourcesListSupportedResponse
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Class TimeSeriesInsightsClient has a new parameter privateEndpointConnections
info	[Changelog]   - Class TimeSeriesInsightsClient has a new parameter privateLinkResources
info	[Changelog]   - Type Alias Gen2EnvironmentCreateOrUpdateParameters has a new parameter publicNetworkAccess
info	[Changelog]   - Type Alias Gen2EnvironmentCreateOrUpdateParameters has a new parameter privateEndpointConnections
info	[Changelog]   - Type Alias Gen2EnvironmentResource has a new parameter publicNetworkAccess
info	[Changelog]   - Type Alias Gen2EnvironmentResource has a new parameter privateEndpointConnections
info	[Changelog]   - Type Alias Gen2EnvironmentResourceProperties has a new parameter publicNetworkAccess
info	[Changelog]   - Type Alias Gen2EnvironmentResourceProperties has a new parameter privateEndpointConnections
info	[Changelog]   - Added Enum KnownPrivateEndpointConnectionProvisioningState
info	[Changelog]   - Added Enum KnownPrivateEndpointServiceConnectionStatus
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 6790f9f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-timeseriesinsights [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter local_timestamp
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter time
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter local_timestamp
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter local_timestamp_properties_local_timestamp
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCreationProperties has a new parameter local_timestamp
info	[Changelog]   - Model EventHubEventSourceCreationProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCreationProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter local_timestamp
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter time
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter type_properties_ingress_start_at_type
info	[Changelog]   - Model EventHubEventSourceResourceProperties has a new parameter local_timestamp
info	[Changelog]   - Model EventHubEventSourceResourceProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceResourceProperties has a new parameter type
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter local_timestamp
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model Gen2EnvironmentCreateOrUpdateParameters has a new parameter private_endpoint_connections
info	[Changelog]   - Model Gen2EnvironmentCreateOrUpdateParameters has a new parameter public_network_access
info	[Changelog]   - Model Gen2EnvironmentResource has a new parameter private_endpoint_connections
info	[Changelog]   - Model Gen2EnvironmentResource has a new parameter public_network_access
info	[Changelog]   - Model Gen2EnvironmentResourceProperties has a new parameter private_endpoint_connections
info	[Changelog]   - Model Gen2EnvironmentResourceProperties has a new parameter public_network_access
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter local_timestamp_properties_local_timestamp
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceCreationProperties has a new parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceCreationProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCreationProperties has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter type_properties_ingress_start_at_type
info	[Changelog]   - Model IoTHubEventSourceResourceProperties has a new parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceResourceProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceResourceProperties has a new parameter type
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]   - Model Operation has a new parameter service_specification
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model EventHubEventSourceMutableProperties no longer has parameter local_timestamp
info	[Changelog]   - Model EventHubEventSourceUpdateParameters no longer has parameter local_timestamp
info	[Changelog]   - Model EventSourceMutableProperties no longer has parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceMutableProperties no longer has parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceUpdateParameters no longer has parameter local_timestamp
info	[Changelog]   - Parameter kind of model EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EventHubEventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EventHubEventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model Gen1EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model Gen1EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model Gen2EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model Gen2EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model IoTHubEventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model IoTHubEventSourceUpdateParameters is now required

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 6790f9f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️timeseriesinsights [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-02-10T21:58:51Z

Hi @vukelich, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

weidongxu-microsoft · 2022-02-11T03:39:11Z

Please get approval from service owner (as assignee is not sure whether the definition reflect RP intention).

…7803) Co-authored-by: Steven Vukelich <svukel@microsoft.com>

Add x-ms-identifiers to timeseriesinsights/resource-manager.

6188e3b

openapi-assignment-bot bot assigned weidongxu-microsoft Feb 10, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 10, 2022

openapi-sdkautomation bot mentioned this pull request Feb 10, 2022

[AutoPR track2_azure-mgmt-timeseriesinsights] Add x-ms-identifiers to timeseriesinsights/resource-manager. AzureSDKAutomation/azure-sdk-for-python#9047

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Feb 10, 2022

weidongxu-microsoft approved these changes Feb 11, 2022

View reviewed changes

weidongxu-microsoft added the Approved-ModelValidation label Feb 24, 2022

weidongxu-microsoft merged commit 6790f9f into Azure:main Feb 24, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

Add x-ms-identifiers to timeseriesinsights/resource-manager. (Azure#1…

0928bbb

…7803) Co-authored-by: Steven Vukelich <svukel@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add x-ms-identifiers to timeseriesinsights/resource-manager. #17803

Add x-ms-identifiers to timeseriesinsights/resource-manager. #17803

vukelich commented Feb 10, 2022

openapi-workflow-bot bot commented Feb 10, 2022

openapi-workflow-bot bot commented Feb 10, 2022

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 10, 2022

weidongxu-microsoft commented Feb 11, 2022

Add x-ms-identifiers to timeseriesinsights/resource-manager. #17803

Add x-ms-identifiers to timeseriesinsights/resource-manager. #17803

Conversation

vukelich commented Feb 10, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 10, 2022

openapi-workflow-bot bot commented Feb 10, 2022

openapi-pipeline-app bot commented Feb 10, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 10, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 10, 2022

weidongxu-microsoft commented Feb 11, 2022

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading