Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add x-ms-enum to servicefabricmanagedcluster #17509

Merged

Conversation

ArcturusZhang
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ArcturusZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4037 - MissingTypeObject The schema 'AddRemoveIncrementalNamedPartitionScalingMechanism' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1105
    R4037 - MissingTypeObject The schema 'ApplicationResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1174
    R4037 - MissingTypeObject The schema 'ApplicationResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1191
    R4037 - MissingTypeObject The schema 'ApplicationResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1207
    R4037 - MissingTypeObject The schema 'ApplicationTypeResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1233
    R4037 - MissingTypeObject The schema 'ApplicationTypeResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1247
    R4037 - MissingTypeObject The schema 'ApplicationTypeResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1263
    R4037 - MissingTypeObject The schema 'ApplicationTypeUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1273
    R4037 - MissingTypeObject The schema 'ApplicationTypeVersionResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1289
    R4037 - MissingTypeObject The schema 'ApplicationTypeVersionResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1303
    R4037 - MissingTypeObject The schema 'ApplicationTypeVersionResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1319
    R4037 - MissingTypeObject The schema 'ApplicationTypeVersionUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1336
    R4037 - MissingTypeObject The schema 'ApplicationUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1348
    R4037 - MissingTypeObject The schema 'ApplicationUpgradePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1360
    R4037 - MissingTypeObject The schema 'ApplicationUserAssignedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1391
    R4037 - MissingTypeObject The schema 'AveragePartitionLoadScalingTrigger' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1407
    R4037 - MissingTypeObject The schema 'AverageServiceLoadScalingTrigger' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1446
    R4037 - MissingTypeObject The schema 'ManagedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1514
    R4037 - MissingTypeObject The schema 'NamedPartitionScheme' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1599
    R4037 - MissingTypeObject The schema 'PartitionInstanceCountScaleMechanism' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1638
    R4037 - MissingTypeObject The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1700
    R4037 - MissingTypeObject The schema 'RollingUpgradeMonitoringPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1765
    R4037 - MissingTypeObject The schema 'ServicePlacementInvalidDomainPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2008
    R4037 - MissingTypeObject The schema 'ServicePlacementPreferPrimaryDomainPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2100
    R4037 - MissingTypeObject The schema 'ServicePlacementRequiredDomainPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2122
    R4037 - MissingTypeObject The schema 'ServicePlacementRequireDomainDistributionPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2144
    R4037 - MissingTypeObject The schema 'ServiceResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2166
    R4037 - MissingTypeObject The schema 'ServiceResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2179
    R4037 - MissingTypeObject The schema 'ServiceResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2195
    R4037 - MissingTypeObject The schema 'ServiceResourcePropertiesBase' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2248
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-servicefabricmanagedclusters - 1.0.0
    +	Operation ManagedClusterVersionOperations.get_by_environment has a new signature
    +	Operation ManagedClusterVersionOperations.list_by_environment has a new signature
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5a0d0d. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.ServiceFabricManagedClusters [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e5a0d0d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ManagedUnsupportedVMSizesOperations
      info	[Changelog]   - Added operation group NodeTypeSkusOperations
      info	[Changelog]   - Model ManagedCluster has a new parameter auxiliary_subnets
      info	[Changelog]   - Model ManagedCluster has a new parameter enable_ipv6
      info	[Changelog]   - Model ManagedCluster has a new parameter enable_service_public_ip
      info	[Changelog]   - Model ManagedCluster has a new parameter ip_tags
      info	[Changelog]   - Model ManagedCluster has a new parameter ipv6_address
      info	[Changelog]   - Model ManagedCluster has a new parameter service_endpoints
      info	[Changelog]   - Model ManagedCluster has a new parameter subnet_id
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter destination_address_prefix
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter destination_port_range
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter source_address_prefix
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter source_port_range
      info	[Changelog]   - Model NodeType has a new parameter additional_data_disks
      info	[Changelog]   - Model NodeType has a new parameter data_disk_letter
      info	[Changelog]   - Model NodeType has a new parameter enable_accelerated_networking
      info	[Changelog]   - Model NodeType has a new parameter enable_encryption_at_host
      info	[Changelog]   - Model NodeType has a new parameter frontend_configurations
      info	[Changelog]   - Model NodeType has a new parameter network_security_rules
      info	[Changelog]   - Model NodeType has a new parameter sku
      info	[Changelog]   - Model NodeType has a new parameter use_default_public_load_balancer
      info	[Changelog]   - Model NodeType has a new parameter use_temp_data_disk
      info	[Changelog]   - Model NodeTypeUpdateParameters has a new parameter sku
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ManagedClusterVersionOperations.get_by_environment has a new signature
      info	[Changelog]   - Operation ManagedClusterVersionOperations.list_by_environment has a new signature
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e5a0d0d. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants