[Hub Generated] Public private branch 'sfmc_2021-09-01-privatepreview' #16049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r name Microsoft.ServiceFabric
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/4835 |
|
Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L241:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions/{version}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L287:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L513:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L562:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L779:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services/{serviceName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L825:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L1054:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L80:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L120:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L326:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}/restart' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L83:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}/reimage' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L143:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}/deleteNode' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L203:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L263:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L241:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions/{version}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L287:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L513:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L562:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L779:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services/{serviceName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L825:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L1054:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedcluster.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedcluster.json#L80:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedcluster.json#L120:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/locations/{location}/managedClusterVersions/{clusterVersion}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedcluster.json#L326:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/locations/{location}/environments/{environment}/managedClusterVersions/{clusterVersion}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedcluster.json#L369:5 |
️⚠️LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- servicefabricmanagedclusters/resource-manager/readme.md tag:package-2021-07-preview
- servicefabricmanagedclusters/resource-manager/readme.md tag:package-2021-09-privatepreview
- servicefabricmanagedclusters/resource-manager/readme.md tag:package-2021-05
- servicefabricmanagedclusters/resource-manager/readme.md tag:package-2021-01-preview
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ServiceFabric/preview/2021-09-01-privatepreview/managedcluster.json#L1118 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'AddRemoveIncrementalNamedPartitionScalingMechanism' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1105 |
|
The schema 'ApplicationResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1174 |
|
The schema 'ApplicationResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1191 |
|
The schema 'ApplicationResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1207 |
|
The schema 'ApplicationTypeResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1233 |
|
The schema 'ApplicationTypeResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1247 |
|
The schema 'ApplicationTypeResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1263 |
|
The schema 'ApplicationTypeUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1273 |
|
The schema 'ApplicationTypeVersionResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1289 |
|
The schema 'ApplicationTypeVersionResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1303 |
|
The schema 'ApplicationTypeVersionResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1319 |
|
The schema 'ApplicationTypeVersionUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1336 |
|
The schema 'ApplicationUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1348 |
|
The schema 'ApplicationUpgradePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1360 |
|
The schema 'ApplicationUserAssignedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1391 |
|
The schema 'AveragePartitionLoadScalingTrigger' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1407 |
|
The schema 'AverageServiceLoadScalingTrigger' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1446 |
|
The schema 'ManagedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1514 |
|
The schema 'NamedPartitionScheme' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1599 |
|
The schema 'PartitionInstanceCountScaleMechanism' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1638 |
|
The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1700 |
|
The schema 'RollingUpgradeMonitoringPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1765 |
|
The schema 'ServicePlacementInvalidDomainPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2008 |
|
The schema 'ServicePlacementPreferPrimaryDomainPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2100 |
|
The schema 'ServicePlacementRequiredDomainPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2122 |
|
The schema 'ServicePlacementRequireDomainDistributionPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2144 |
|
The schema 'ServiceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2166 |
|
The schema 'ServiceResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2179 |
|
The schema 'ServiceResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2195 |
|
The schema 'ServiceResourcePropertiesBase' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2248 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- servicefabricmanagedclusters/resource-manager/readme.md#package-2021-07-preview
- servicefabricmanagedclusters/resource-manager/readme.md#package-2021-05
- servicefabricmanagedclusters/resource-manager/readme.md#package-2021-01-preview
- servicefabricmanagedclusters/resource-manager/readme.md#package-2021-09-privatepreview
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Sep 15, 2021
| "description": "The application resource.", | ||
| "properties": { | ||
| "identity": { | ||
| "$ref": "#/definitions/ManagedIdentity" |
There was a problem hiding this comment.
Can you use the common types v3 definition for ManagedServiceIdentity here instead? It is almost the same as your definition. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v3/managedidentity.json
There was a problem hiding this comment.
@TimLovellSmith we don't want to do that. our model is a wrapper on top of this and if that changes we don't want to have a breaking change. and we could also add some more things in the future. So we prefer to keep it as is
There was a problem hiding this comment.
@a-santamaria No breaking change will be forced on you. The specification in common types v3 won't ever have a breaking change. If there is ever a change that 'would' be breaking, the change will be a whole new version, in common types v4, and you would only get those changes when someone intentionally updates your swagger to use the new def, because they want the breaking change.
|
Initially, there was a lintDiff issue PathResourceProviderMatchNamespace To fix it I renamed the folder to be the same as the resource provider (Microsoft.ServiceFabric) all the breaking changes shown now are due to that folder name change |
|
@JackTn could you help investigate why the public PR through openapi hub sends the PR to master branch, it should send PR to main branch. |
ruowan
approved these changes
Sep 22, 2021
This was referenced Sep 22, 2021
Closed
25 tasks
Hardell
pushed a commit
to Hardell/azure-rest-api-specs
that referenced
this pull request
Sep 27, 2021
…r name Microsoft.ServiceFabric (Azure#16049) Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…r name Microsoft.ServiceFabric (Azure#16049) Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.