Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.DesktopVirtualization to add version stable/2021-07-12 #15155

Merged
merged 3 commits into from
Jul 15, 2021
Merged

[Hub Generated] Review request for Microsoft.DesktopVirtualization to add version stable/2021-07-12 #15155

merged 3 commits into from
Jul 15, 2021

Conversation

datr93
Copy link
Contributor

@datr93 datr93 commented Jul 12, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 12, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌LintDiff: 23 Errors, 3 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Workspaces_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L57
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Workspaces_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L97
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Workspaces_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L192
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ScalingPlans_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L324
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ScalingPlans_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L364
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ScalingPlans_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L459
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ApplicationGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L591
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ApplicationGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L631
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ApplicationGroups_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L726
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Applications_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L917
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Applications_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L960
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Applications_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1061
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Desktops_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1160
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Desktops_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1203
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'HostPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1299
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'HostPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1339
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'HostPools_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1441
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'SessionHosts_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1667
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'SessionHosts_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1760
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MSIXPackages_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1859
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MSIXPackages_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1902
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MSIXPackages_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2003
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'UserSessions_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2156
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L30
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Desktops_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1257
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: UserSession_SendMessage_Post
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2410


    The following errors/warnings exist before current PR submission:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L46
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2885
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2903
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3021
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3050
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3503
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3598
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3743
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3936
    ❌ R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2450
    ❌ R4037 - MissingTypeObject The schema 'ResourceProviderOperationList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2471
    ❌ R4037 - MissingTypeObject The schema 'ResourceProviderOperation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2484
    ❌ R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2492
    ⚠️ R1003 - ListInOperationName Since operation 'MsixImages_Expand' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2106
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2517
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'expandmsiximage' in:'MsixImages_Expand'. Consider updating the operationId
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2106
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3399
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'desktops' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3626
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sessionHosts' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3906
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'msixPackages' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L3197
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'userSessions' with immediate parent 'SessionHost', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L4267
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1419
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L1738
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2233
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2513
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2603
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2736
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationEnvironment
    Location: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2907
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 57 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations/default' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1578:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1767:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/update' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1812:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/controlUpdate' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1864:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateDetails' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1912:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateDetails/default' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1957:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateValidationOperationResults/default' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L1999:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/updateOperationResults/default' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L2048:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateEndpointConnections' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L2973:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3019:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateLinkResources' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3162:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3208:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3254:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateLinkResources' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3397:5
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SessionHostConfiguration' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SessionHostConfigurationProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ImageInfoProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MarketPlaceInfoProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DomainInfoProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CredentialsProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'KeyVaultCredentialProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'HostPoolUpdate' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'HostPoolUpdateConfigurationProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ScheduledTimeProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'HostPoolControlParameter' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SessionHostComponentUpdateConfigurationProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MaintenanceWindowProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SecondaryWindowProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2021-07-12/desktopvirtualization.json#L2449:3
    Old: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L3444:3
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 12, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-04-01-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-03-09-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization - v55.6.0
    ️✔️azure-sdk-for-go - preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization - v55.6.0
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 14f9889. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
Resource not accessible by integration
HttpError: Resource not accessible by integration
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.DesktopVirtualizationApi [View full logs]  
      error	Fatal error: Resource not accessible by integration
error	The following packages are still pending:
error		Az.DesktopVirtualizationApi
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 14f9889. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-desktopvirtualization [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 14f9889. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-07-15 08:39:04 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization"
cmderr	[generate.py] 2021-07-15 08:39:04 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-07-15 08:39:04 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.32 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmderr	[generate.py] 2021-07-15 08:39:47 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-07-15 08:39:47 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-07-15 08:39:47 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
cmderr	[generate.py] 2021-07-15 08:39:47 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-07-15 08:39:47 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-07-15 08:39:47 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-desktopvirtualization [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-07-15 08:42:17 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
cmderr	[Inst] 2021-07-15 08:42:17 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-07-15 08:42:17 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-07-15 08:42:17 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-07-15 08:42:17 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-07-15 08:42:17 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-07-15 08:42:17 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15155/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 14f9889. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/desktopvirtualization/mgmt/2021-04-01-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-03-09-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs]  
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs]  
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 14f9889. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 14f9889. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceModelWithAllowedPropertySet-identity' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceModelWithAllowedPropertySet-sku' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceModelWithAllowedPropertySet-plan' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceModelWithAllowedPropertySet-identity' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceModelWithAllowedPropertySet-sku' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceModelWithAllowedPropertySet-plan' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /HostPools/put/HostPool_Create
cmderr	[Autorest]     - name: /HostPools/get/HostPool_Get
cmderr	[Autorest]     - name: /HostPools/get/HostPool_List
cmderr	[Autorest]     - name: /HostPools/get/HostPool_ListByResourceGroup
cmderr	[Autorest]     - name: /HostPools/patch/HostPool_Update
cmderr	[Autorest]     - name: /HostPools/post/HostPools_RetrieveRegistrationToken_Post
cmderr	[Autorest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_List
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
cmderr	[Autorest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
cmderr	[Autorest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
cmderr	[Autorest]     - name: /MsixImages/post/MsixImage_Expand
cmderr	[Autorest]     - name: /MSIXPackages/put/MSIXPackage_Create
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_Get
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_List
cmderr	[Autorest]     - name: /MSIXPackages/patch/MSIXPackage_Update
cmderr	[Autorest]     - name: /MSIXPackages/delete/MSIXPackage_Delete
cmderr	[Autorest]     - name: /ScalingPlans/put/ScalingPlans_Create
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_Get
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListByResourceGroup
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListBySubscription
cmderr	[Autorest]     - name: /ScalingPlans/get/UserSession_SendMessage_Post
cmderr	[Autorest]     - name: /ScalingPlans/patch/ScalingPlans_Update
cmderr	[Autorest]     - name: /ScalingPlans/delete/ScalingPlans_Delete
cmderr	[Autorest]     - name: /HostPools/delete/HostPool_Delete
cmderr	[Autorest]     - name: /Workspaces/put/Workspace_Create
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_Get
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListBySubscription
cmderr	[Autorest]     - name: /Workspaces/patch/Workspace_Update
cmderr	[Autorest]     - name: /Workspaces/delete/Workspace_Delete
cmderr	[Autorest] --------------------------------------------------------
    • ️✔️desktopvirtualization [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 14f9889. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️desktopvirtualization [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jul 12, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @datr93 datr93 requested a review from sampa-msft July 12, 2021 18:23
    @raych1
    Copy link
    Member

    raych1 commented Jul 13, 2021

    @datr93 , do you just copy the preview version and publish as stable version? Can you fix the CI check failures?

    @raych1
    Copy link
    Member

    raych1 commented Jul 13, 2021

    Can you also go thru the ARM API Review Checklist and check on appropriate items so that ARM team will start the review?

    @raych1 raych1 added CI-FixRequiredOnFailure Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jul 13, 2021
    @openapi-workflow-bot
    Copy link

    Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 13, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 13, 2021
    @mentat9 mentat9 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 14, 2021
    @raych1 raych1 added Approved-LintDiff and removed CI-FixRequiredOnFailure Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jul 15, 2021
    @raych1
    Copy link
    Member

    raych1 commented Jul 15, 2021

    Discussed with @datr93 offline and suppression is requested for lintDiff errors. The errors will be fixed in new preview version.

    @raych1 raych1 merged commit 14f9889 into Azure:master Jul 15, 2021
    This was referenced Jul 15, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @datr93 @mkarmark
    [Hub Generated] Review request for Microsoft.DesktopVirtualization to…
    0a6cc23 
    … add version stable/2021-07-12 (Azure#15155)

* Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-03-09-preview to version 2021-07-12

* Updates readme

* Updates API version in new specs and examples
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raych1 raych1 raych1 approved these changes

    @sampa-msft sampa-msft sampa-msft approved these changes

    Assignees

    @raych1 raych1

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @datr93 @raych1 @sampa-msft @JeffreyRichter @mentat9