-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving swagger to stable #14992
moving swagger to stable #14992
Conversation
Hi, @vakuncha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
OperationId should contain the verb: 'listmonitoredresources' in:'MonitoredResources_List'. Consider updating the operationId Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L371 |
|
OperationId should contain the verb: 'listdeploymentinfo' in:'DeploymentInfo_List'. Consider updating the operationId Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L419 |
|
OperationId should contain the verb: 'listvmhost' in:'VMHost_List'. Consider updating the operationId Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L667 |
|
OperationId should contain the verb: 'vmingestiondetails' in:'VMIngestion_Details'. Consider updating the operationId Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L715 |
|
OperationId should contain the verb: 'vmcollectionupdate' in:'VMCollection_Update'. Consider updating the operationId Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L760 |
|
The child tracked resource, 'tagRules' with immediate parent 'ElasticMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L1368 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L873 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L1333 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L1337 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendActivityLogs Location: Microsoft.Elastic/stable/2020-07-01/elastic.json#L1341 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 17 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2020-07-01/elastic.json compared with base:preview/2020-07-01-preview/elastic.json
Only 10 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L39:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L78:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L120:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L165:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L211:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L275:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L326:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L375:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L423:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) '2020-07-01-preview' from the old version. Old: Microsoft.Elastic/preview/2020-07-01-preview/elastic.json#L468:9 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"elastic/resource-manager/readme.md",
"tag":"package-2020-07-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"elastic/resource-manager/readme.md",
"tag":"package-2020-07-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"elastic/resource-manager/readme.md",
"tag":"package-2020-07-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"elastic/resource-manager/readme.md",
"tag":"package-2020-07-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"elastic/resource-manager/readme.md",
"tag":"package-2020-07-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
5aec305
to
0c0c64d
Compare
Hi, @vakuncha your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The breaking changes detected in 'cross version breaking change' is caused by update the enum value of 'ApiVersionParamter'. In the future, the service will use the ApiVersionParamter in common/types indead of the one defined in special swagger file. For this PR, just ignore these breaking changes. |
bc670f3
to
67a6357
Compare
* Base Swagger version as per guideline * Removing preview from directory version * changing version name in all files * updating readme and go read me * supressing ingestion keyin read me
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.