-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 #14954
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 #14954
Conversation
Hi, @melmullen Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost' removed or restructured? Old: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1557:5 |
1015 - ParameterInHasChanged |
How the parameter is passed has changed -- it used to be 'query', now it is 'path'. New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9 Old: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1557:5 |
️⚠️
LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L424 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1477 |
R4037 - MissingTypeObject |
The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1843 |
R4037 - MissingTypeObject |
The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1922 |
R4037 - MissingTypeObject |
The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1960 |
R4037 - MissingTypeObject |
The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2203 |
R4037 - MissingTypeObject |
The schema 'ReservationSummariesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2897 |
R4037 - MissingTypeObject |
The schema 'ReservationSummaryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2915 |
R4037 - MissingTypeObject |
The schema 'ReservationDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3022 |
R4037 - MissingTypeObject |
The schema 'ReservationDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3040 |
R4037 - MissingTypeObject |
The schema 'ReservationRecommendationDetailsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3132 |
R4037 - MissingTypeObject |
The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3167 |
R4037 - MissingTypeObject |
The schema 'ReservationRecommendationDetailsResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3206 |
R4037 - MissingTypeObject |
The schema 'ReservationRecommendationDetailsSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3244 |
R4037 - MissingTypeObject |
The schema 'ReservationRecommendationDetailsUsageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3282 |
R4037 - MissingTypeObject |
The schema 'ReservationRecommendationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3315 |
R4037 - MissingTypeObject |
The schema 'LegacyReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3388 |
R4037 - MissingTypeObject |
The schema 'SkuProperty' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3477 |
R4037 - MissingTypeObject |
The schema 'ModernReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3512 |
R4037 - MissingTypeObject |
The schema 'ModernReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3604 |
R4037 - MissingTypeObject |
The schema 'LegacyReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3752 |
R4037 - MissingTypeObject |
The schema 'ReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3877 |
R4037 - MissingTypeObject |
The schema 'ModernReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3895 |
R4037 - MissingTypeObject |
The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3929 |
R4037 - MissingTypeObject |
The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3951 |
R4037 - MissingTypeObject |
The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3967 |
R4037 - MissingTypeObject |
The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4001 |
R4037 - MissingTypeObject |
The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4072 |
R4037 - MissingTypeObject |
The schema 'BudgetFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4090 |
R4037 - MissingTypeObject |
The schema 'BudgetFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4115 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"consumption/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"consumption/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"consumption/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ReservationRecommendationDetailsModel' has a property 'etag' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ReservationRecommendationDetailsModel" |
|
"readme":"consumption/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction" |
|
💬 AutorestCore/Exception | "readme":"consumption/resource-manager/readme.md", "tag":"package-2021-05", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
Hi @melmullen, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This PR is to fix one issue that has been surfaced on S360. |
@msyyc Would you please take a look at the python breaking changes? |
For python, the breaking change is permitted. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.