Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 #14954

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 #14954

merged 1 commit into from
Jul 15, 2021

Conversation

Zzegfried
Copy link
Contributor

@Zzegfried Zzegfried commented Jun 23, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @melmullen Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 23, 2021

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost' removed or restructured?
    Old: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1557:5
    1015 - ParameterInHasChanged How the parameter is passed has changed -- it used to be 'query', now it is 'path'.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9
    Old: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1557:5
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L424
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1477
    R4037 - MissingTypeObject The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1843
    R4037 - MissingTypeObject The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1922
    R4037 - MissingTypeObject The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1960
    R4037 - MissingTypeObject The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2203
    R4037 - MissingTypeObject The schema 'ReservationSummariesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2897
    R4037 - MissingTypeObject The schema 'ReservationSummaryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2915
    R4037 - MissingTypeObject The schema 'ReservationDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3022
    R4037 - MissingTypeObject The schema 'ReservationDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3040
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3132
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3167
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3206
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3244
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsUsageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3282
    R4037 - MissingTypeObject The schema 'ReservationRecommendationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3315
    R4037 - MissingTypeObject The schema 'LegacyReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3388
    R4037 - MissingTypeObject The schema 'SkuProperty' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3477
    R4037 - MissingTypeObject The schema 'ModernReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3512
    R4037 - MissingTypeObject The schema 'ModernReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3604
    R4037 - MissingTypeObject The schema 'LegacyReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3752
    R4037 - MissingTypeObject The schema 'ReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3877
    R4037 - MissingTypeObject The schema 'ModernReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3895
    R4037 - MissingTypeObject The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3929
    R4037 - MissingTypeObject The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3951
    R4037 - MissingTypeObject The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L3967
    R4037 - MissingTypeObject The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4001
    R4037 - MissingTypeObject The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4072
    R4037 - MissingTypeObject The schema 'BudgetFilter' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4090
    R4037 - MissingTypeObject The schema 'BudgetFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L4115
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Schema 'ReservationRecommendationDetailsModel' has a property 'etag' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ReservationRecommendationDetailsModel"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 23, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - Approved - 8.0.0
    azure-sdk-for-go - consumption/mgmt/2019-10-01/consumption - Approved - v55.3.0
    +	Const `Scope9Shared` has been removed
    +	Const `Scope9Single` has been removed
    +	Const `Shared` type has been changed from `Scope11` to `Scope12`
    +	Const `Single` type has been changed from `Scope11` to `Scope12`
    +	Function `CreditsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `CreditsClient.Get` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `EventsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, string)`
    +	Function `EventsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, string)`
    +	Function `EventsClient.List` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, string)`
    +	Function `LotsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `LotsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `LotsClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `PossibleScope11Values` has been removed
    +	Function `PossibleScope9Values` has been removed
    +	Function `ReservationRecommendationDetailsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, Scope11, string, Term, LookBackPeriod, string)` to `(context.Context, string, Scope14, string, Term, LookBackPeriod, string)`
    +	Function `ReservationRecommendationDetailsClient.Get` parameter(s) have been changed from `(context.Context, string, Scope11, string, Term, LookBackPeriod, string)` to `(context.Context, string, Scope14, string, Term, LookBackPeriod, string)`
    +	Type of `LegacyReservationRecommendationProperties.InstanceFlexibilityRatio` has been changed from `*int32` to `*float64`
    +	Type of `ModernReservationRecommendationProperties.InstanceFlexibilityRatio` has been changed from `*int32` to `*float64`
    +	Type of `ModernReservationRecommendationProperties.LookBackPeriod` has been changed from `*string` to `*int32`
    +	Type of `ModernUsageDetailProperties.MeterID` has been changed from `*uuid.UUID` to `*string`
    ️✔️azure-sdk-for-go - consumption/mgmt/2019-01-01/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-10-01/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-08-31/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-06-30/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-05-31/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-03-31/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-01-31/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2017-11-30/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-12-30-preview/consumption - Approved - v55.3.0
    ️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-04-24-preview/consumption - Approved - v55.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5d48f6a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Consumption [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5d48f6a. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️consumption/mgmt/2019-10-01/consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New field `NewCreditInBillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `AdjustmentsInBillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `BillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `ClosedBalanceInBillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `CreditExpiredInBillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `Etag` in struct `EventSummary`
      info	[Changelog] - New field `ForecastSpend` in struct `BudgetProperties`
      info	[Changelog] - New field `Etag` in struct `UsageDetail`
      info	[Changelog]
      info	[Changelog] Total 19 breaking change(s), 81 additive change(s).
      info	[Changelog]
    • ️✔️consumption/mgmt/2019-01-01/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-10-01/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-08-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-06-30/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-05-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-03-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-01-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2017-11-30/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d48f6a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model LotSummary has a new parameter original_amount_in_billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter credit_currency
      info	[Changelog]   - Model LotSummary has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter purchase_date
      info	[Changelog]   - Model LotSummary has a new parameter billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter status
      info	[Changelog]   - Model LotSummary has a new parameter reseller
      info	[Changelog]   - Model LotSummary has a new parameter closed_balance_in_billing_currency
      info	[Changelog]   - Model ChargeSummary has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
      info	[Changelog]   - Model UsageDetail has a new parameter etag
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model Forecast has a new parameter etag
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter credit_currency
      info	[Changelog]   - Model EventSummary has a new parameter lot_id
      info	[Changelog]   - Model EventSummary has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter new_credit_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter closed_balance_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter credit_expired_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter charges_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter canceled_credit
      info	[Changelog]   - Model EventSummary has a new parameter reseller
      info	[Changelog]   - Model EventSummary has a new parameter adjustments_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_display_name
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_id
      info	[Changelog]   - Model EventSummary has a new parameter lot_source
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationsListResult has a new parameter previous_link
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter sku_name
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter location_properties_location
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model CreditSummary has a new parameter credit_currency
      info	[Changelog]   - Model CreditSummary has a new parameter reseller
      info	[Changelog]   - Model CreditSummary has a new parameter etag
      info	[Changelog]   - Model CreditSummary has a new parameter billing_currency
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
      info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
      info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
      info	[Changelog]   - Model CreditBalanceSummary has a new parameter estimated_balance_in_billing_currency
      info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_profile
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_account
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_profile
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_account
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation EventsOperations.list
      info	[Changelog]   - Removed operation LotsOperations.list
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d48f6a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-07-15 08:07:52 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-consumption;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-07-15 08:07:52 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-07-15 08:07:52 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.32 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [POM][Skip] pom already has module sdk/consumption
      cmderr	[generate.py] 2021-07-15 08:08:31 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] 2021-07-15 08:09:25 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-07-15 08:09:28 DEBUG Got artifact_id: azure-resourcemanager-consumption
      cmderr	[Inst] 2021-07-15 08:09:28 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-07-15 08:09:28 ERROR Unmatch any jar in artifacts
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5d48f6a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
      cmderr	[npmPack] created ./dist/arm-consumption.js in 618ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d48f6a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2950) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2018-01-31/Microsoft.Consumption.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2950) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2950) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      warn	No file changes detected after generation
    • ️✔️consumption [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @melmullen, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @Zzegfried
    Copy link
    Contributor Author

    This PR is to fix one issue that has been surfaced on S360.

    @chunyu3
    Copy link
    Member

    chunyu3 commented Jul 14, 2021

    @msyyc Would you please take a look at the python breaking changes?
    @ArcturusZhang Would you please take a look at the Go breaking changes?

    @msyyc
    Copy link
    Member

    msyyc commented Jul 14, 2021

    For python, the breaking change is permitted.

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 14, 2021
    @chunyu3 chunyu3 self-requested a review July 15, 2021 08:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants