[Hub Generated] Public private branch 'dev-monitor-Microsoft.Insights-2021-02-01-preview-webHookProperties' #14865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 8, 2021 11:32
|
Hi, @avjerafi Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-02-preview-only", "details":"openapi-document/openapi-document-converter - FAILED" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-02-preview-only", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-02-preview-only", "details":"Failed validating: 'swagger-document', error encountered: TypeError: Cannot read property 'value' of undefined" |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Operations API must be implemented for '/providers/Microsoft.Insights/operations'. Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L36 |
|
The schema 'ScheduledQueryRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L333 |
|
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L486 |
|
The schema 'ScheduledQueryRuleResourceCollection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L500 |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-02-preview-only", "details":"openapi-document/openapi-document-converter - FAILED" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-02-preview-only", "details":"Error: Invalid reference token: ResourceGroupNameParameter" |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-02-preview-only", "details":"Failed validating: 'swagger-document', error encountered: TypeError: Cannot read property 'value' of undefined" |
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L340 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L368 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isWorkspaceAlertsStorageConfigured Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L417 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2021-04 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-02-preview-only",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-02-preview-only",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
"tag":"package-2021-02-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
|
Hi @avjerafi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jun 17, 2021
This was referenced Jun 17, 2021
|
@weidongxu-microsoft Looking at master, it seems that ResourceGroupNameParameter is defined and that the reference path is correct: Am I wrong? |
There was a problem hiding this comment.
@jianyexi Any idea what the LintDiff means? LintDiff passes in private repo. And there appears no change to ResourceGroupNameParameter in this PR.
| @@ -3764,7 +3764,7 @@ | |||
| "requires": { | |||
There was a problem hiding this comment.
revert this file if not needed.
There was a problem hiding this comment.
@weidongxu-microsoft
I'm failing to submit my fixes. Can you please help me out?
I cloned this repo and made changes in my "copied-from-private" branch, but cannot push them:
remote: error: GH006: Protected branch update failed for refs/heads/copied-from-private/avjerafi/azure-rest-api-specs-pr/dev-monitor-Microsoft.Insights-2021-02-01-preview-webHookProperties.
remote: error: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.
I'm not all familiar with the private+public flow and the documentation I've found does not clarify what steps I need to take in this scenario.
There was a problem hiding this comment.
That is the reason I asked you to fix in the private repo PR in the first place...
Since the copied-from-private is on Azure repo (not your cloned repo), you probably not able to modify it.
There was a problem hiding this comment.
Sorry, I cannot modify this branch (surprise to me).
You will have to make another branch on your repo (based on this), and make changes on that branch, and send a new PR.
There was a problem hiding this comment.
Generally, if you do not have any secret changes that does not want non-MSFT to see, you do not need to use the private repo in the first place.
There was a problem hiding this comment.
Thanks for the input.
If the copied-from-private branch is unmodifiable, what am I to do in the current situation where there are discrepancies between the validation outcome in the private vs. the public repo?
I only moved to the public repo because I was under the impression that there will be no fixes required.
- The changes in the
package-lockfile were solely made by runningprettier. - The usage of
ResourceGroupNameParameterpassed validation in the private repo.
There was a problem hiding this comment.
You will have to make another branch on your repo (based on this), and make changes on that branch, and send a new PR.
There was a problem hiding this comment.
Got it. I'll do that. Thanks.
What will I have to modify in that new branch so that the ResourceGroupNameParameter reference will pass validation?
There was a problem hiding this comment.
Not sure.
Maybe in the new branch, you can try merge the new changes from master (which include the directive).
If it still not work, you might try delete the following directive from readme.md
- from: scheduledQueryRule_API.json
where: $.parameters
transform: delete $["ResourceGroupNameParameter"]
reason: ResourceGroupNameParameter is taken from v2/types.json
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Caused by below directive in readme.md, not sure why it exists |
@weidongxu-microsoft
Thanks! |
|
@weidongxu-microsoft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the private branch that was created into public. The branch has already been reviewed, to view the status, please go to the OpenAPI Hub.