Swagger changes for kubeenv #14417
Merged
Swagger changes for kubeenv #14417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @JennyLawrance Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
This was referenced May 14, 2021
Swagger Generation Artifacts
|
vinisoto
approved these changes
May 17, 2021
naveedaz
approved these changes
May 17, 2021
| "extendedLocation": { | ||
| "$ref": "./CommonDefinitions.json#/definitions/ExtendedLocation", | ||
| "x-ms-mutability": [ | ||
| "create", |
There was a problem hiding this comment.
Why do we need properties.extendedLoctaion? We already have extended location in the arm envelope
#14417
There was a problem hiding this comment.
It was fixed in later commit.
|
@weidongxu-microsoft can you take a look at this PR? |
|
Please review the issue description and check accordingly. This definitely need ARM review. |
|
Hi, @JennyLawrance your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @weidongxu-microsoft |
specification/web/resource-manager/Microsoft.Web/stable/2021-01-01/KubeEnvironments.json
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| }, | ||
| "x-ms-long-running-operation": true | ||
| }, | ||
| "patch": { |
There was a problem hiding this comment.
Adding @vinisoto to help here as @JennyLawrance is OOF this afternoon
|
@weidongxu-microsoft, can you merge this PR now? |
|
For python, the breaking change is expected. |
weidongxu-microsoft
pushed a commit
that referenced
this pull request
May 25, 2021
* Adds base for updating Microsoft.Web from version stable/2020-12-01 to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * Bring in swagger for Microsoft.CertificateRegistration and Microsoft.… (#14212) * Bring in swagger for Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs * Add custom word * Actually bring in swagger for Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs * Update AppServicePlan.json with preoperty (#14388) Adding ElasticScaleEnabled to ASP object! * Swagger changes for kubeenv (#14417) * Swagger changes for kubeenv * Add examples for create and update * Fixing model validations in examples * Supress systemData for kubeenvironments.json * Making small change to trigger a re-run of ApiReview runner * Fixing extendedLocation bug in swagger * fix model validation * Carry over missing Acr properties from previous version (#14490) * [python]Update readme.python.md (#14493) * Update readme.python.md * Update readme.md Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: JennyLawrance <jennylaw@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adds base for updating Microsoft.Web from version stable/2020-12-01 to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * Bring in swagger for Microsoft.CertificateRegistration and Microsoft.… (Azure#14212) * Bring in swagger for Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs * Add custom word * Actually bring in swagger for Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs * Update AppServicePlan.json with preoperty (Azure#14388) Adding ElasticScaleEnabled to ASP object! * Swagger changes for kubeenv (Azure#14417) * Swagger changes for kubeenv * Add examples for create and update * Fixing model validations in examples * Supress systemData for kubeenvironments.json * Making small change to trigger a re-run of ApiReview runner * Fixing extendedLocation bug in swagger * fix model validation * Carry over missing Acr properties from previous version (Azure#14490) * [python]Update readme.python.md (Azure#14493) * Update readme.python.md * Update readme.md Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: JennyLawrance <jennylaw@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.