[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #13177

mudit794 · 2021-02-26T02:26:41Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Add additional property

openapi-pipeline-app · 2021-02-26T02:26:44Z

Swagger Validation Report

️❌BreakingChange: 10 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-01-01/advisor.json <---> new: stable/2020-01-01/advisor.json

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'action' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1220:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1180:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'singular' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1220:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1180:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'plural' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1220:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1180:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'description' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'label' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'learnMoreLink' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'potentialBenefits' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'actions' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'remediation' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'exposedMetadataProperties' in response that was not found in the old version. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7 Old: Microsoft.Advisor/stable/2020-01-01/advisor.json#L1051:7

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- advisor/resource-manager/readme.md tag:package-2020-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- advisor/resource-manager/readme.md tag:package-2020-01

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]

The following tags are being changed in this PR

advisor/resource-manager/readme.md#package-2020-01

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"advisor/resource-manager/readme.md", "tag":"package-2020-01", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"advisor/resource-manager/readme.md", "tag":"package-2020-01", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-26T02:26:44Z

Hi, @mudit794 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-26T02:26:44Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d463274. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/advisor/resource-manager/readme.md

️✔️advisor [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 9
cmderr	[resource-manager] ERR! template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 9
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager]  A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-02-26T03_28_45_946Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 9,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3141,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d463274. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/advisor/resource-manager/readme.md

️✔️@azure/arm-advisor [View full logs] [Release SDK Changes]

azure-arm-advisor-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/advisorManagementClient.js → ./dist/arm-advisor.js...
cmderr	[npmPack] created ./dist/arm-advisor.js in 283ms

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from d463274. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-advisor [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ResourceMetadata has a new parameter plural
info	[Changelog]   - Model ResourceMetadata has a new parameter action
info	[Changelog]   - Model ResourceMetadata has a new parameter singular
info	[Changelog]   - Model SuppressionContract has a new parameter expiration_time_stamp
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter label
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter description
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter exposed_metadata_properties
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter actions
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter remediation
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter potential_benefits
info	[Changelog]   - Model ResourceRecommendationBase has a new parameter learn_more_link

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from d463274. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Advisor [View full logs] [Release SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,21): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,38): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(32,62): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(33,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(35,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(38,65): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(39,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,46): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,63): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(55,46): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(57,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(60,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(65,58): error CS1061: 'object' does not contain a definition for 'Ttl' and no accessible extension method 'Ttl' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(69,38): error CS1061: 'object' does not contain a definition for 'Name' and no accessible extension method 'Name' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(70,38): error CS1061: 'object' does not contain a definition for 'Id' and no accessible extension method 'Id' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,21): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,38): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(32,62): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(33,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(35,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(38,65): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(39,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,46): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,63): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(55,46): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(57,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(60,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(65,58): error CS1061: 'object' does not contain a definition for 'Ttl' and no accessible extension method 'Ttl' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(69,38): error CS1061: 'object' does not contain a definition for 'Name' and no accessible extension method 'Name' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(70,38): error CS1061: 'object' does not contain a definition for 'Id' and no accessible extension method 'Id' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from d463274. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-26 03:30:16 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-advisor"
cmderr	[generate.py] 2021-02-26 03:30:16 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-26 03:30:16 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/advisor/azure-resourcemanager-advisor --java.namespace=com.azure.resourcemanager.advisor   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md
cmderr	[generate.py] 2021-02-26 03:30:56 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-26 03:30:56 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-26 03:30:56 INFO [POM][Skip] pom already has module azure-resourcemanager-advisor
cmderr	[generate.py] 2021-02-26 03:30:56 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-26 03:30:56 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-26 03:30:56 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-advisor [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-26 03:34:06 DEBUG Got artifact_id: azure-resourcemanager-advisor
cmderr	[Inst] 2021-02-26 03:34:06 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-26 03:34:06 DEBUG Got artifact: azure-resourcemanager-advisor-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-26 03:34:06 DEBUG Got artifact: azure-resourcemanager-advisor-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-26 03:34:06 DEBUG Got artifact: azure-resourcemanager-advisor-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-26 03:34:06 DEBUG Match jar package: azure-resourcemanager-advisor-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-26 03:34:06 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13177/azure-sdk-for-java/azure-resourcemanager-advisor/azure-resourcemanager-advisor-1.0.0-beta.1.jar\" -o azure-resourcemanager-advisor-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-advisor -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-advisor-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d463274. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️advisor/mgmt/2020-01-01/advisor [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `SuppressionsClient.Create` return value(s) have been changed from `(SuppressionContract, error)` to `(SetObject, error)`
info	[Changelog] - Function `SuppressionsClient.CreateResponder` return value(s) have been changed from `(SuppressionContract, error)` to `(SetObject, error)`
info	[Changelog] - Field `autorest.Response` of struct `SuppressionContract` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `ResourceMetadata.MarshalJSON() ([]byte, error)`
info	[Changelog] - New field `Plural` in struct `ResourceMetadata`
info	[Changelog] - New field `Action` in struct `ResourceMetadata`
info	[Changelog] - New field `Singular` in struct `ResourceMetadata`
info	[Changelog] - New field `LearnMoreLink` in struct `RecommendationProperties`
info	[Changelog] - New field `Actions` in struct `RecommendationProperties`
info	[Changelog] - New field `Remediation` in struct `RecommendationProperties`
info	[Changelog] - New field `ExposedMetadataProperties` in struct `RecommendationProperties`
info	[Changelog] - New field `Description` in struct `RecommendationProperties`
info	[Changelog] - New field `Label` in struct `RecommendationProperties`
info	[Changelog] - New field `PotentialBenefits` in struct `RecommendationProperties`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 3 additive change(s).
info	[Changelog]

️✔️advisor/mgmt/2017-04-19/advisor [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️advisor/mgmt/2017-03-31/advisor [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/advisor/mgmt/2016-07-12-preview/advisor [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-26T02:28:15Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

mudit794 · 2021-02-26T02:38:04Z

@ChenTanyi Can you please review this PR. This is to fix following S360 item where properties are missing in swagger.

https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/8187800

S360 item - https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=AssignedTo:All~KPI:cf751b97-2c95-420f-baa8-9a16e8643a5b~SLA:1~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=prasank_team;ddove_team;sagupt_team;johurta_team&tile=S360_ServiceId:f6d7f416-ee14-4943-894b-1abca9140b74~_loc:__key__UnifiedPlatform__cf751b97-2c95-420f-baa8-9a16e8643a5b&global=4:f6d7f416-ee14-4943-894b-1abca9140b74

ChenTanyi

@mudit794 Are all your changes belong to S360 fix? Could you also add someone (maybe in your team) to review it as well.

specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json

mudit794 · 2021-02-26T03:09:30Z

@mudit794 Are all your changes belong to S360 fix? Could you also add someone (maybe in your team) to review it as well.

@ChenTanyi These are all missing properties (some of them appear in special cases - not required). Yenchun from my team has reviewed and signed off on it.

…table/2020-01-01 (Azure#13177) * Update advisor.json Add additional property * Update GetRecommendationDetail.json * Update ListRecommendations.json * Update GetRecommendationDetail.json * Update advisor.json * move property to botton

mudit794 added 4 commits February 25, 2021 18:10

Update advisor.json

0257048

Add additional property

Update GetRecommendationDetail.json

1ae1a9a

Update ListRecommendations.json

f9388d2

Update GetRecommendationDetail.json

356fec5

openapi-workflow-bot bot added the FixS360 label Feb 26, 2021

mudit794 marked this pull request as ready for review February 26, 2021 02:29

openapi-assignment-bot bot assigned ChenTanyi Feb 26, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 26, 2021

openapi-sdkautomation bot mentioned this pull request Feb 26, 2021

[AutoPR Microsoft.Azure.Management.Advisor] [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 AzureSDKAutomation/azure-sdk-for-net#3363

Closed

Update advisor.json

222b110

openapi-sdkautomation bot mentioned this pull request Feb 26, 2021

[AutoPR azure-resourcemanager-advisor] [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 AzureSDKAutomation/azure-sdk-for-java#7658

Closed

ChenTanyi reviewed Feb 26, 2021

View reviewed changes

specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json Outdated Show resolved Hide resolved

move property to botton

85a9a8b

mudit794 requested a review from yenchunchang February 26, 2021 03:03

yenchunchang approved these changes Feb 26, 2021

View reviewed changes

ChenTanyi approved these changes Feb 26, 2021

View reviewed changes

ChenTanyi added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 26, 2021

ChenTanyi merged commit d463274 into Azure:master Feb 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #13177

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #13177

mudit794 commented Feb 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 26, 2021

openapi-pipeline-app bot commented Feb 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 26, 2021

mudit794 commented Feb 26, 2021 •

edited

Loading

ChenTanyi left a comment

mudit794 commented Feb 26, 2021

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #13177

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #13177

Conversation

mudit794 commented Feb 26, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Feb 26, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Feb 26, 2021

openapi-pipeline-app bot commented Feb 26, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 26, 2021

mudit794 commented Feb 26, 2021 • edited Loading

ChenTanyi left a comment

Choose a reason for hiding this comment

mudit794 commented Feb 26, 2021

mudit794 commented Feb 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 26, 2021 •

edited

Loading

mudit794 commented Feb 26, 2021 •

edited

Loading