Microsoft.Compute: Add new stable API version 2021-03-01 for CloudServices resource #13149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into stehou_addGaVersionForCS
|
Hi, @stephenhou Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'PUT' operation 'CloudServicesUpdateDomain_WalkUpdateDomain' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1300 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1889 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1968 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2094 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2131 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2226 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2321 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2526 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2622 |
|
| Only 'application/json' content-type is supported by ARM. Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L433 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-03-01 |
️❌ModelValidation: 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Response statusCode "200" for operation "CloudServiceRoleInstances_GetRemoteDesktopFile" has no response body provided in the example, however the response does have a "schema" defined in the swagger spec. |
|
In operation "CloudServicesUpdateDomain_WalkUpdateDomain", parameter updateDomain is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1316 |
|
In operation "CloudServicesUpdateDomain_GetUpdateDomain", parameter updateDomain is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1381 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 6 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-10-01-preview/cloudService.json <---> new: stable/2021-03-01/cloudService.json
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 2 Errors, 331 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "description":"The Offer Promotion Code.", "$ref":"#/components/schemas/schemas:1246" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Error: Plugin prechecker reported failure." |
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'ComputeOperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'ComputeOperationValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'ComputeOperationValueDisplay' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'DisallowedConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'RetrieveBootDiagnosticsDataResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'InstanceViewStatus' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'AvailabilitySetProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"The schema 'AvailabilitySet' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi, @stephenhou your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @yungezz |
|
Hi @stephenhou, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 24, 2021
| "subscriptionId": "{subscription-id}", | ||
| "resourceGroupName": "ConstosoRG", | ||
| "cloudServiceName": "{cs-name}", | ||
| "api-version": "2021-03-01", |
There was a problem hiding this comment.
To easily identify the delta changes from previous api version, the recommendation is to copy the existing version into new directory structure for first commit and then push new changes in subsequent commits. Please raise a new PR with the suggested recommendation for faster review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSED. PLEASE REFER TO: #13155