ADP 2021-02-01-preview #13090
Merged
ADP 2021-02-01-preview #13090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @aelij Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Hi, @aelij your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @weidongxu-microsoft |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.AutonomousDevelopmentPlatform/preview/2021-02-01-preview/adp.json#L678 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 55 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-07-01-preview/adp.json <---> new: preview/2021-02-01-preview/adp.json
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 20 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'Tags' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'AccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'AccountList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'DataPool' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'DataPoolPatch' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'DataPoolBaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'DataPoolProperties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'DataPoolLocation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'DataPoolList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"adp/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @aelij, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 22, 2021
|
@aelij - As there are multiple new files in this PR, its difficult to identify the delta changes between old preview and new preview version. While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review. |
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2021-02-01-preview", |
There was a problem hiding this comment.
While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.
|
@RamyasreeChakka I've created a PR as you suggested. Once it's merged, will rebase this one. |
@aelij - We can't check-in the 13099 PR as is as into a public repo. Please make the rest of the changes in next commits. While reviewing the PR, I will exclude the changes in first commit and review rest of the changes. |
|
@RamyasreeChakka then there was no need for another branch :) I just added the commit and force-pushed this one. |
...resource-manager/Microsoft.AutonomousDevelopmentPlatform/preview/2021-02-01-preview/adp.json
Show resolved
Hide resolved
ArcturusZhang
requested changes
Feb 24, 2021
ArcturusZhang
approved these changes
Feb 24, 2021
ArcturusZhang
approved these changes
Feb 24, 2021
weidongxu-microsoft
approved these changes
Feb 24, 2021
|
@aelij Ah sorry, I directly merged it. Let me know whether this PR is planned to be merged now. If not, I will revert it, and prepare another PR. |
|
@weidongxu-microsoft It's fine by me |
This was referenced Feb 24, 2021
|
@weidongxu-microsoft do you know why the ARM schemas PR (Azure/azure-resource-manager-schemas#1320) contains only version The pipeline log indicates both were processed by autorest: And running locally creates both files. |
ctaggart
reviewed
Apr 8, 2021
| ``` | ||
|
|
||
| ### Tag: package-2020-07-01-preview |
There was a problem hiding this comment.
The Tag sections are needed by AutoRest and other code generators.
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* ADP version 2021-02-01-preview (initial commit) * ADP 2021-02-01-preview * Update readmes * Update codeowners * Fix validation errors * Add type:object * Add encryption example * Restore package- convention * Prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.