Request to update Redis Enterprise version stable/2021-03-01 #12967

greenms · 2021-02-12T01:30:02Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, correct typo in example
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…1-preview to version 2021-03-01

…nd fix operationId

…3-01

openapi-workflow-bot · 2021-02-12T01:30:04Z

Hi, @greenms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

greenms · 2021-02-12T06:28:07Z

/azp run

azure-pipelines · 2021-02-12T06:28:21Z

Azure Pipelines successfully started running 2 pipeline(s).

greenms · 2021-02-12T17:48:32Z

/azp run

azure-pipelines · 2021-02-12T17:48:46Z

Azure Pipelines successfully started running 2 pipeline(s).

greenms · 2021-02-12T19:36:51Z

/azp run

openapi-pipeline-app · 2021-02-12T19:36:54Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️🔄[Staging] Cross Version BreakingChange (Base on stable version) inProgress [Detail]

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-12T19:36:54Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 17d2a30. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/redisenterprise/resource-manager/readme.md

️✔️@azure/arm-redisenterprisecache [View full logs] [Release SDK Changes]

azure-arm-redisenterprisecache-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/redisEnterpriseManagementClient.js → ./dist/arm-redisenterprisecache.js...
cmderr	[npmPack] created ./dist/arm-redisenterprisecache.js in 347ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2021-02-12T19:37:06Z

Azure Pipelines successfully started running 2 pipeline(s).

greenms · 2021-02-12T19:43:07Z

The failing SDK azure-sdk-for-python-track2 check is not caused by changes introduced in this PR. Please merge this PR.

…2967) * Adds base for updating Microsoft.Cache from version preview/2020-10-01-preview to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add support for persistence and fix other typos * Fix SDK Warning: R2063 OperationIdNounConflictingModelNames * Fix spellcheck error * Fix acronym capitalization in descriptions * Replace local parameters with common-types parameters * Use naming convention consistent with Azure documentation * Update word choice, remove deprecated x-ms-code-generation-setting, and fix operationId * Add x-ms-secret extension and make TLS version a string enum * Suppress errors about secrets being sent in responses * Fix operation typo in example

greenms and others added 16 commits February 2, 2021 19:06

Adds base for updating Microsoft.Cache from version preview/2020-10-0…

1211ad7

…1-preview to version 2021-03-01

Updates readme

72fa2b3

Updates API version in new specs and examples

ac18ed4

Add support for persistence and fix other typos

af81ba0

Fix SDK Warning: R2063 OperationIdNounConflictingModelNames

83e7ebf

Fix spellcheck error

5d67284

Fix acronym capitalization in descriptions

8da67e4

Replace local parameters with common-types parameters

cb5b7de

Use naming convention consistent with Azure documentation

918725d

Update word choice, remove deprecated x-ms-code-generation-setting, a…

c074f14

…nd fix operationId

Add x-ms-secret extension and make TLS version a string enum

4681e83

Suppress errors about secrets being sent in responses

72aa952

Merge remote-tracking branch 'upstream/master' into master

7826399

Merge remote-tracking branch 'upstream/master' into master

dd12fe8

Merge branch 'master' into dev-redisenterprise-Microsoft.Cache-2021-0…

f837d98

…3-01

Fix operation typo in example

cae1bec

openapi-assignment-bot bot assigned markcowl Feb 12, 2021

greenms requested a review from TimLovellSmith February 12, 2021 01:32

greenms changed the title ~~[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01~~ Request to update Redis Enterprise version stable/2021-03-01 Feb 12, 2021

greenms mentioned this pull request Feb 12, 2021

[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01 #12829

Merged

25 tasks

TimLovellSmith approved these changes Feb 12, 2021

View reviewed changes

openapi-sdkautomation bot mentioned this pull request Feb 12, 2021

[AutoPR @azure/arm-redisenterprisecache] Request to update Redis Enterprise version stable/2021-03-01 AzureSDKAutomation/azure-sdk-for-js#3625

Closed

markcowl approved these changes Feb 16, 2021

View reviewed changes

markcowl added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 16, 2021

allenjzhang approved these changes Feb 17, 2021

View reviewed changes

allenjzhang merged commit 17d2a30 into Azure:master Feb 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Request to update Redis Enterprise version stable/2021-03-01 #12967

Request to update Redis Enterprise version stable/2021-03-01 #12967

greenms commented Feb 12, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 12, 2021

greenms commented Feb 12, 2021

azure-pipelines bot commented Feb 12, 2021

greenms commented Feb 12, 2021

azure-pipelines bot commented Feb 12, 2021

greenms commented Feb 12, 2021

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading

azure-pipelines bot commented Feb 12, 2021

greenms commented Feb 12, 2021

Request to update Redis Enterprise version stable/2021-03-01 #12967

Request to update Redis Enterprise version stable/2021-03-01 #12967

Conversation

greenms commented Feb 12, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 12, 2021

greenms commented Feb 12, 2021

azure-pipelines bot commented Feb 12, 2021

greenms commented Feb 12, 2021

azure-pipelines bot commented Feb 12, 2021

greenms commented Feb 12, 2021

openapi-pipeline-app bot commented Feb 12, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 12, 2021 • edited Loading

Swagger Generation Artifacts

azure-pipelines bot commented Feb 12, 2021

greenms commented Feb 12, 2021

greenms commented Feb 12, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading